All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 09/10] drm/i915: Add debugfs entries for reading out DPCD DSC and FEC.
Date: Fri, 23 Aug 2019 13:19:10 +0300	[thread overview]
Message-ID: <874l28b2w1.fsf@intel.com> (raw)
In-Reply-To: <20190821133221.29456-10-maarten.lankhorst@linux.intel.com>

On Wed, 21 Aug 2019, Maarten Lankhorst <maarten.lankhorst@linux.intel.com> wrote:
> Dump the DSC and FEC in i915_dpcd as well. This is useful when
> debugging the link caps.

I thought we were going to get rid of this particular debugfs file
altogether ages ago. You can dump the DPCD using
CONFIG_DRM_DP_AUX_CHARDEV=y and dd on /dev/drm_dp_auxN.

BR,
Jani.

>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 610bc9b5d740..c2f15de07427 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -4396,8 +4396,10 @@ struct dpcd_block {
>  
>  static const struct dpcd_block i915_dpcd_debug[] = {
>  	{ .offset = DP_DPCD_REV, .size = DP_RECEIVER_CAP_SIZE },
> +	{ .offset = DP_DSC_SUPPORT, .end = DP_DSC_BITS_PER_PIXEL_INC },
>  	{ .offset = DP_PSR_SUPPORT, .end = DP_PSR_CAPS },
>  	{ .offset = DP_DOWNSTREAM_PORT_0, .size = 16 },
> +	{ .offset = DP_FEC_CAPABILITY },
>  	{ .offset = DP_LINK_BW_SET, .end = DP_EDP_CONFIGURATION_SET },
>  	{ .offset = DP_SINK_COUNT, .end = DP_ADJUST_REQUEST_LANE2_3 },
>  	{ .offset = DP_SET_POWER },

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-08-23 10:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21 13:32 [PATCH 00/10] drm/i915: Bigjoiner preparations Maarten Lankhorst
2019-08-21 13:32 ` [PATCH 01/10] drm/i915/dp: Fix dsc bpp calculations Maarten Lankhorst
2019-08-21 17:05   ` Manasi Navare
2019-08-23 10:17     ` [Intel-gfx] " Jani Nikula
2019-08-26 11:33       ` Maarten Lankhorst
2019-08-26 16:50         ` Manasi Navare
2019-08-21 13:32 ` [PATCH 02/10] drm/i915: Prepare to split crtc state in uapi and hw state Maarten Lankhorst
2019-08-21 13:32 ` [PATCH 03/10] drm/i915: Handle a few more cases for hw/sw split Maarten Lankhorst
2019-08-21 13:32 ` [PATCH 04/10] drm/i915: Complete sw/hw split Maarten Lankhorst
2019-08-21 13:32 ` [PATCH 05/10] drm/i915: Kill off is_planar_yuv_format Maarten Lankhorst
2019-08-21 13:32 ` [PATCH 06/10] drm/i915: Get rid of crtc_state->fb_changed Maarten Lankhorst
2019-08-21 13:32 ` [PATCH 07/10] drm/i915: Remove begin/finish_crtc_commit Maarten Lankhorst
2019-08-22 13:15   ` Lisovskiy, Stanislav
2019-08-21 13:32 ` [PATCH 08/10] drm/i915: Do not add all planes when checking scalers on glk+ Maarten Lankhorst
2019-09-10  9:44   ` Ville Syrjälä
2019-08-21 13:32 ` [PATCH 09/10] drm/i915: Add debugfs entries for reading out DPCD DSC and FEC Maarten Lankhorst
2019-08-23 10:19   ` Jani Nikula [this message]
2019-08-21 13:32 ` [PATCH 10/10] drm/i915: Move FEC enable timeout wait to enable_ddi_dp Maarten Lankhorst
2019-08-21 14:41 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Bigjoiner preparations Patchwork
2019-08-21 15:02 ` ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874l28b2w1.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.