Re: [PATCH] drm/i915/selftests: Ensure we don't clamp a random offset to 32b

[Mika Kuoppala <mika.kuoppala@linux.intel.com>]

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Specify that we do want a 64b value for sizeof(u32) as we want to
> compute the mask of the upper 62bits.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> index 3abe15a08b6d..275ec1bfc2be 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> @@ -1539,7 +1539,7 @@ static int igt_vm_isolation(void *arg)
>  
>  			div64_u64_rem(i915_prandom_u64_state(&prng),
>  				      vm_total, &offset);
> -			offset &= -sizeof(u32);
> +			offset &= -(u64)sizeof(u32);

Taking a sizeof of something we know the size of.
Ok enough! Back to business:

should be the same for 64bit, but make sure for 32.

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>


>  			offset += I915_GTT_PAGE_SIZE;
>  
>  			err = write_to_scratch(ctx_a, engine,
> -- 
> 2.22.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx