Re: [Qemu-devel] [PULL for-4.1 0/9] Miscellaneous patches for 2019-04-18

[Markus Armbruster <armbru@redhat.com>]

Peter Maydell <peter.maydell@linaro.org> writes:

> On Thu, 18 Apr 2019 at 21:40, Markus Armbruster <armbru@redhat.com> wrote:
>>
>> Early pull request because I'll be on vacation when 4.1 opens.  Hope
>> that's okay.
>>
>> The following changes since commit eeba63fc7fface36f438bcbc0d3b02e7dcb59983:
>>
>>   Update version for v4.0.0-rc4 release (2019-04-16 21:53:00 +0100)
>>
>> are available in the Git repository at:
>>
>>   git://repo.or.cz/qemu/armbru.git tags/pull-misc-2019-04-18
>>
>> for you to fetch changes up to 15136db27efaf0bdcf1131d41ad57832a2acadcc:
>>
>>   Clean up decorations and whitespace around header guards (2019-04-17 19:20:46 +0200)
>>
>> ----------------------------------------------------------------
>> Miscellaneous patches for 2019-04-18
>>
>> ----------------------------------------------------------------
>> Markus Armbruster (9):
>>       Clean up includes
>>       Use #include "..." for our own headers, <...> for others
>>       authz: Normalize #include "authz/trace.h" to "trace.h"
>>       linux-user/nios2 linux-user/riscv: Clean up header guards
>>       target/xtensa: Clean up core-isa.h header guards
>>       Clean up header guards that don't match their file name
>>       Clean up ill-advised or unusual header guards
>>       Normalize header guard symbol definition.
>>       Clean up decorations and whitespace around header guards
>
> Hi -- this fails 'make check' on ppc64 and s390, so likely
> a big-endian hosts issue:
>
> make[1]: Leaving directory `/home/pm215/qemu/build/all/tests/fp'
> cd /home/pm215/qemu/build/all/tests/fp && ./fp-test -s -l 1 -r all
> i32_to_f16 i64_to_f16 i32_to_f32 i64_to_f32 i32_to_f64 i64_to_f64
> i32_to_f128 i64_to_f128 >  int-to-float.out 2>&1 || (cat
> int-to-float.out && exit 1;)
>>> Testing i32_to_f16, rounding near_even
> ^M372 tests total.
> ^M372 tests performed.
> In 372 tests, no errors found in i32_to_f16, rounding near_even.
> [...]
>>> Testing i32_to_f128
> ^M372 tests total.
> ^MErrors found in i32_to_f128:
> 1006FFFF  => +0000.000000000000401B006FFFF00000 .....
>         expected +401B.006FFFF000000000000000000000 .....
> ^M0001DDEB  => +0000.000000000000400FDDEB00000000 .....
>         expected +400F.DDEB000000000000000000000000 .....
> ^MFFF6FFFC  => +0000.000000000000C012200080000000 .....
>         expected -4012.2000800000000000000000000000 .....
> [...]
> ^M00000020  => +0000.0000000000004004000000000000 .....
>         expected +4004.0000000000000000000000000000 .....
> ^M21 tests performed; 20 errors found.
> make: *** [check-softfloat-conv] Error 1

Awesome.

Luckily, Laurent included just PATCH 1/9 in his trivial pull request,
and had it fail the same:
Message-ID: <CAFEAcA9-hAU5dxUmSWtbvrPEXE-nCP1uLvLbOby-_EXZ27o+8g@mail.gmail.com>

See there for additional clues.