All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] bird: new package
Date: Fri, 28 Sep 2018 00:01:17 +0300	[thread overview]
Message-ID: <874lea4puq.fsf@tkos.co.il> (raw)
In-Reply-To: <20180927204116.29484-1-adrien@gallouet.fr>

Hi Adrien,

Adrien Gallou?t writes:
> diff --git a/package/bird/bird.mk b/package/bird/bird.mk
> new file mode 100644
> index 0000000000..959021f94f
> --- /dev/null
> +++ b/package/bird/bird.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# bird
> +#
> +################################################################################
> +
> +BIRD_VERSION = 2.0.2
> +BIRD_SOURCE = v$(BIRD_VERSION).tar.gz
> +BIRD_SITE = https://github.com/BIRD/bird/archive

Please use the github helper:

  BIRD_SITE = $(call github,BIRD,bird,$(BIRD_VERSION))

BIRD_SOURCE should not be needed.

> +BIRD_LICENSE = GPL-2.0+
> +BIRD_LICENSE_FILES = README
> +BIRD_AUTORECONF = YES

Please mention in a comment that autoreconf is needed since the package
is fetched from github so there is no configure script.

> +
> +$(eval $(autotools-package))

baruch

--
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2018-09-27 21:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-27 20:41 [Buildroot] [PATCH 1/1] bird: new package Adrien Gallouët
2018-09-27 21:01 ` Baruch Siach [this message]
2018-09-27 22:21 ` [Buildroot] [PATCH v2 " Adrien Gallouët
2018-10-09 12:47   ` Thomas Petazzoni
2018-10-09 13:30     ` Adrien Gallouët

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874lea4puq.fsf@tkos.co.il \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.