From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc Date: Tue, 24 Apr 2018 17:41:32 +0200 Message-ID: <874lk07gsz.fsf@toke.dk> References: <1512338775-3270-1-git-send-email-dave.taht@gmail.com> <20180424114407.5939-1-toke@toke.dk> <20180424081406.5127f1bc@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Cake List , netdev@vger.kernel.org To: Georgios Amanakis Return-path: Received: from mail.toke.dk ([52.28.52.200]:37769 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbeDXPld (ORCPT ); Tue, 24 Apr 2018 11:41:33 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Georgios Amanakis writes: > On Tue, 24 Apr 2018 13:44:06 +0200 > Toke H=C3=B8iland-J=C3=B8rgensen wrote: > >> +config NET_SCH_CAKE >> + tristate "Common Applications Kept Enhanced (CAKE)" >> + help >> + Say Y here if you want to use the Common Applications Kept Enh= anced >> + (CAKE) queue management algorithm. >> + >> + To compile this driver as a module, choose M here: the module >> + will be called sch_cake. > > In net/sched/Kconfig we should probably add NF_CONNTRACK as a dependency: > "depends on NF_CONNTRACK" > > Otherwise if NET_SCH_CAKE=3Dy and NF_CONNTRACK=3Dm compilation fails with: > > net/sched/sch_cake.o: In function `cake_enqueue': > sch_cake.c:(.text+0x3e10): undefined reference to `nf_ct_get_tuplepr' > sch_cake.c:(.text+0x3e3a): undefined reference to `nf_conntrack_find_get' > make: *** [Makefile:1041: vmlinux] Error 1 Hmm we really don't want to have a hard depend on conntrack. We currently ifdef the conntrack-specific bits thus: #if IS_ENABLED(CONFIG_NF_CONNTRACK). Does anyone know if there is a way to do this so the module/builtin split doesn't bite us? -Toke