From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751089AbeCNJf7 (ORCPT ); Wed, 14 Mar 2018 05:35:59 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:40678 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750751AbeCNJf5 (ORCPT ); Wed, 14 Mar 2018 05:35:57 -0400 From: Vitaly Kuznetsov To: "Michael Kelley \(EOSG\)" Cc: "kvm\@vger.kernel.org" , "x86\@kernel.org" , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Mohammed Gamal , Cathy Avery , Bandan Das , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH v3 1/7] x86/hyper-v: move hyperv.h out of uapi References: <20180309140249.2840-1-vkuznets@redhat.com> <20180309140249.2840-2-vkuznets@redhat.com> Date: Wed, 14 Mar 2018 10:35:52 +0100 In-Reply-To: (Michael Kelley's message of "Tue, 13 Mar 2018 22:46:10 +0000") Message-ID: <874lljc83r.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Michael Kelley (EOSG)" writes: >> -----Original Message----- >> From: Vitaly Kuznetsov >> Sent: Friday, March 9, 2018 6:03 AM >> To: kvm@vger.kernel.org >> Cc: x86@kernel.org; Paolo Bonzini ; Radim Krčmář >> ; KY Srinivasan ; Haiyang Zhang >> ; Stephen Hemminger ; Michael >> Kelley (EOSG) ; Mohammed Gamal >> ; Cathy Avery ; Bandan Das ; >> linux-kernel@vger.kernel.org >> Subject: [PATCH v3 1/7] x86/hyper-v: move hyperv.h out of uapi >> >> hyperv.h is not part of uapi, there are no (known) users outside of kernel. >> We are making changes to this file to match current Hyper-V TLFS and we >> don't want to maintain backwards compatibility. >> >> Move the file renaming to hyperv-tlfs.h to avoid confusing it with >> mshyperv.h. In future, all definitions from TLFS should go to it and >> all kernel objects should go to mshyperv.h or include/linux/hyperv.h. >> >> Signed-off-by: Vitaly Kuznetsov >> --- > > [snip] > >> diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c >> index 447371f4de56..72855182b191 100644 >> --- a/drivers/hv/connection.c >> +++ b/drivers/hv/connection.c >> @@ -31,7 +31,6 @@ >> #include >> #include >> #include >> -#include > > This #include should remain and be changed to asm/hyperv-tlfs.h. This > file uses the hypercall status values HV_STATUS_*. > >> #include My idea was that already includes so there's no need to include them both. >> >> #include "hyperv_vmbus.h" >> diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c >> index fe96aab9e794..45f3694bbb76 100644 >> --- a/drivers/hv/hv.c >> +++ b/drivers/hv/hv.c >> @@ -29,7 +29,6 @@ >> #include >> #include >> #include >> -#include > > This #include should remain and be changed to asm/hyperv-tlfs.h. This > file uses HV_MESSAGE_* values. > Ditto. >> #include >> #include "hyperv_vmbus.h" >> >> diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h >> index 22300ec7b556..500f805a6ef2 100644 >> --- a/drivers/hv/hyperv_vmbus.h >> +++ b/drivers/hv/hyperv_vmbus.h >> @@ -27,6 +27,7 @@ >> >> #include >> #include >> +#include >> #include >> #include >> #include >> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c >> index bc65c4d79c1f..b10fe26c4891 100644 >> --- a/drivers/hv/vmbus_drv.c >> +++ b/drivers/hv/vmbus_drv.c >> @@ -36,7 +36,6 @@ >> #include >> #include >> >> -#include > > This #include should remain and be changed to asm/hyperv-tlfs.h. This > file uses HVMSG_* values. > Ditto. >> #include >> #include >> #include Thanks for the review! -- Vitaly