From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2 2/3] drm/i915/guc: Make scratch register base and count flexible Date: Thu, 04 May 2017 16:22:15 +0300 Message-ID: <874lx0pxiw.fsf@intel.com> References: <20170502123937.53556-1-michal.wajdeczko@intel.com> <20170504124813.47776-1-michal.wajdeczko@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 250C76E1D8 for ; Thu, 4 May 2017 13:19:49 +0000 (UTC) In-Reply-To: <20170504124813.47776-1-michal.wajdeczko@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michal Wajdeczko , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAwNCBNYXkgMjAxNywgTWljaGFsIFdhamRlY3prbyA8bWljaGFsLndhamRlY3prb0Bp bnRlbC5jb20+IHdyb3RlOgo+IFdlIGFyZSB1c2luZyBzb21lIHNjcmF0Y2ggcmVnaXN0ZXJzIGlu IE1NSU8gYmFzZWQgc2VuZCBmdW5jdGlvbi4KPiBNYWtlIHRoZWlyIGJhc2UgYW5kIGNvdW50IGZs ZXhpYmxlIGluIHByZXBhcmF0aW9uIG9mIHVwY29taW5nCj4gR3VDIGZpcm13YXJlL2hhcmR3YXJl IGNoYW5nZXMuIFdoaWxlIGFyb3VuZCwgY2hhbmdlIGNtZCBsZW4KPiBwYXJhbWV0ZXIgdmVyaWZp Y2F0aW9uIGZyb20gV0FSTl9PTiB0byBHRU1fQlVHX09OIGFzIHdlIGRvbid0Cj4gbmVlZCB0aGlz IGFsbCB0aGUgdGltZS4KCkknbSBub3QgZ2VuZXJhbGx5IGZvbmQgb2YgY2FjaGluZyB0aGUgcmVn aXN0ZXJzIGxpa2UgdGhpcyBvciBhZGRpbmcKX01NSU8oKSB3cmFwcGluZyBvdXRzaWRlIG9mIGk5 MTVfcmVnLmguIFN1cmUsIHdlIGhhdmUgc29tZSBvZiB0aGF0IGhlcmUKYW5kIHRoZXJlLCBidXQg aGVyZSBpdCdzIGhhcmQgdG8gc2VlIHRoZSByYXRpb25hbGUgYmVjYXVzZSB5b3UgZG8gdGhpcwpp biBwcmVwYXJhdGlvbiBmb3Igc29tZXRoaW5nIHRoYXQgd2UgeW91J3JlIG5vdCBzaGFyaW5nLgoK QlIsCkphbmkuCgo+Cj4gdjI6IGNhbGwgb3V0IFdBUk4vR0VNX0JVRyBjaGFuZ2UgaW4gdGhlIGNv bW1pdCBtc2cgKERhbmllbGUpCj4KPiBTaWduZWQtb2ZmLWJ5OiBNaWNoYWwgV2FqZGVjemtvIDxt aWNoYWwud2FqZGVjemtvQGludGVsLmNvbT4KPiBTdWdnZXN0ZWQtYnk6IERhbmllbGUgQ2VyYW9s byBTcHVyaW8gPGRhbmllbGUuY2VyYW9sb3NwdXJpb0BpbnRlbC5jb20+Cj4gQ2M6IERhbmllbGUg Q2VyYW9sbyBTcHVyaW8gPGRhbmllbGUuY2VyYW9sb3NwdXJpb0BpbnRlbC5jb20+Cj4gQ2M6IEpv b25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPiBSZXZpZXdl ZC1ieTogRGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8ZGFuaWVsZS5jZXJhb2xvc3B1cmlvQGludGVs LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYyB8IDQxICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3VjLmggfCAgNyArKysrKysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgNDEgaW5zZXJ0 aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF91Yy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYwo+IGluZGV4 IDcyZjQ5ZTYuLjlkMTFjNDIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfdWMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmMKPiBAQCAtMjYw LDkgKzI2MCwzNiBAQCB2b2lkIGludGVsX3VjX2ZpbmlfZncoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2KQo+ICAJX19pbnRlbF91Y19md19maW5pKCZkZXZfcHJpdi0+aHVjLmZ3KTsK PiAgfQo+ICAKPiArc3RhdGljIGlubGluZSBpOTE1X3JlZ190IGd1Y19zZW5kX3JlZyhzdHJ1Y3Qg aW50ZWxfZ3VjICpndWMsIHUzMiBpKQo+ICt7Cj4gKwlHRU1fQlVHX09OKCFndWMtPnNlbmRfcmVn cy5iYXNlKTsKPiArCUdFTV9CVUdfT04oIWd1Yy0+c2VuZF9yZWdzLmNvdW50KTsKPiArCUdFTV9C VUdfT04oaSA+PSBndWMtPnNlbmRfcmVncy5jb3VudCk7Cj4gKwo+ICsJcmV0dXJuIF9NTUlPKGd1 Yy0+c2VuZF9yZWdzLmJhc2UgKyA0ICogaSk7Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIGd1Y19p bml0X3NlbmRfcmVncyhzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4gK3sKPiArCXN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGd1Y190b19pOTE1KGd1Yyk7Cj4gKwllbnVtIGZvcmNl d2FrZV9kb21haW5zIGZ3X2RvbWFpbnMgPSAwOwo+ICsJdTMyIGk7Cj4gKwo+ICsJZ3VjLT5zZW5k X3JlZ3MuYmFzZSA9IGk5MTVfbW1pb19yZWdfb2Zmc2V0KFNPRlRfU0NSQVRDSCgwKSk7Cj4gKwln dWMtPnNlbmRfcmVncy5jb3VudCA9IFNPRlRfU0NSQVRDSF9DT1VOVCAtIDE7Cj4gKwo+ICsJZm9y IChpID0gMDsgaSA8IGd1Yy0+c2VuZF9yZWdzLmNvdW50OyBpKyspIHsKPiArCQlmd19kb21haW5z IHw9IGludGVsX3VuY29yZV9mb3JjZXdha2VfZm9yX3JlZyhkZXZfcHJpdiwKPiArCQkJCQlndWNf c2VuZF9yZWcoZ3VjLCBpKSwKPiArCQkJCQlGV19SRUdfUkVBRCB8IEZXX1JFR19XUklURSk7Cj4g Kwl9Cj4gKwlndWMtPnNlbmRfcmVncy5md19kb21haW5zID0gZndfZG9tYWluczsKPiArfQo+ICsK PiAgc3RhdGljIGludCBndWNfZW5hYmxlX2NvbW11bmljYXRpb24oc3RydWN0IGludGVsX2d1YyAq Z3VjKQo+ICB7Cj4gIAkvKiBYWFg6IHBsYWNlaG9sZGVyIGZvciBhbHRlcm5hdGUgc2V0dXAgKi8K PiArCWd1Y19pbml0X3NlbmRfcmVncyhndWMpOwo+ICAJZ3VjLT5zZW5kID0gaW50ZWxfZ3VjX3Nl bmRfbW1pbzsKPiAgCXJldHVybiAwOwo+ICB9Cj4gQEAgLTQwNywxOSArNDM0LDE5IEBAIGludCBp bnRlbF9ndWNfc2VuZF9tbWlvKHN0cnVjdCBpbnRlbF9ndWMgKmd1YywgY29uc3QgdTMyICphY3Rp b24sIHUzMiBsZW4pCj4gIAlpbnQgaTsKPiAgCWludCByZXQ7Cj4gIAo+IC0JaWYgKFdBUk5fT04o bGVuIDwgMSB8fCBsZW4gPiAxNSkpCj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwlHRU1fQlVHX09O KCFsZW4pOwo+ICsJR0VNX0JVR19PTihsZW4gPiBndWMtPnNlbmRfcmVncy5jb3VudCk7Cj4gIAo+ ICAJbXV0ZXhfbG9jaygmZ3VjLT5zZW5kX211dGV4KTsKPiAtCWludGVsX3VuY29yZV9mb3JjZXdh a2VfZ2V0KGRldl9wcml2LCBGT1JDRVdBS0VfQkxJVFRFUik7Cj4gKwlpbnRlbF91bmNvcmVfZm9y Y2V3YWtlX2dldChkZXZfcHJpdiwgZ3VjLT5zZW5kX3JlZ3MuZndfZG9tYWlucyk7Cj4gIAo+ICAJ ZGV2X3ByaXYtPmd1Yy5hY3Rpb25fY291bnQgKz0gMTsKPiAgCWRldl9wcml2LT5ndWMuYWN0aW9u X2NtZCA9IGFjdGlvblswXTsKPiAgCj4gIAlmb3IgKGkgPSAwOyBpIDwgbGVuOyBpKyspCj4gLQkJ STkxNV9XUklURShTT0ZUX1NDUkFUQ0goaSksIGFjdGlvbltpXSk7Cj4gKwkJSTkxNV9XUklURShn dWNfc2VuZF9yZWcoZ3VjLCBpKSwgYWN0aW9uW2ldKTsKPiAgCj4gLQlQT1NUSU5HX1JFQUQoU09G VF9TQ1JBVENIKGkgLSAxKSk7Cj4gKwlQT1NUSU5HX1JFQUQoZ3VjX3NlbmRfcmVnKGd1YywgaSAt IDEpKTsKPiAgCj4gIAlpbnRlbF9ndWNfbm90aWZ5KGd1Yyk7Cj4gIAo+IEBAIC00MjgsNyArNDU1 LDcgQEAgaW50IGludGVsX2d1Y19zZW5kX21taW8oc3RydWN0IGludGVsX2d1YyAqZ3VjLCBjb25z dCB1MzIgKmFjdGlvbiwgdTMyIGxlbikKPiAgCSAqIEZhc3QgY29tbWFuZHMgc2hvdWxkIHN0aWxs IGNvbXBsZXRlIGluIDEwdXMuCj4gIAkgKi8KPiAgCXJldCA9IF9faW50ZWxfd2FpdF9mb3JfcmVn aXN0ZXJfZncoZGV2X3ByaXYsCj4gLQkJCQkJICAgU09GVF9TQ1JBVENIKDApLAo+ICsJCQkJCSAg IGd1Y19zZW5kX3JlZyhndWMsIDApLAo+ICAJCQkJCSAgIElOVEVMX0dVQ19SRUNWX01BU0ssCj4g IAkJCQkJICAgSU5URUxfR1VDX1JFQ1ZfTUFTSywKPiAgCQkJCQkgICAxMCwgMTAsICZzdGF0dXMp Owo+IEBAIC00NTAsNyArNDc3LDcgQEAgaW50IGludGVsX2d1Y19zZW5kX21taW8oc3RydWN0IGlu dGVsX2d1YyAqZ3VjLCBjb25zdCB1MzIgKmFjdGlvbiwgdTMyIGxlbikKPiAgCX0KPiAgCWRldl9w cml2LT5ndWMuYWN0aW9uX3N0YXR1cyA9IHN0YXR1czsKPiAgCj4gLQlpbnRlbF91bmNvcmVfZm9y Y2V3YWtlX3B1dChkZXZfcHJpdiwgRk9SQ0VXQUtFX0JMSVRURVIpOwo+ICsJaW50ZWxfdW5jb3Jl X2ZvcmNld2FrZV9wdXQoZGV2X3ByaXYsIGd1Yy0+c2VuZF9yZWdzLmZ3X2RvbWFpbnMpOwo+ICAJ bXV0ZXhfdW5sb2NrKCZndWMtPnNlbmRfbXV0ZXgpOwo+ICAKPiAgCXJldHVybiByZXQ7Cj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmggYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF91Yy5oCj4gaW5kZXggMDk3Mjg5Yi4uYTM3YThjYyAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfdWMuaAo+IEBAIC0yMDUsNiArMjA1LDEzIEBAIHN0cnVjdCBpbnRlbF9ndWMg ewo+ICAJdWludDY0X3Qgc3VibWlzc2lvbnNbSTkxNV9OVU1fRU5HSU5FU107Cj4gIAl1aW50MzJf dCBsYXN0X3NlcW5vW0k5MTVfTlVNX0VOR0lORVNdOwo+ICAKPiArCS8qIEd1QydzIEZXIHNwZWNp ZmljIHJlZ2lzdGVycyB1c2VkIGluIE1NSU8gc2VuZCAqLwo+ICsJc3RydWN0IHsKPiArCQl1MzIg YmFzZTsKPiArCQl1MzIgY291bnQ7Cj4gKwkJdTMyIGZ3X2RvbWFpbnM7IC8qIGVudW0gZm9yY2V3 YWtlX2RvbWFpbnMgKi8KPiArCX0gc2VuZF9yZWdzOwo+ICsKPiAgCS8qIFRvIHNlcmlhbGl6ZSB0 aGUgaW50ZWxfZ3VjX3NlbmQgYWN0aW9ucyAqLwo+ICAJc3RydWN0IG11dGV4IHNlbmRfbXV0ZXg7 CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=