From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751714AbdBMJ6u (ORCPT ); Mon, 13 Feb 2017 04:58:50 -0500 Received: from out02.mta.xmission.com ([166.70.13.232]:50342 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbdBMJ6s (ORCPT ); Mon, 13 Feb 2017 04:58:48 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Konstantin Khlebnikov Cc: Al Viro , linux-kernel@vger.kernel.org, Andrew Morton References: <20170209084016.GL13195@ZenIV.linux.org.uk> <148671210259.52694.13774349516906955456.stgit@buzz> <20170210074715.GN13195@ZenIV.linux.org.uk> <26fa33ed-365e-f4c9-9270-421420c16163@yandex-team.ru> Date: Mon, 13 Feb 2017 22:54:14 +1300 In-Reply-To: <26fa33ed-365e-f4c9-9270-421420c16163@yandex-team.ru> (Konstantin Khlebnikov's message of "Fri, 10 Feb 2017 10:54:07 +0300") Message-ID: <874lzyct6h.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1cdDP7-0003DQ-90;;;mid=<874lzyct6h.fsf@xmission.com>;;;hst=in01.mta.xmission.com;;;ip=101.100.131.98;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX198QCbRQf5IAz+8HOEgaFObYPrSOB8QWNo= X-SA-Exim-Connect-IP: 101.100.131.98 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4999] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa08 1397; Body=1 Fuz1=1 Fuz2=1] X-Spam-DCC: XMission; sa08 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Konstantin Khlebnikov X-Spam-Relay-Country: X-Spam-Timing: total 5302 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 4.3 (0.1%), b_tie_ro: 3.1 (0.1%), parse: 0.94 (0.0%), extract_message_metadata: 11 (0.2%), get_uri_detail_list: 0.98 (0.0%), tests_pri_-1000: 4.2 (0.1%), tests_pri_-950: 0.89 (0.0%), tests_pri_-900: 0.74 (0.0%), tests_pri_-400: 16 (0.3%), check_bayes: 15 (0.3%), b_tokenize: 3.4 (0.1%), b_tok_get_all: 6 (0.1%), b_comp_prob: 1.15 (0.0%), b_tok_touch_all: 2.9 (0.1%), b_finish: 0.78 (0.0%), tests_pri_0: 133 (2.5%), check_dkim_signature: 0.48 (0.0%), check_dkim_adsp: 2.8 (0.1%), tests_pri_500: 5127 (96.7%), poll_dns_idle: 5121 (96.6%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH] proc/sysctl: prune stale dentries during unregistering X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Konstantin Khlebnikov writes: > On 10.02.2017 10:47, Al Viro wrote: >> On Fri, Feb 10, 2017 at 10:35:02AM +0300, Konstantin Khlebnikov wrote: >> >>> # time sysctl -a > /dev/null >>> real 1m12.806s >>> user 0m0.016s >>> sys 1m12.400s >>> >>> Currently only memory reclaimer could remove this garbage. >>> But without significant memory pressure this never happens. >>> >>> This patch collects sysctl inodes into list on sysctl table header and >>> prunes all their dentries once that table unregisters. >> >> I'd probably go for hlist, but that's mostly cosmetic difference; how about >> the matching stats *after* that patch? >> > > dcache size doesn't grow endlessly, so stats are fine > > # sysctl fs.dentry-state > fs.dentry-state = 92712 58376 45 0 0 0 > > # time sysctl -a &>/dev/null > > real 0m0.013s > user 0m0.004s > sys 0m0.008s Applied thanks, Eric