All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: airlied@redhat.com, dri-devel@lists.freedesktop.org,
	daniel.vetter@ffwll.ch
Subject: Re: [PATCH 2/3] drm: qxl: Open code probing sequence for qxl
Date: Tue, 17 Jan 2017 11:15:15 -0200	[thread overview]
Message-ID: <874m0xltek.fsf@dilma.collabora.co.uk> (raw)
In-Reply-To: <20170116211615.GJ16017@joana> (Gustavo Padovan's message of "Mon, 16 Jan 2017 19:16:15 -0200")

Gustavo Padovan <gustavo@padovan.org> writes:

> I'm not confortable with exposing minor->type here and making qxl
> the first driver to use it outside of drm core. Don't we have any other
> way. 
>
> I see that inside qxl_debugfs_add_files() we have a check for already
> registered files. Wouldn't that or some modification around work for
> this?

Thanks for your review, Gustavo.

As I mentioned on IRC, I verified the check is not needed at all,
since qxl only implements one minor.  I'll resend without this bit.

-- 
Gabriel Krisman Bertazi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-01-17 13:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-12 16:16 [PATCH 1/3] drm: qxl: Let DRM core handle connector registering Gabriel Krisman Bertazi
2017-01-12 16:16 ` [PATCH 2/3] drm: qxl: Open code probing sequence for qxl Gabriel Krisman Bertazi
2017-01-16 21:16   ` Gustavo Padovan
2017-01-17 13:15     ` Gabriel Krisman Bertazi [this message]
2017-01-12 16:16 ` [PATCH 3/3] drm: qxl: Open code teardown function " Gabriel Krisman Bertazi
2017-01-17 12:41 ` [PATCH 1/3] drm: qxl: Let DRM core handle connector registering Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874m0xltek.fsf@dilma.collabora.co.uk \
    --to=krisman@collabora.co.uk \
    --cc=airlied@redhat.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo@padovan.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.