From: Markus Armbruster <armbru@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 01/14] qapi: add missing 'bus' argument in device_add
Date: Mon, 07 Nov 2016 16:10:34 +0100 [thread overview]
Message-ID: <874m3js4ut.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20161107073033.21025-2-marcandre.lureau@redhat.com> (=?utf-8?Q?=22Marc-Andr=C3=A9?= Lureau"'s message of "Mon, 7 Nov 2016 11:30:20 +0400")
Marc-André Lureau <marcandre.lureau@redhat.com> writes:
> 'device_add' is incomplete for now, but 'bus' is a common argument for
> regarless of the device, and is present in documentation. Add it to the
> device_add schema definition.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> qapi-schema.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index b0b4bf6..4ba5772 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -2317,7 +2317,7 @@
> # Since: 0.13
> ##
> { 'command': 'device_add',
> - 'data': {'driver': 'str', 'id': 'str'},
> + 'data': {'driver': 'str', '*bus': 'str', 'id': 'str'},
> 'gen': false } # so we can get the additional arguments
>
> ##
Makes sense.
@id is actually optional, care to fix that, too?
next prev parent reply other threads:[~2016-11-07 15:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 7:30 [Qemu-devel] [PATCH v3 00/14] qapi doc generation (whole version, squashed) Marc-André Lureau
2016-11-07 7:30 ` [Qemu-devel] [PATCH v3 01/14] qapi: add missing 'bus' argument in device_add Marc-André Lureau
2016-11-07 15:10 ` Markus Armbruster [this message]
2016-11-07 22:55 ` Eric Blake
2016-11-07 7:30 ` [Qemu-devel] [PATCH v3 02/14] qga/schema: fix double-return in doc Marc-André Lureau
2016-11-07 22:59 ` Eric Blake
2016-11-07 7:30 ` [Qemu-devel] [PATCH v3 03/14] qga/schema: improve guest-set-vcpus Returns: section Marc-André Lureau
2016-11-07 15:25 ` Markus Armbruster
2016-11-07 7:30 ` [Qemu-devel] [PATCH v3 04/14] qapi: fix schema symbol sections Marc-André Lureau
2016-11-07 23:07 ` Eric Blake
2016-11-07 7:30 ` [Qemu-devel] [PATCH v3 05/14] qapi: fix missing symbol @prefix Marc-André Lureau
2016-11-07 23:08 ` Eric Blake
2016-11-07 7:30 ` [Qemu-devel] [PATCH v3 06/14] qapi: fix various symbols mismatch in documentation Marc-André Lureau
2016-11-07 15:40 ` Markus Armbruster
2016-11-07 7:30 ` [Qemu-devel] [PATCH v3 07/14] qapi: use one symbol per line Marc-André Lureau
2016-11-07 15:57 ` Markus Armbruster
2016-11-07 7:30 ` [Qemu-devel] [PATCH v3 08/14] qapi: add missing colon-ending for section name Marc-André Lureau
2016-11-07 15:58 ` Markus Armbruster
2016-11-07 7:30 ` [Qemu-devel] [PATCH v3 09/14] qapi: add some sections in docs Marc-André Lureau
2016-11-07 15:59 ` Markus Armbruster
2016-11-07 7:30 ` [Qemu-devel] [PATCH v3 10/14] docs: add master qapi texi files Marc-André Lureau
2016-11-08 14:19 ` Markus Armbruster
2016-11-07 7:30 ` [Qemu-devel] [PATCH v3 11/14] qapi: add qapi2texi script Marc-André Lureau
2016-11-10 16:37 ` Markus Armbruster
2016-11-15 17:17 ` Marc-André Lureau
2016-11-07 7:30 ` [Qemu-devel] [PATCH v3 12/14] texi2pod: learn quotation, deftp and deftypefn Marc-André Lureau
2016-11-07 7:30 ` [Qemu-devel] [PATCH v3 13/14] qmp-commands: (SQUASHED) move doc to schema Marc-André Lureau
2016-11-07 7:30 ` [Qemu-devel] [PATCH v3 14/14] build-sys: add qapi doc generation targets Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m3js4ut.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.