From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:60201 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757389AbcIOOTa (ORCPT ); Thu, 15 Sep 2016 10:19:30 -0400 From: "Valo, Kalle" To: Ben Greear CC: "ath10k@lists.infradead.org" , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH v2 03/21] ath10k: Allow changing ath10k debug mask at runtime. Date: Thu, 15 Sep 2016 14:19:24 +0000 Message-ID: <874m5hb5zn.fsf@kamboji.qca.qualcomm.com> (sfid-20160915_161934_024455_FC296E50) References: <1462986153-16318-1-git-send-email-greearb@candelatech.com> <1462986153-16318-4-git-send-email-greearb@candelatech.com> <871t0mfuej.fsf@kamboji.qca.qualcomm.com> <57D96DB1.5040003@candelatech.com> In-Reply-To: <57D96DB1.5040003@candelatech.com> (Ben Greear's message of "Wed, 14 Sep 2016 08:33:05 -0700") Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Ben Greear writes: > On 09/14/2016 07:06 AM, Valo, Kalle wrote: >> greearb@candelatech.com writes: >> >>> From: Ben Greear >>> >>> Using debugfs. More convenient than module options >>> in some cases. >>> >>> Signed-off-by: Ben Greear >>> --- >>> drivers/net/wireless/ath/ath10k/debug.c | 62 ++++++++++++++++++++++++= +++++++++ >>> 1 file changed, 62 insertions(+) >>> >>> diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wire= less/ath/ath10k/debug.c >>> index e251155..d552a4a 100644 >>> --- a/drivers/net/wireless/ath/ath10k/debug.c >>> +++ b/drivers/net/wireless/ath/ath10k/debug.c >>> @@ -870,6 +870,65 @@ static const struct file_operations fops_reg_addr = =3D { >>> .llseek =3D default_llseek, >>> }; >>> >>> +static ssize_t ath10k_read_debug_level(struct file *file, >>> + char __user *user_buf, >>> + size_t count, loff_t *ppos) >>> +{ >>> + int sz; >>> + const char buf[] =3D >>> + "To change debug level, set value adding up desired flags:\n" >>> + "PCI: 0x1\n" >>> + "WMI: 0x2\n" >>> + "HTC: 0x4\n" >>> + "HTT: 0x8\n" >>> + "MAC: 0x10\n" >>> + "BOOT: 0x20\n" >>> + "PCI-DUMP: 0x40\n" >>> + "HTT-DUMP: 0x80\n" >>> + "MGMT: 0x100\n" >>> + "DATA: 0x200\n" >>> + "BMI: 0x400\n" >>> + "REGULATORY: 0x800\n" >>> + "TESTMODE: 0x1000\n" >>> + "INFO-AS-DBG: 0x40000000\n" >>> + "FW: 0x80000000\n" >>> + "ALL: 0xFFFFFFFF\n"; >>> + char wbuf[sizeof(buf) + 60]; >>> + sz =3D snprintf(wbuf, sizeof(wbuf), "Current debug level: 0x%x\n\n%s"= , >>> + ath10k_debug_mask, buf); >>> + wbuf[sizeof(wbuf) - 1] =3D 0; >>> + >>> + return simple_read_from_buffer(user_buf, count, ppos, wbuf, sz); >>> +} >>> + >>> +/* Set logging level. >>> + */ >>> +static ssize_t ath10k_write_debug_level(struct file *file, >>> + const char __user *user_buf, >>> + size_t count, loff_t *ppos) >>> +{ >>> + struct ath10k *ar =3D file->private_data; >>> + int ret; >>> + unsigned long mask; >>> + >>> + ret =3D kstrtoul_from_user(user_buf, count, 0, &mask); >>> + if (ret) >>> + return ret; >>> + >>> + ath10k_warn(ar, "Setting debug-mask to: 0x%lx old: 0x%x\n", >>> + mask, ath10k_debug_mask); >>> + ath10k_debug_mask =3D mask; >>> + return count; >>> +} >> >> There are already sysfs files for module parameters which seems to work >> just fine for this case: >> >> # echo 0xffffffff > /sys/module/ath10k_core/parameters/debug_mask > > > Ok, but it is still nice to have the printout info of what log levels > means. Otherwise, you have to go look at firmware source to even know ho= w > to enable the proper flags. And as these flags are internal and might ch= ange, > we could change the printout text to match the specific kernel that is ru= nning. The debug log levels are documented in the wiki: https://wireless.wiki.kernel.org/en/users/drivers/ath10k/debug#debug_log_me= ssages And they are not supposed to change, there should be only additions. --=20 Kalle Valo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bkXW2-0001o0-2l for ath10k@lists.infradead.org; Thu, 15 Sep 2016 14:19:54 +0000 From: "Valo, Kalle" Subject: Re: [PATCH v2 03/21] ath10k: Allow changing ath10k debug mask at runtime. Date: Thu, 15 Sep 2016 14:19:24 +0000 Message-ID: <874m5hb5zn.fsf@kamboji.qca.qualcomm.com> References: <1462986153-16318-1-git-send-email-greearb@candelatech.com> <1462986153-16318-4-git-send-email-greearb@candelatech.com> <871t0mfuej.fsf@kamboji.qca.qualcomm.com> <57D96DB1.5040003@candelatech.com> In-Reply-To: <57D96DB1.5040003@candelatech.com> (Ben Greear's message of "Wed, 14 Sep 2016 08:33:05 -0700") Content-Language: en-US Content-ID: <2D812B262C2D1741B36C05C11D2A5A31@qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Ben Greear Cc: "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" Ben Greear writes: > On 09/14/2016 07:06 AM, Valo, Kalle wrote: >> greearb@candelatech.com writes: >> >>> From: Ben Greear >>> >>> Using debugfs. More convenient than module options >>> in some cases. >>> >>> Signed-off-by: Ben Greear >>> --- >>> drivers/net/wireless/ath/ath10k/debug.c | 62 +++++++++++++++++++++++++++++++++ >>> 1 file changed, 62 insertions(+) >>> >>> diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c >>> index e251155..d552a4a 100644 >>> --- a/drivers/net/wireless/ath/ath10k/debug.c >>> +++ b/drivers/net/wireless/ath/ath10k/debug.c >>> @@ -870,6 +870,65 @@ static const struct file_operations fops_reg_addr = { >>> .llseek = default_llseek, >>> }; >>> >>> +static ssize_t ath10k_read_debug_level(struct file *file, >>> + char __user *user_buf, >>> + size_t count, loff_t *ppos) >>> +{ >>> + int sz; >>> + const char buf[] = >>> + "To change debug level, set value adding up desired flags:\n" >>> + "PCI: 0x1\n" >>> + "WMI: 0x2\n" >>> + "HTC: 0x4\n" >>> + "HTT: 0x8\n" >>> + "MAC: 0x10\n" >>> + "BOOT: 0x20\n" >>> + "PCI-DUMP: 0x40\n" >>> + "HTT-DUMP: 0x80\n" >>> + "MGMT: 0x100\n" >>> + "DATA: 0x200\n" >>> + "BMI: 0x400\n" >>> + "REGULATORY: 0x800\n" >>> + "TESTMODE: 0x1000\n" >>> + "INFO-AS-DBG: 0x40000000\n" >>> + "FW: 0x80000000\n" >>> + "ALL: 0xFFFFFFFF\n"; >>> + char wbuf[sizeof(buf) + 60]; >>> + sz = snprintf(wbuf, sizeof(wbuf), "Current debug level: 0x%x\n\n%s", >>> + ath10k_debug_mask, buf); >>> + wbuf[sizeof(wbuf) - 1] = 0; >>> + >>> + return simple_read_from_buffer(user_buf, count, ppos, wbuf, sz); >>> +} >>> + >>> +/* Set logging level. >>> + */ >>> +static ssize_t ath10k_write_debug_level(struct file *file, >>> + const char __user *user_buf, >>> + size_t count, loff_t *ppos) >>> +{ >>> + struct ath10k *ar = file->private_data; >>> + int ret; >>> + unsigned long mask; >>> + >>> + ret = kstrtoul_from_user(user_buf, count, 0, &mask); >>> + if (ret) >>> + return ret; >>> + >>> + ath10k_warn(ar, "Setting debug-mask to: 0x%lx old: 0x%x\n", >>> + mask, ath10k_debug_mask); >>> + ath10k_debug_mask = mask; >>> + return count; >>> +} >> >> There are already sysfs files for module parameters which seems to work >> just fine for this case: >> >> # echo 0xffffffff > /sys/module/ath10k_core/parameters/debug_mask > > > Ok, but it is still nice to have the printout info of what log levels > means. Otherwise, you have to go look at firmware source to even know how > to enable the proper flags. And as these flags are internal and might change, > we could change the printout text to match the specific kernel that is running. The debug log levels are documented in the wiki: https://wireless.wiki.kernel.org/en/users/drivers/ath10k/debug#debug_log_messages And they are not supposed to change, there should be only additions. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k