From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDa6x-0002u2-78 for qemu-devel@nongnu.org; Thu, 16 Jun 2016 12:25:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDa6r-0003Hw-5U for qemu-devel@nongnu.org; Thu, 16 Jun 2016 12:25:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57194) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDa6q-0003Hf-VP for qemu-devel@nongnu.org; Thu, 16 Jun 2016 12:25:37 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5CEBCC04B304 for ; Thu, 16 Jun 2016 16:25:36 +0000 (UTC) From: Markus Armbruster References: <1465526889-8339-1-git-send-email-eblake@redhat.com> <1465526889-8339-4-git-send-email-eblake@redhat.com> <87porhw3d5.fsf@dusky.pond.sub.org> Date: Thu, 16 Jun 2016 18:25:34 +0200 In-Reply-To: <87porhw3d5.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Thu, 16 Jun 2016 17:38:30 +0200") Message-ID: <874m8tumm9.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 3/4] qobject: Parse non-finite numbers, as an extension List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Luiz Capitulino I think this commit mixes up parsing of non-finite numbers, which we may or may not want, with general test improvements, which we'll want regardless. Please split the patch. On the parsing of non-finite numbers: the code looks good to me, but as long as we're not ready to extend QMP to include non-finite numbers both ways, I doubt we need to parse them.