From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753155AbcEMCE4 (ORCPT ); Thu, 12 May 2016 22:04:56 -0400 Received: from relmlor4.renesas.com ([210.160.252.174]:37659 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751482AbcEMCEx (ORCPT ); Thu, 12 May 2016 22:04:53 -0400 X-IronPort-AV: E=Sophos;i="5.22,559,1449500400"; d="scan'";a="210745516" Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=renesas.com; Message-ID: <874ma2lnvw.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: "Zhang, Rui" CC: "edubezval@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "yoshihiro.shimoda.uh@renesas.com" , "cm-hiep@jinso.co.jp" Subject: Re: lm-senser can't detect thermal on thermal_zone In-Reply-To: <1463100287.15071.8.camel@rzhang1-mobl4> References: <87posrn1oj.wl%kuninori.morimoto.gx@renesas.com> <1463100287.15071.8.camel@rzhang1-mobl4> User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Date: Fri, 13 May 2016 02:04:47 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: OS1PR01CA0049.jpnprd01.prod.outlook.com (10.164.162.31) To PS1PR06MB1707.apcprd06.prod.outlook.com (10.167.53.17) X-MS-Office365-Filtering-Correlation-Id: 9011d1c0-de66-41f9-880e-08d37ad2f622 X-Microsoft-Exchange-Diagnostics: 1;PS1PR06MB1707;2:dHlAoVZw9EgOuOVwth+9o5uHeMDzebCBn7LGQuh2ibNTKK2Bv4AJh0aYLjByArggF8almCkc4DkSY+jbrU6njqSWSgHmGG69VvDmTObN+kXjBZxI5P+mTnlmj2bAxncC+eT7uQRSezJfbm/tcHNpsLKuLtpJXh0oLNmwk4ec759UGd9B1xDUvsmmyCiRMjb6;3:bMghf4ky6h6u6nrQ2EHshCLoyKXXbafil6zfYPjDvgJG5LTMlT7rLUBYMuXHKUILHcdZw70FokPen06FGFOx3NE2cWn/fTuYPffsqK766O6WCqM9MolsmmZMBsDg9Prc X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:PS1PR06MB1707; X-Microsoft-Exchange-Diagnostics: 1;PS1PR06MB1707;25:vwuXzNOk/phgYk01PY2YGDwRzV9ueXkF6WDmsg/JUyBQuQCLCFEvTNMPQPJgJK8LsnqjM8l0gH/XkBUH2QR+dTsfsEnrQ5r5YBgoqaoFX0PAuSEQCJ7U6drB8P02cIioWNhgXNZZLk11QMbNk+clJqSbimoPjwPezqYgb3YMOESEjcCOMmnnkCToi9XmYkzhbbrdr3pAQtu46cVX/ztB3UuPw1+XMij4kYeS5tPlhbtKKUKzS2vtLh7/i6pkiz+98ZtNCaczhqnZPzrELBumxX44kay2tyBjvZAcBqXklVmtzOdJbjQTTdpfAHh9hA/f4muajiHsskcv/t63j9cQ1GNlakVldWYZqsEs4RYZsqJM/xOrd344ZJdhnr/cfsWEvZuogdcyIa1jI6v6qxBdqs22tXbobqEz6LRMs42a/EQSMO0AcdGDFsRALTBRozr+kRHNBps8KquFptDPkoh3Z+sZhfsNMo6yKJ63qY2WcOAZM0MhZOnFE6nNseymslDtJK0sQ7gAgrbDf+5sp4Oh1P+kXfy5HtSzIK09/ykT5C9sG0nIWRRf6IR2zrQVzGDeM95a7Fig0jAAPsDIaYTsec2wx6H9/Z13tLlWxzL1MreR1BcwBNrXBdgG1yYwxuZS7EJ/yLfsJxAFqEpCOKQ6tk2ASYsyis0KoTwwJU8/0D/gRz8OOLT+qm/QPID5NaX9CWNk7bD2zmLBo/XrVETmng== X-Microsoft-Exchange-Diagnostics: 1;PS1PR06MB1707;20:yGwVdoQ2z9NiLraMyx7ZZ0k7pe44hFT0cVxuRuU8YGyRXq2uqS69bicnW0HABMJGMVZaVZfxAMI8zSoB8FZKc3McuiqLKcI8eULvTsNHa+j8qpfVZBwA18Ayzc/RpALiBSG5nfb+o7Z47Uv+5RoQnqF3oUDDM74HT+M4XsYn0H21136BFzC3I04yT93+OShzDZU2VK/Nk9QbAwBolgh5ctAhq4D3uXwMCa5l+CrygICFd91uL6AGFp/a51fTEdRv4FjqxOgI9MV7D3sJRSdMbDvqOJowzrJJxS5PeMGW9eVJvDTKF4OCv/U5k7c8lWb/a741CaBrtehpE/cEsv3gTJvPuO4VeyOZD5gPI23X+B6AbBO1JSAw3IC9jS0Kljzqf6oJjw2t/niCnloKeLYh53c8nq0+we/pfC6LIXiLaH3aB54bjjdTEd9Y7ghCagpLphwDEzm3gcSdWn9Xy8AL0BM6A1Izs6rlV5PEbNyh8rCRJl79kZaqGQ6yWi0c3vi7;4:FHZ48ahd9oEVfRbF19QtoXjknAAwhAu2uWq3w4Ktf2CinNgO45gd36oYFGTiB2qoxygmY3fn/KwPr5puTOEO4Vdiv8a+y5EtdwpH4ya69KiwN7v5nLjHY0FHTtIFG+h7UyYX9cCAxRbiVdzviehiKVIBLsYlZoMn8dRZxWXeJlqf9N7bONuqBsRyGV3N75adqbACtfAR3XnBdx4pFnQnHk0FZrXa+A5ivGB/67PtZ9ao9EzV3HBV50I8QSdc7tEhiQJVkG5z+UsMqLHXHvF5A/n3J1bJCmzJAaqsyynv7irw1t4peuDH1fq1gE83HvE1kctBpR/sG4+ZMwAvYvAgusNvzgbn6kEDy7QfCNXTUntLZBQijp8GZoQEpSLrRATB1+tWAe4mcips4pxjsXvKHQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:PS1PR06MB1707;BCL:0;PCL:0;RULEID:;SRVR:PS1PR06MB1707; X-Forefront-PRVS: 0941B96580 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(50986999)(33646002)(54356999)(76176999)(77096005)(2950100001)(8676002)(5008740100001)(46406003)(47776003)(189998001)(83506001)(2906002)(81166006)(92566002)(4326007)(586003)(42186005)(86362001)(50466002)(23726003)(3846002)(5004730100002)(345774005)(6116002)(110136002)(4001350100001)(36756003)(53416004)(16060500001);DIR:OUT;SFP:1102;SCL:1;SRVR:PS1PR06MB1707;H:morimoto-PC.renesas.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;PS1PR06MB1707;23:08dpjnp6oRU1BDpueHZnFUAmH4e4WodDiFjY3ZBFl7ZjLgb8Uz3puEupEcyqhQflzRnKBMwj0hKXjqs6x9micSJzn2m/B0Zk6pRa3GbpR5x8kDRBd//1C/GZ54Rbe3buLZsjkLU8pcwSgCrjIs6cSSxFkz7L85b6JteWFutjG993z/dTP8f6A2KyjPFL5mdRLd9ssO70MlyTRf64VKMrvjbRfzAZ47qyXv68b0YRDNSVe1La0NLSai5il3r/sYvNj1+yZSix/IK+DHvMx/U6AJjyq/XovQfddqaY59XY9NyJQUTuJpX3WJ2BKRf7xvRaAOFZFqf6GwlTotq7onXkYC8UpiSQUsVjXLRVuDW6jIbvgxCE8wQgeJtO7JKwVGJ7QRmfq3bv0YMfvxuGQilv1YQ9eCn17D4aZl9b3tjcpl8fmU6YV93uFDqR+zLWT5yxcpgQRe5BMNDyHxI4FLlFw27yEdJp+h3NC24JkTkQxvvB+/1tnMEyE+Fga94SJZw+ymKqs/NcZ0ridLLbegzmgmlu7eJANLby4Q7ceD4G74iFu85cVRtnoJpUhuZY2A6dAs6wW/hJxuT1RmfEK05h1Ac48oLpIXpY68vUWh+ntU5qs01s213PbHMiX1BgXvfRfsHA1VGHPJ4qmLiobtK9PhMBCxrBBEYaGJQe/B2H5Tc9+fYtoS4chip/bIlTHK/KYHBLK6cVIMu69nzhhZtfRpq5V3Brul7y/g0QkCJKnrunP90OaISvBrDvs8U6c3T95P3PKVAS9urjT4VUSSKLXIts6ypFpN6NfTiRnQM3niKNrR4Lq5VuNNYGW4peeztUrlKyPImBxWTJva6CMd0tAHS7yUkBgjDNucBw3K7PbT7UJqhd8Bbf+iHXAxYmPIVu X-Microsoft-Exchange-Diagnostics: 1;PS1PR06MB1707;5:pmcvHGGXF0kd8k4OZYP7erC/PtXBSC/dqgu5IwAh2Xq+EnANevUhE1F3cAtr5nZQ/RghxRrW04sVhFSnvWYJNQBN8f61Wht/p0AtZBYLjLD0cFZbkQx9Jajq95YgJs9kAb+lDv03CES7GB5CNts2wg==;24:ML6leWy9Bx783fC9s+J46Y4pK7gpkP+AvgbPH8FkoAqhcg8ZPZw5os8DVEd3zn/0Kie8aaEN6ll1xLEy4yQcZMs4qKqrRyF8MaOsCGudPSE=;7:QDbrPYoxm+zW61drL6uqCr9yFuL8SlEVkbLftqf++4qzstvfFZO66PYtz9uVIr0trs5hpeL9U7Gz20uLPUn2QCI8jYAV+bhzFYfGKLAqJBTFAgqWRRk07h1jmutRgxNsO+klMMXY7mSwt+c2SwjCbZZrVQxcC2WoYat9jLLXs9iyJ2JkNt31gXjONGZPCatA;20:MI7mPQLTzGdngyII1vHcxMo0DDRG9vjXD0q1/276wglhPwjt2jYQIdc+21eiwsmZ+87g73Rb4h97EHTmgkW2ISvWh2+OZa2HMrZs4sogInlrYt4WWPqLYQZE9qHucQHCLuPToTn6EbZz45OX1F4YHaUNy2KwZYowLCsIseyAkks= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2016 02:04:47.1956 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR06MB1707 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Zhang Thank you for your help > > non thermal-zon > > sensor command: OK > > read from /sys/class/thermal/thermal_zone0 : OK > > > > thermal-zon > > sensor command: NG > > read from /sys/class/thermal/thermal_zone0 : OK > > config THERMAL_HWMON > bool > prompt "Expose thermal sensors as hwmon device" > depends on HWMON=y || HWMON=THERMAL > default y > > please check if the thermal subsystem is built in, while hwmon subsystem > is built as module. > you should either set CONFIG_HWMON=y, or set both CONFIG_HWMON and > CONFIG_THERMAL as module. Thanks. but it seems our system has it. I noticed that thermal_zone case uses of_parse_thermal_zones() and it has this. /* No hwmon because there might be hwmon drivers registering */ tzp->no_hwmon = true; and on thermal_zone_device_register() check this for hwmon struct thermal_zone_device *thermal_zone_device_register(xxxx) { ... if (!tz->tzp || !tz->tzp->no_hwmon) { result = thermal_add_hwmon_sysfs(tz); ... } ... } Does this mean "thermal_zone doesn't use lm-senser" ? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relmlor4.renesas.com ([210.160.252.174]:37659 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751482AbcEMCEx (ORCPT ); Thu, 12 May 2016 22:04:53 -0400 Message-ID: <874ma2lnvw.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: "Zhang, Rui" CC: "edubezval@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "yoshihiro.shimoda.uh@renesas.com" , "cm-hiep@jinso.co.jp" Subject: Re: lm-senser can't detect thermal on thermal_zone In-Reply-To: <1463100287.15071.8.camel@rzhang1-mobl4> References: <87posrn1oj.wl%kuninori.morimoto.gx@renesas.com> <1463100287.15071.8.camel@rzhang1-mobl4> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Date: Fri, 13 May 2016 02:04:47 +0000 Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Zhang Thank you for your help > > non thermal-zon > > sensor command: OK > > read from /sys/class/thermal/thermal_zone0 : OK > > > > thermal-zon > > sensor command: NG > > read from /sys/class/thermal/thermal_zone0 : OK > > config THERMAL_HWMON > bool > prompt "Expose thermal sensors as hwmon device" > depends on HWMON=y || HWMON=THERMAL > default y > > please check if the thermal subsystem is built in, while hwmon subsystem > is built as module. > you should either set CONFIG_HWMON=y, or set both CONFIG_HWMON and > CONFIG_THERMAL as module. Thanks. but it seems our system has it. I noticed that thermal_zone case uses of_parse_thermal_zones() and it has this. /* No hwmon because there might be hwmon drivers registering */ tzp->no_hwmon = true; and on thermal_zone_device_register() check this for hwmon struct thermal_zone_device *thermal_zone_device_register(xxxx) { ... if (!tz->tzp || !tz->tzp->no_hwmon) { result = thermal_add_hwmon_sysfs(tz); ... } ... } Does this mean "thermal_zone doesn't use lm-senser" ?