From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1atBoj-0007jh-Gm for qemu-devel@nongnu.org; Thu, 21 Apr 2016 06:26:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1atBog-0000ll-Ah for qemu-devel@nongnu.org; Thu, 21 Apr 2016 06:26:37 -0400 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:36944) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1atBof-0000lf-QW for qemu-devel@nongnu.org; Thu, 21 Apr 2016 06:26:34 -0400 Received: by mail-wm0-x234.google.com with SMTP id n3so125236770wmn.0 for ; Thu, 21 Apr 2016 03:26:33 -0700 (PDT) References: <1460147350-7601-1-git-send-email-pbonzini@redhat.com> <1460147350-7601-5-git-send-email-pbonzini@redhat.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1460147350-7601-5-git-send-email-pbonzini@redhat.com> Date: Thu, 21 Apr 2016 11:26:31 +0100 Message-ID: <874mavuujs.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 04/50] cpu: make cpu-qom.h only include-able from cpu.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Paolo Bonzini writes: > Make cpu-qom.h so that it is only included from cpu.h. Then there > is no need for it to include cpu.h again. > > Later we will make cpu-qom.h target independent and we will _want_ > to include it from elsewhere, but for now reduce the number of cases > to handle. > > Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée > --- > target-alpha/cpu-qom.h | 1 - > target-arm/psci.c | 1 - > target-i386/cpu-qom.h | 1 - > target-lm32/cpu-qom.h | 1 - > target-ppc/cpu-qom.h | 1 - > target-s390x/cpu-qom.h | 1 - > target-sparc/cpu-qom.h | 1 - > target-unicore32/cpu-qom.h | 1 - > target-xtensa/cpu-qom.h | 1 - > 9 files changed, 9 deletions(-) > > diff --git a/target-alpha/cpu-qom.h b/target-alpha/cpu-qom.h > index b01c6c8..cf5264a 100644 > --- a/target-alpha/cpu-qom.h > +++ b/target-alpha/cpu-qom.h > @@ -21,7 +21,6 @@ > #define QEMU_ALPHA_CPU_QOM_H > > #include "qom/cpu.h" > -#include "cpu.h" > > #define TYPE_ALPHA_CPU "alpha-cpu" > > diff --git a/target-arm/psci.c b/target-arm/psci.c > index c55487f..2b624b9 100644 > --- a/target-arm/psci.c > +++ b/target-arm/psci.c > @@ -17,7 +17,6 @@ > */ > #include "qemu/osdep.h" > #include > -#include > #include > #include > #include > diff --git a/target-i386/cpu-qom.h b/target-i386/cpu-qom.h > index cb75017..2ca7b9e 100644 > --- a/target-i386/cpu-qom.h > +++ b/target-i386/cpu-qom.h > @@ -21,7 +21,6 @@ > #define QEMU_I386_CPU_QOM_H > > #include "qom/cpu.h" > -#include "cpu.h" > #include "qemu/notify.h" > > #ifdef TARGET_X86_64 > diff --git a/target-lm32/cpu-qom.h b/target-lm32/cpu-qom.h > index 77bc7b2..54989e4 100644 > --- a/target-lm32/cpu-qom.h > +++ b/target-lm32/cpu-qom.h > @@ -21,7 +21,6 @@ > #define QEMU_LM32_CPU_QOM_H > > #include "qom/cpu.h" > -#include "cpu.h" > > #define TYPE_LM32_CPU "lm32-cpu" > > diff --git a/target-ppc/cpu-qom.h b/target-ppc/cpu-qom.h > index 7d5e2b3..eb822a3 100644 > --- a/target-ppc/cpu-qom.h > +++ b/target-ppc/cpu-qom.h > @@ -21,7 +21,6 @@ > #define QEMU_PPC_CPU_QOM_H > > #include "qom/cpu.h" > -#include "cpu.h" > > #ifdef TARGET_PPC64 > #define TYPE_POWERPC_CPU "powerpc64-cpu" > diff --git a/target-s390x/cpu-qom.h b/target-s390x/cpu-qom.h > index 1c90933..681e370 100644 > --- a/target-s390x/cpu-qom.h > +++ b/target-s390x/cpu-qom.h > @@ -21,7 +21,6 @@ > #define QEMU_S390_CPU_QOM_H > > #include "qom/cpu.h" > -#include "cpu.h" > > #define TYPE_S390_CPU "s390-cpu" > > diff --git a/target-sparc/cpu-qom.h b/target-sparc/cpu-qom.h > index 5096b10..174dfd3 100644 > --- a/target-sparc/cpu-qom.h > +++ b/target-sparc/cpu-qom.h > @@ -21,7 +21,6 @@ > #define QEMU_SPARC_CPU_QOM_H > > #include "qom/cpu.h" > -#include "cpu.h" > > #ifdef TARGET_SPARC64 > #define TYPE_SPARC_CPU "sparc64-cpu" > diff --git a/target-unicore32/cpu-qom.h b/target-unicore32/cpu-qom.h > index ea65b83..e554f1f 100644 > --- a/target-unicore32/cpu-qom.h > +++ b/target-unicore32/cpu-qom.h > @@ -12,7 +12,6 @@ > #define QEMU_UC32_CPU_QOM_H > > #include "qom/cpu.h" > -#include "cpu.h" > > #define TYPE_UNICORE32_CPU "unicore32-cpu" > > diff --git a/target-xtensa/cpu-qom.h b/target-xtensa/cpu-qom.h > index 2258224..f5d9b9f 100644 > --- a/target-xtensa/cpu-qom.h > +++ b/target-xtensa/cpu-qom.h > @@ -30,7 +30,6 @@ > #define QEMU_XTENSA_CPU_QOM_H > > #include "qom/cpu.h" > -#include "cpu.h" > > #define TYPE_XTENSA_CPU "xtensa-cpu" -- Alex Bennée