All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/8] ath10k: remove deprecated firmware API 1 support
Date: Thu, 14 Apr 2016 13:11:12 +0000	[thread overview]
Message-ID: <874mb4s5cg.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20160406144445.28399.74306.stgit@potku.adurom.net> (Kalle Valo's message of "Wed, 6 Apr 2016 17:44:45 +0300")

Kalle Valo <kvalo@qca.qualcomm.com> writes:

> This has ben deprecated years ago, I haven't heard anyone using it since and
> most likely it won't even work anymore. So just remove all of it.
>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

[...]

> --- a/drivers/net/wireless/ath/ath10k/hw.h
> +++ b/drivers/net/wireless/ath/ath10k/hw.h
> @@ -35,8 +35,6 @@
>  #define QCA988X_HW_2_0_VERSION		0x4100016c
>  #define QCA988X_HW_2_0_CHIP_ID_REV	0x2
>  #define QCA988X_HW_2_0_FW_DIR		ATH10K_FW_DIR "/QCA988X/hw2.0"
> -#define QCA988X_HW_2_0_FW_FILE		"firmware.bin"
> -#define QCA988X_HW_2_0_OTP_FILE		"otp.bin"
>  #define QCA988X_HW_2_0_BOARD_DATA_FILE	"board.bin"
>  #define QCA988X_HW_2_0_PATCH_LOAD_ADDR	0x1234

I missed to remove all the other references to "firmware.bin" or
"otp.bin", for example:

#define QCA6174_HW_2_1_FW_FILE		"firmware.bin"
#define QCA6174_HW_2_1_OTP_FILE		"otp.bin"

Will send v2.

-- 
Kalle Valo

WARNING: multiple messages have this Message-ID (diff)
From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/8] ath10k: remove deprecated firmware API 1 support
Date: Thu, 14 Apr 2016 13:11:12 +0000	[thread overview]
Message-ID: <874mb4s5cg.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20160406144445.28399.74306.stgit@potku.adurom.net> (Kalle Valo's message of "Wed, 6 Apr 2016 17:44:45 +0300")

Kalle Valo <kvalo@qca.qualcomm.com> writes:

> This has ben deprecated years ago, I haven't heard anyone using it since and
> most likely it won't even work anymore. So just remove all of it.
>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

[...]

> --- a/drivers/net/wireless/ath/ath10k/hw.h
> +++ b/drivers/net/wireless/ath/ath10k/hw.h
> @@ -35,8 +35,6 @@
>  #define QCA988X_HW_2_0_VERSION		0x4100016c
>  #define QCA988X_HW_2_0_CHIP_ID_REV	0x2
>  #define QCA988X_HW_2_0_FW_DIR		ATH10K_FW_DIR "/QCA988X/hw2.0"
> -#define QCA988X_HW_2_0_FW_FILE		"firmware.bin"
> -#define QCA988X_HW_2_0_OTP_FILE		"otp.bin"
>  #define QCA988X_HW_2_0_BOARD_DATA_FILE	"board.bin"
>  #define QCA988X_HW_2_0_PATCH_LOAD_ADDR	0x1234

I missed to remove all the other references to "firmware.bin" or
"otp.bin", for example:

#define QCA6174_HW_2_1_FW_FILE		"firmware.bin"
#define QCA6174_HW_2_1_OTP_FILE		"otp.bin"

Will send v2.

-- 
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2016-04-14 13:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06 14:44 [PATCH 0/8] ath10k: refactor firmware components Kalle Valo
2016-04-06 14:44 ` Kalle Valo
2016-04-06 14:44 ` [PATCH 1/8] ath10k: remove deprecated firmware API 1 support Kalle Valo
2016-04-06 14:44   ` Kalle Valo
2016-04-14 13:11   ` Valo, Kalle [this message]
2016-04-14 13:11     ` Valo, Kalle
2016-04-06 14:44 ` [PATCH 2/8] ath10k: refactor firmware images to struct ath10k_fw_components Kalle Valo
2016-04-06 14:44   ` Kalle Valo
2016-04-06 14:45 ` [PATCH 3/8] ath10k: move fw_version inside struct ath10k_fw_file Kalle Valo
2016-04-06 14:45   ` Kalle Valo
2016-04-06 14:45 ` [PATCH 4/8] ath10k: move fw_features to " Kalle Valo
2016-04-06 14:45   ` Kalle Valo
2016-04-06 14:45 ` [PATCH 5/8] ath10k: move wmi_op_version " Kalle Valo
2016-04-06 14:45   ` Kalle Valo
2016-04-06 14:45 ` [PATCH 6/8] ath10k: move htt_op_version " Kalle Valo
2016-04-06 14:45   ` Kalle Valo
2016-04-06 14:46 ` [PATCH 7/8] ath10k: switch testmode to use ath10k_core_fetch_firmware_api_n() Kalle Valo
2016-04-06 14:46   ` Kalle Valo
2016-04-06 14:46 ` [PATCH 8/8] ath10k: remove enum ath10k_swap_code_seg_bin_type Kalle Valo
2016-04-06 14:46   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874mb4s5cg.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.