All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stewart Smith <stewart@linux.vnet.ibm.com>
To: Vishwanatha Subbanna <vishwanath@in.ibm.com>
Cc: OpenBMC Patches <openbmc-patches@stwcx.xyz>, openbmc@lists.ozlabs.org
Subject: Re: [PATCH phosphor-host-ipmid v3 1/6] Support host reboot
Date: Mon, 21 Dec 2015 14:10:18 +1100	[thread overview]
Message-ID: <874mfcmr8l.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <201512170646.tBH6kaOR019514@d28av01.in.ibm.com>

Vishwanatha Subbanna <vishwanath@in.ibm.com> writes:

> CMD_POWER_OFF is for soft-off.
>
> CMD_HARD_RESET is for hard reset.

Why not spell that out in the defines?

CMD_SOFT_POWER_OFF
CMD_HARD_RESET

which would imply the existence of:
CMD_HARD_POWER_OFF
CMD_SOFT_RESET

Having hard/soft in define means it's obvious to anyone reading the code
as to what it's meant to be doing.

  parent reply	other threads:[~2015-12-21  3:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 12:50 [PATCH phosphor-host-ipmid v3 0/6] IPMID boot options changes OpenBMC Patches
2015-12-16 12:50 ` [PATCH phosphor-host-ipmid v3 1/6] Support host reboot OpenBMC Patches
2015-12-16 21:27   ` Stewart Smith
2015-12-17  6:46     ` Vishwanatha Subbanna
     [not found]     ` <201512170646.tBH6kaOR019514@d28av01.in.ibm.com>
2015-12-21  3:10       ` Stewart Smith [this message]
2015-12-16 12:50 ` [PATCH phosphor-host-ipmid v3 2/6] Add get/set ipmid command support with correct DBUS property handling OpenBMC Patches
2015-12-16 20:48   ` Benjamin Herrenschmidt
2015-12-16 21:44   ` Stewart Smith
2015-12-17  4:01     ` Chris Austen
     [not found]     ` <OF6CA268B3.D580B2FE-ON00257F1E.0016143E-1450324869873@LocalDomain>
2015-12-17  5:31       ` Peng Fei BG Gou
2015-12-21  3:14         ` Stewart Smith
2015-12-16 12:50 ` [PATCH phosphor-host-ipmid v3 3/6] Revert "Add get/set ipmid command support with correct DBUS property handling." OpenBMC Patches
2015-12-16 12:50 ` [PATCH phosphor-host-ipmid v3 4/6] Redo: Add get/set ipmid boot option command support with correct DBUS property handling OpenBMC Patches
2015-12-16 12:50 ` [PATCH phosphor-host-ipmid v3 5/6] Cleanup codes for ipmid boot option changes OpenBMC Patches
2015-12-16 12:50 ` [PATCH phosphor-host-ipmid v3 6/6] Get service name via object mapper OpenBMC Patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874mfcmr8l.fsf@linux.vnet.ibm.com \
    --to=stewart@linux.vnet.ibm.com \
    --cc=openbmc-patches@stwcx.xyz \
    --cc=openbmc@lists.ozlabs.org \
    --cc=vishwanath@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.