From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753228AbbKPRkm (ORCPT ); Mon, 16 Nov 2015 12:40:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50742 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753155AbbKPRkk (ORCPT ); Mon, 16 Nov 2015 12:40:40 -0500 From: Vitaly Kuznetsov To: Dan Carpenter Cc: devel@linuxdriverproject.org, Haiyang Zhang , Olaf Hering , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] Drivers: hv: utils: fix memory leak on on_msg() failure References: <1447327936-26035-1-git-send-email-vkuznets@redhat.com> <1447327936-26035-2-git-send-email-vkuznets@redhat.com> <20151116155407.GK18797@mwanda> Date: Mon, 16 Nov 2015 18:40:36 +0100 In-Reply-To: <20151116155407.GK18797@mwanda> (Dan Carpenter's message of "Mon, 16 Nov 2015 18:54:07 +0300") Message-ID: <874mglx2p7.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dan Carpenter writes: > On Thu, Nov 12, 2015 at 12:32:13PM +0100, Vitaly Kuznetsov wrote: >> @@ -85,10 +86,10 @@ static ssize_t hvt_op_write(struct file *file, const char __user *buf, >> return PTR_ERR(inmsg); >> >> if (hvt->on_msg(inmsg, count)) >> - return -EFAULT; >> + ret = -EFAULT; > > You fix this leak and then re-introduce it again directly in patch > 3/4. Such a shame ... Thanks for noticing! > Also it might be nice to preserve the error code. > > ret = hvt->on_msg(inmsg, count); > > kfree(inmsg); > > return ret ? ret : count; It seems on_msg() hooks can only return -EINVAL now but why not ... let's do it in v2. -- Vitaly