From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zws3Z-0002fo-7z for qemu-devel@nongnu.org; Thu, 12 Nov 2015 08:36:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zws3W-00021E-2b for qemu-devel@nongnu.org; Thu, 12 Nov 2015 08:36:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zws3V-00021A-Qs for qemu-devel@nongnu.org; Thu, 12 Nov 2015 08:36:49 -0500 From: Markus Armbruster References: <1447165546-27784-1-git-send-email-quintela@redhat.com> <1447165546-27784-43-git-send-email-quintela@redhat.com> <20151112120443.GE2754@work-vm> Date: Thu, 12 Nov 2015 14:36:46 +0100 In-Reply-To: (Peter Maydell's message of "Thu, 12 Nov 2015 12:15:36 +0000") Message-ID: <874mgrmj9t.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PULL 42/57] Page request: Consume pages off the post-copy queue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Amit Shah , Juan Quintela , "Dr. David Alan Gilbert" , QEMU Developers Peter Maydell writes: > On 12 November 2015 at 12:04, Dr. David Alan Gilbert > wrote: >> * Peter Maydell (peter.maydell@linaro.org) wrote: >>> On 10 November 2015 at 14:25, Juan Quintela wrote: >>> > From: "Dr. David Alan Gilbert" >>> > >>> > When transmitting RAM pages, consume pages that have been queued by >>> > MIG_RPCOMM_REQPAGE commands and send them ahead of normal page scanning. >>> > >>> > Note: >>> > a) After a queued page the linear walk carries on from after the >>> > unqueued page; there is a reasonable chance that the destination >>> > was about to ask for other closeby pages anyway. >>> > >>> > b) We have to be careful of any assumptions that the page walking >>> > code makes, in particular it does some short cuts on its first linear >>> > walk that break as soon as we do a queued page. >>> > >>> > c) We have to be careful to not break up host-page size chunks, since >>> > this makes it harder to place the pages on the destination. >>> > >>> > Signed-off-by: Dr. David Alan Gilbert >>> > Reviewed-by: Juan Quintela >>> > Signed-off-by: Juan Quintela >>> >>> I've just discovered that this is causing 'make check' failures on >>> my OSX host (unfortunately something in my setup is causing >>> 'make check' failures to not always cause a build failure, so I >>> didn't notice earlier): >> >> It's only failing on OSX? Every time or only sometimes? > > Only OSX, and always. I think OSX is pickier about mutexes really > needing to be initialized before use. > >> If you can find a way to get a backtrace off that qemu_mutex_lock case >> that would be great; I'd assume the later errors are the fall out from that. > > I'll have a look after lunch, but it's usually painful to get a > backtrace out of this kind of qtest, because it's clearly starting > a whole pile of QEMUs and there's no way I know of to say "only > run a few of these tests, not the whole huge pile". Not sure this helps, but here goes anyway: run the make with V=1, fish out the gtester line, add -p /name/of/the/test. Here's an example from my shell history: $ MALLOC_PERTURB_=${MALLOC_PERTURB_:-$((RANDOM % 255 + 1))} gtester -k --verbose -m=quick -p /dicts/large_dict tests/check-qjson