From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 2/5] drm/i915/bdw: WaDisableFenceDestinationToSLM Date: Thu, 25 Sep 2014 15:37:37 +0300 Message-ID: <874mvvnaem.fsf@gaia.fi.intel.com> References: <1411172190-1642-1-git-send-email-rodrigo.vivi@intel.com> <1411172190-1642-2-git-send-email-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 718176E6DF for ; Thu, 25 Sep 2014 05:37:41 -0700 (PDT) In-Reply-To: <1411172190-1642-2-git-send-email-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org Rodrigo Vivi writes: > This WA affect BDW GT3 E and F steppings. > > Signed-off-by: Rodrigo Vivi Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/i915_reg.h | 1 + > drivers/gpu/drm/i915/intel_ringbuffer.c | 6 +++++- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index ad8179b..124ea60 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -4836,6 +4836,7 @@ enum punit_power_well { > /* GEN8 chicken */ > #define HDC_CHICKEN0 0x7300 > #define HDC_FORCE_NON_COHERENT (1<<4) > +#define HDC_FENCE_DEST_SLM_DISABLE (1<<14) > > /* WaCatErrorRejectionIssue */ > #define GEN7_SQ_CHICKEN_MBCUNIT_CONFIG 0x9030 > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c > index 681ea86..7c3d17a 100644 > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c > @@ -740,8 +740,12 @@ static int bdw_init_workarounds(struct intel_engine_cs *ring) > * workaround for for a possible hang in the unlikely event a TLB > * invalidation occurs during a PSD flush. > */ > + /* WaDisableFenceDestinationToSLM:bdw (GT3 pre-production E/F) */ > intel_ring_emit_wa(ring, HDC_CHICKEN0, > - _MASKED_BIT_ENABLE(HDC_FORCE_NON_COHERENT)); > + _MASKED_BIT_ENABLE(HDC_FORCE_NON_COHERENT | > + (IS_BDW_GT3(dev) ? > + HDC_FENCE_DEST_SLM_DISABLE : 0) > + )); > > /* Wa4x4STCOptimizationDisable:bdw */ > intel_ring_emit_wa(ring, CACHE_MODE_1, > -- > 1.9.3 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx