From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38259)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WzlaY-0004M9-RI
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 07:42:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WzlaT-00022J-Up
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 07:42:06 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <5399DBDD.3050101@suse.de> (Alexander Graf's message of "Thu, 12
	Jun 2014 18:57:01 +0200")
References: <1401442460-32648-1-git-send-email-aik@ozlabs.ru>
	<1401442460-32648-9-git-send-email-aik@ozlabs.ru>
	<538DCB4C.4040905@ozlabs.ru> <5393A77C.80202@ozlabs.ru>
	<5399C112.2090205@ozlabs.ru> <5399DBDD.3050101@suse.de>
Date: Wed, 25 Jun 2014 13:41:45 +0200
Message-ID: <874mz98bd2.fsf@troll.troll>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v3 8/9] vmstate: Add preallocation for
	migrating arrays (VMS_ALLOC flag)
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, Peter Maydell <peter.maydell@linaro.org>, qemu-ppc@nongnu.org, qemu-devel@nongnu.org

Alexander Graf <agraf@suse.de> wrote:
> On 06/12/2014 05:02 PM, Alexey Kardashevskiy wrote:
>> On 06/08/2014 09:59 AM, Alexey Kardashevskiy wrote:
>>> On 06/03/2014 11:19 PM, Alexey Kardashevskiy wrote:
>>>> On 05/30/2014 07:34 PM, Alexey Kardashevskiy wrote:
>>>>> There are few helpers already to support array migration. However they all
>>>>> require the destination side to preallocate arrays before migration which
>>>>> is not always possible due to unknown array size as it might be some
>>>>> sort of dynamic state. One of the examples is an array of MSIX-enabled
>>>>> devices in SPAPR PHB - this array may vary from 0 to 65536 entries and
>>>>> its size depends on guest's ability to enable MSIX or do PCI hotplug.
>>>>>
>>>>> This adds new VMSTATE_VARRAY_STRUCT_ALLOC macro which is pretty similar to
>>>>> VMSTATE_STRUCT_VARRAY_POINTER_INT32 but it can alloc memory for migratign
>>>>> array on the destination side.
>>>>>
>>>>> This defines VMS_ALLOC flag for a field.
>>>>>
>>>>> This changes vmstate_base_addr() to do the allocation when receiving
>>>>> migration.
>>>>
>>>>
>>>> Juan, Peter? No hurry, just pinging in order not to forget :) Thanks!
>>>
>>> Hi, anyone? :)
>>
>> Ping?
>
> Acked-by: Alexander Graf <agraf@suse.de>

Reviewed-by: Juan Quintela <quintela@redhat.com>

BTW, should I include it, or will it got include through this series?

I am ok with both.

Later, Juan.