From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v7 2/4] sdl_image: add host version
Date: Wed, 19 Feb 2014 16:14:47 +0100 [thread overview]
Message-ID: <874n3v16e0.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20140218171156.414cb304@skate> (Thomas Petazzoni's message of "Tue, 18 Feb 2014 17:11:56 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> Dear Maxime Hadjinlian,
> On Tue, 18 Feb 2014 00:37:11 +0100, Maxime Hadjinlian wrote:
>> diff --git a/package/sdl_image/sdl_image.mk b/package/sdl_image/sdl_image.mk
>> index ba9751d..05b9a1f 100644
>> --- a/package/sdl_image/sdl_image.mk
>> +++ b/package/sdl_image/sdl_image.mk
>> @@ -38,4 +38,15 @@ SDL_IMAGE_DEPENDENCIES = sdl \
>> $(if $(BR2_PACKAGE_SDL_IMAGE_TIFF),tiff) \
>> $(if $(BR2_PACKAGE_SDL_IMAGE_WEBP),webp)
>>
>> +HOST_SDL_IMAGE_CONF_OPT = --with-sdl-prefix=$(HOST_DIR)/usr \
>> + --with-sdl-exec-prefix=$(HOST_DIR)/usr \
>> + --disable-sdltest \
>> + --disable-static \
>> + --disable-jpg-shared \
>> + --disable-png-shared \
>> + --disable-tif-shared \
> This is nitpicking, but we normally intend this with one tab, do not
> have a backslash on the last line, and also intend the first line. So,
> something like:
> HOST_SDL_IMAGE_CONF_OPT = \
> --with-sdl-prefix=... \
> --foo \
> --bar \
> --baz
True, but this atleast matches what is done just above for the target
version. With that being said, a followup patch to cleanup both would be
nice.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2014-02-19 15:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 23:37 [Buildroot] [PATCH v7 0/4] Introducing XBMC Maxime Hadjinlian
2014-02-17 23:37 ` [Buildroot] [PATCH v7 1/4] sdl: add host version Maxime Hadjinlian
2014-02-18 16:13 ` Thomas Petazzoni
2014-02-18 16:41 ` Maxime Hadjinlian
2014-02-19 15:12 ` Peter Korsgaard
2014-02-17 23:37 ` [Buildroot] [PATCH v7 2/4] sdl_image: " Maxime Hadjinlian
2014-02-18 16:11 ` Thomas Petazzoni
2014-02-19 15:14 ` Peter Korsgaard [this message]
2014-02-19 15:14 ` Peter Korsgaard
2014-02-17 23:37 ` [Buildroot] [PATCH v7 3/4] infra: Introduce BR2_HOST_NEEDS_JAVA Maxime Hadjinlian
2014-02-18 16:18 ` Thomas Petazzoni
2014-02-18 16:41 ` Maxime Hadjinlian
2014-02-18 16:44 ` Thomas Petazzoni
2014-02-19 15:19 ` Peter Korsgaard
2014-02-17 23:37 ` [Buildroot] [PATCH v7 4/4] xbmc: new package Maxime Hadjinlian
2014-02-18 16:38 ` Thomas Petazzoni
2014-02-18 17:02 ` Maxime Hadjinlian
2014-02-18 18:30 ` Martin Bark
2014-02-19 0:14 ` Maxime Hadjinlian
2014-02-18 16:57 ` [Buildroot] [PATCH v7 0/4] Introducing XBMC Martin Bark
2014-02-18 17:03 ` Maxime Hadjinlian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874n3v16e0.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.