From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38369)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1UscKo-0007fn-L6
	for qemu-devel@nongnu.org; Fri, 28 Jun 2013 13:19:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1UscKn-0008Om-De
	for qemu-devel@nongnu.org; Fri, 28 Jun 2013 13:19:46 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1372342930-28684-1-git-send-email-armbru@redhat.com>
	<1372342930-28684-5-git-send-email-armbru@redhat.com>
	<51CD9188.8060203@redhat.com>
Date: Fri, 28 Jun 2013 19:19:39 +0200
In-Reply-To: <51CD9188.8060203@redhat.com> (Eric Blake's message of "Fri, 28
	Jun 2013 07:37:12 -0600")
Message-ID: <874nci40gk.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 4/4] qapi: Rename ChardevBackend member
	"memory" to "ringbuf"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: aliguori@us.ibm.com, lilei@linux.vnet.ibm.com, qemu-stable@nongnu.org, qemu-devel@nongnu.org, lcapitulino@redhat.com, kraxel@redhat.com, Amos Kong <akong@redhat.com>

Eric Blake <eblake@redhat.com> writes:

> On 06/27/2013 08:22 AM, Markus Armbruster wrote:
>> Commit 1da48c6 called the new member "memory" after commit 3949e59
>> standardized "ringbuf".  Rename for consistency.
>> 
>> However, member name "memory" is visible in QMP since 1.5.  It's
>> undocumented just like the driver name.  Keep it working anyway.
>> 
>> Cc: qemu-stable@nongnu.org
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  qapi-schema.json |  6 ++++--
>>  qemu-char.c      | 11 ++++++-----
>>  2 files changed, 10 insertions(+), 7 deletions(-)
>> 
>> diff --git a/qapi-schema.json b/qapi-schema.json
>> index 6445da6..b3df8a5 100644
>> --- a/qapi-schema.json
>> +++ b/qapi-schema.json
>> @@ -3277,9 +3277,9 @@
>>  ##
>>  # @ChardevRingbuf:
>>  #
>> -# Configuration info for memory chardevs
>> +# Configuration info for ring buffer chardevs.
>>  #
>> -# @size: #optional Ringbuffer size, must be power of two, default is 65536
>> +# @size: #optional ring buffer size, must be power of two, default is 65536
>>  #
>>  # Since: 1.5
>>  ##
>> @@ -3310,6 +3310,8 @@
>>                                         'spicevmc' : 'ChardevSpiceChannel',
>>                                         'spiceport' : 'ChardevSpicePort',
>>                                         'vc'     : 'ChardevVC',
>> +                                       'ringbuf': 'ChardevRingbuf',
>> +                                       # next one is just for compatibility
>>                                         'memory' : 'ChardevRingbuf' } }
>
> Does JSON allow comments in the middle of content?  Is this going to
> screw up Amos' work on introspection?  You may need to instead have a
> comment before the open '{' stating that 'memory' is an alias within the
> union for back-compat reasons.

RFC 4627 doesn't do comments at all.

This file is parsed by scripts/qapi.py, which as far as I can tell
ignores lines starting with '#' anywhere in the input.