From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 4/4] kvm: i386: Add classic PCI device assignment Date: Tue, 04 Sep 2012 16:00:55 -0500 Message-ID: <874nndmrjs.fsf@codemonkey.ws> References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503B62F4.9070500@suse.de> <87k3wjyy0e.fsf@codemonkey.ws> <503E227B.40904@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , Alexey Kardashevskiy , Marcelo Tosatti , qemu-devel@nongnu.org, Blue Swirl , Alex Williamson , Jan Kiszka , Avi Kivity , qemu-ppc To: Andreas =?utf-8?Q?F=C3=A4rber?= Return-path: In-Reply-To: <503E227B.40904@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org Andreas F=C3=A4rber writes: > Am 28.08.2012 14:57, schrieb Anthony Liguori: >> Andreas F=C3=A4rber writes: >>=20 >>> Hi, >>> >>> Am 27.08.2012 08:28, schrieb Jan Kiszka: >>>> From: Jan Kiszka >>>> >>>> This adds PCI device assignment for i386 targets using the classic KVM >>>> interfaces. This version is 100% identical to what is being maintained >>>> in qemu-kvm for several years and is supported by libvirt as well. It = is >>>> expected to remain relevant for another couple of years until kernels >>>> without full-features and performance-wise equivalent VFIO support are >>>> obsolete. >>>> >>>> A refactoring to-do that should be done in-tree is to model MSI and >>>> MSI-X support via the generic PCI layer, similar to what VFIO is alrea= dy >>>> doing for MSI-X. This should improve the correctness and clean up the >>>> code from duplicate logic. >>>> >>>> Signed-off-by: Jan Kiszka >>>> --- >>>> hw/kvm/Makefile.objs | 2 +- >>>> hw/kvm/pci-assign.c | 1929 +++++++++++++++++++++++++++++++++++++++++= +++++++++ >>>> 2 files changed, 1930 insertions(+), 1 deletions(-) >>>> create mode 100644 hw/kvm/pci-assign.c >>> [...] >>>> diff --git a/hw/kvm/pci-assign.c b/hw/kvm/pci-assign.c >>>> new file mode 100644 >>>> index 0000000..9cce02c >>>> --- /dev/null >>>> +++ b/hw/kvm/pci-assign.c >>>> @@ -0,0 +1,1929 @@ >>>> +/* >>>> + * Copyright (c) 2007, Neocleus Corporation. >>>> + * >>>> + * This program is free software; you can redistribute it and/or modi= fy it >>>> + * under the terms and conditions of the GNU General Public License, >>>> + * version 2, as published by the Free Software Foundation. >>> >>> The downside of accepting this into qemu.git is that it gets us a huge >>> blob of GPLv2-only code without history of contributors for GPLv2+ >>> relicensing... >>=20 >> That is 100% okay. > > Why? The way this is being submitted I don't see why we should treat > Jan's patch any different from a patch by IBM or Samsung where we've > asked folks to fix the license to comply with what I thought was our new > policy (it does not even contain a from-x-on-GPLv2+ notice). Asking is one thing. Requiring is another. I would prefer that people submitted GPLv2+, but I don't think it should be a hard requirement. It means, among other things, that we cannot accept most code that originates from the Linux kernel. Regards, Anthony Liguori From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T90FE-0007YC-Vx for qemu-devel@nongnu.org; Tue, 04 Sep 2012 17:01:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T90FC-0006DK-LJ for qemu-devel@nongnu.org; Tue, 04 Sep 2012 17:01:12 -0400 Received: from mail-gg0-f173.google.com ([209.85.161.173]:44902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T90FC-0006BZ-Gf for qemu-devel@nongnu.org; Tue, 04 Sep 2012 17:01:10 -0400 Received: by ggna5 with SMTP id a5so1406313ggn.4 for ; Tue, 04 Sep 2012 14:01:09 -0700 (PDT) From: Anthony Liguori In-Reply-To: <503E227B.40904@suse.de> References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503B62F4.9070500@suse.de> <87k3wjyy0e.fsf@codemonkey.ws> <503E227B.40904@suse.de> Date: Tue, 04 Sep 2012 16:00:55 -0500 Message-ID: <874nndmrjs.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , Alexey Kardashevskiy , Marcelo Tosatti , qemu-devel@nongnu.org, Blue Swirl , Alex Williamson , Jan Kiszka , Avi Kivity , qemu-ppc Andreas F=C3=A4rber writes: > Am 28.08.2012 14:57, schrieb Anthony Liguori: >> Andreas F=C3=A4rber writes: >>=20 >>> Hi, >>> >>> Am 27.08.2012 08:28, schrieb Jan Kiszka: >>>> From: Jan Kiszka >>>> >>>> This adds PCI device assignment for i386 targets using the classic KVM >>>> interfaces. This version is 100% identical to what is being maintained >>>> in qemu-kvm for several years and is supported by libvirt as well. It = is >>>> expected to remain relevant for another couple of years until kernels >>>> without full-features and performance-wise equivalent VFIO support are >>>> obsolete. >>>> >>>> A refactoring to-do that should be done in-tree is to model MSI and >>>> MSI-X support via the generic PCI layer, similar to what VFIO is alrea= dy >>>> doing for MSI-X. This should improve the correctness and clean up the >>>> code from duplicate logic. >>>> >>>> Signed-off-by: Jan Kiszka >>>> --- >>>> hw/kvm/Makefile.objs | 2 +- >>>> hw/kvm/pci-assign.c | 1929 +++++++++++++++++++++++++++++++++++++++++= +++++++++ >>>> 2 files changed, 1930 insertions(+), 1 deletions(-) >>>> create mode 100644 hw/kvm/pci-assign.c >>> [...] >>>> diff --git a/hw/kvm/pci-assign.c b/hw/kvm/pci-assign.c >>>> new file mode 100644 >>>> index 0000000..9cce02c >>>> --- /dev/null >>>> +++ b/hw/kvm/pci-assign.c >>>> @@ -0,0 +1,1929 @@ >>>> +/* >>>> + * Copyright (c) 2007, Neocleus Corporation. >>>> + * >>>> + * This program is free software; you can redistribute it and/or modi= fy it >>>> + * under the terms and conditions of the GNU General Public License, >>>> + * version 2, as published by the Free Software Foundation. >>> >>> The downside of accepting this into qemu.git is that it gets us a huge >>> blob of GPLv2-only code without history of contributors for GPLv2+ >>> relicensing... >>=20 >> That is 100% okay. > > Why? The way this is being submitted I don't see why we should treat > Jan's patch any different from a patch by IBM or Samsung where we've > asked folks to fix the license to comply with what I thought was our new > policy (it does not even contain a from-x-on-GPLv2+ notice). Asking is one thing. Requiring is another. I would prefer that people submitted GPLv2+, but I don't think it should be a hard requirement. It means, among other things, that we cannot accept most code that originates from the Linux kernel. Regards, Anthony Liguori