All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty.russell@linaro.org>
To: Christoffer Dall <c.dall@virtualopensystems.com>
Cc: Rusty Russell <rusty.russell@linaro.org>,
	android-virt@lists.cs.columbia.edu, kvm@vger.kernel.org,
	tech@virtualopensystems.com, Marc Zyngier <marc.zyngier@arm.com>,
	"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [PATCH] ARM: KVM: Check the cpuid we're being asked to emulate.
Date: Mon, 21 May 2012 10:43:56 +0930	[thread overview]
Message-ID: <874nra49pn.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CANM98qLyAEPJiQTBivUCOpXBhbLQYmHWjJ_R1Y-6E9e1PnBOVw@mail.gmail.com>

On Sun, 20 May 2012 14:34:48 -0400, Christoffer Dall <c.dall@virtualopensystems.com> wrote:
> On Wed, May 16, 2012 at 7:58 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
> > On Mon, 14 May 2012 18:57:20 -0400, Christoffer Dall <c.dall@virtualopensystems.com> wrote:
> >> On Thu, Mar 22, 2012 at 8:41 PM, Rusty Russell <rusty.russell@linaro.org> wrote:
> >> > As our emulation gets more sophisticated, we need to know what CPU model
> >> > we're dealing with.  Particularly for some of the nastier workarounds.
> >> >
> >> > Let's start with Cortex A-15.  We can then test the MIDR elsewhere in the
> >> > code, knowing that it's one of a finite set of allowed values.
> >
> > (Revisiting this now)
> >
> > The intent is good, this patch is not the right way to do it though.  I
> > think want an explicit ioctl to tell the kernel what CPU; since the
> > kernel initialized the regs, it needs to know.
> >
> not sure of your point exactly, but if I understand correctly, what
> you're saying is that since the kernel initializes all the regs (at
> least it's going to) we want an ioctl to say "this is the cpu for
> which you will initialize the regs"?
> 
> that also makes for a more friendly user space interface than "you
> need to set this register to this cryptic value to emulate this
> cpu"...

Yes, exactly.  Esp. since it also effects some of the cp15 emulation
hacks.

Cheers,
Rusty.

  reply	other threads:[~2012-05-21  1:18 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-12  6:51 [PATCH v7 00/12] KVM/ARM Implementation Christoffer Dall
2012-03-12  6:51 ` [PATCH v7 01/12] KVM: Introduce __KVM_HAVE_IRQ_LINE Christoffer Dall
2012-03-23  0:41   ` [PATCH] ARM: KVM: Check the cpuid we're being asked to emulate Rusty Russell
2012-05-14 22:57     ` Christoffer Dall
2012-05-16 23:58       ` Rusty Russell
2012-05-20 18:34         ` Christoffer Dall
2012-05-21  1:13           ` Rusty Russell [this message]
2012-03-12  6:52 ` [PATCH v7 02/12] KVM: Guard mmu_notifier specific code with CONFIG_MMU_NOTIFIER Christoffer Dall
2012-03-12 15:50   ` Avi Kivity
2012-03-12  6:52 ` [PATCH v7 03/12] ARM: KVM: Initial skeleton to compile KVM support Christoffer Dall
2012-03-12  6:52 ` [PATCH v7 04/12] ARM: KVM: Hypervisor identity mapping Christoffer Dall
2012-03-12  6:52 ` [PATCH v7 05/12] ARM: KVM: Hypervisor inititalization Christoffer Dall
2012-03-12  6:52 ` [PATCH v7 06/12] ARM: KVM: Memory virtualization setup Christoffer Dall
2012-03-12  6:52 ` [PATCH v7 07/12] ARM: KVM: Inject IRQs and FIQs from userspace Christoffer Dall
2012-03-12  6:52 ` [PATCH v7 08/12] ARM: KVM: World-switch implementation Christoffer Dall
2012-03-23  0:23   ` Rusty Russell
2012-03-28 13:05     ` Avi Kivity
2012-03-28 21:57       ` Rusty Russell
2012-03-29 10:49         ` Avi Kivity
2012-05-14 18:08           ` Christoffer Dall
2012-03-12  6:52 ` [PATCH v7 09/12] ARM: KVM: Emulation framework and CP15 emulation Christoffer Dall
2012-03-12  6:52 ` [PATCH v7 10/12] ARM: KVM: Handle guest faults in KVM Christoffer Dall
2012-03-12 15:31   ` [Android-virt] " Marc Zyngier
2012-03-12 16:23     ` Christoffer Dall
2012-03-12 16:28       ` Marc Zyngier
2012-03-12  6:53 ` [PATCH v7 11/12] ARM: KVM: Handle I/O aborts Christoffer Dall
2012-03-12  6:53 ` [PATCH v7 12/12] ARM: KVM: Guest wait-for-interrupts (WFI) support Christoffer Dall
2012-03-12 17:36 ` [PATCH v7 00/12] KVM/ARM Implementation Avi Kivity
2012-03-23  0:40 ` [PATCH] ARM: KVM: Remove l2ctlr write Rusty Russell
2012-05-14 22:59   ` Christoffer Dall
2012-03-29  5:11 ` [PATCH 0/3] Emulation cleanups Rusty, Russell <rusty.russell
2012-03-29  5:15   ` [PATCH 1/3] ARM: KVM: Remove l2ctlr write Rusty Russell
2012-03-29  5:17   ` [PATCH 2/3] ARM: KVM: Fake up performance counters a little more precisely Rusty Russell
2012-05-14 22:49     ` Christoffer Dall
2012-05-17  0:12       ` Rusty Russell
2012-03-29  5:17   ` [PATCH 3/3] ARM: KVM: Check the cpuid we're being asked to emulate Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874nra49pn.fsf@rustcorp.com.au \
    --to=rusty.russell@linaro.org \
    --cc=android-virt@lists.cs.columbia.edu \
    --cc=c.dall@virtualopensystems.com \
    --cc=kvm@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=peter.maydell@linaro.org \
    --cc=tech@virtualopensystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.