From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [RFC] drm/i915: use PIPE_CONTROL for flushing on gen6+ Date: Fri, 12 Aug 2011 16:55:47 -0700 Message-ID: <874o1m18xo.fsf@eliezer.anholt.net> References: <20110812111845.339aab04@jbarnes-desktop> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0832938013==" Return-path: In-Reply-To: <20110812111845.339aab04@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0832938013== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 12 Aug 2011 11:18:45 -0700, Jesse Barnes = wrote: > I'm trying to figure out why this doesn't work. Anyone have ideas? >=20 > On gen6+ (well probably since Cantiga actually) we're supposed to use > PIPE_CONTROL rather than MI_FLUSH for flushing the pipeline and > caches. This patch doesn't cause hangs or crashes in my testing, but > does prevent glxgears from displaying anything. >=20 > The other worrying thing about this is that gen6+ has a command length > field of 3, but we're using 2 in the DRI driver, even on gen6. > Changing it doesn't seem to have any effect, but it's still of concern. From=20what I've read, the hardware tends to process shortened packets using some garbage in whatever fields were left out. I don't see why we'd need a separate object for the pipe control write destination. We could just drop it in some unused bit of the status page, right? I'd drop the scratch_addr from packets that don't do a post-sync write, for clarity. I don't see what's actually going wrong in this patch, though. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk5FvYMACgkQHUdvYGzw6vejNgCgkqeWYlgzHq2VoZzx1+3W4Us5 N44An03UEY12u1inmGYdFL9b+FxnFjDR =I8Z2 -----END PGP SIGNATURE----- --=-=-=-- --===============0832938013== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0832938013==--