From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] mk: allow exec-env specific targets
Date: Tue, 06 Jun 2017 09:16:34 +0200
Message-ID: <8755040.9J4WnU9ERX@xps>
References: <20170606063650.31434-1-jerin.jacob@caviumnetworks.com>
 <1514064.RDqP8U0lKr@xps> <20170606070213.GA32334@jerin>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 291905689
 for <dev@dpdk.org>; Tue,  6 Jun 2017 09:16:35 +0200 (CEST)
In-Reply-To: <20170606070213.GA32334@jerin>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

06/06/2017 09:02, Jerin Jacob:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 06/06/2017 08:36, Jerin Jacob:
> > > Add a hook in generic rte.sdkbuild.mk file
> > > to include exec-env specific targets.
> > > 
> > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > ---
> > > Useful in integrating some custom targets in nonstandard execution environments.
> > > For example, a bare-metal-simulator exec execution environment may need
> > > a target to run the dpdk applications.
> > > ---
> > 
> > This patch is just including an empty file.
> 
> Do you like to add check for the file is present or not ? and if present,
> invoke the file.

The dash prefixing does the check:
-include

> > Please explain how it can help with a real example.
> 
> We are evaluating on running DPDK on a nonstandard execution environment like
> bare metal where I would to keep all my execution environment specific
> change at following location. So that I can easy move around different
> version of DPDK without merge conflict.
> 
> $(RTE_SDK)mk/exec-env/my-exec-env
> $(RTE_SDK)lib/librte_eal/my-exec-env
> 
> I believe, The existing target like "exec-env-appinstall" in mk/exec-env/linuxapp/rte.app.mk,
> solves the same purpose.

I do not understand.
If you want to add a new environment, why not just adding it?