Re: [Buildroot] [PATCH 2/2] package/imx-cst: new package

[Baruch Siach via buildroot <buildroot@buildroot.org>]

Hi Thomas,

On Fri, Apr 22 2022, Thomas Petazzoni wrote:
> On Fri, 22 Apr 2022 12:09:00 +0200
> Thomas Perrot <thomas.perrot@bootlin.com> wrote:
>
>> > It looks like the only difference between 64 and 32 is in openssl
>> > build
>> > rule, and for x86 (host) targets only. We don't use this openssl rule
>> > since we build host-openssl with our own rules. So maybe we can just
>> > arbitrarily choose hard coded 'linux64'. It seems that
>> > debian/Makefile
>> > does that.  
>> 
>> Thanks for your review, I’m submitting a v3 with the OSTYPE variable
>> hardcoded to linux64.
>
> No, please don't. We're doing the build like this:
>
> build:
>         $(MAKE) -C $(CST_CODE_PATH)/obj.$(OSTYPE) build
>
> And code/cst/code/obj.linux32/Makefile contains:
>
> COPTIONS += -m32
> LDOPTIONS += -m32
>
> while code/cst/code/obj.linux64/Makefile contains
>
> COPTIONS += -m64
> LDOPTIONS += -m64
>
> And I can definitely see the -m64 being added in the compiler flags
> when doing a build on a x86-64 host (run the build with VERBOSE=1, you
> will see).
>
> So if you use linux64 unconditionally, the CST binaries will be built
> with -m64, even on 32-bit host machines => bad.

You are right. I didn't notice these -m32/-m64 parameters.

But that raises another problem. -m32/-m64 are platform specific
options. A quick look at the GCC manual indicates that x86, Sparc, and
PowerPC targets support these options. S390 supports -m64, but not
-m32. ARM/ARM64 support none. So this package should depend on host
architectures that support -m32/-m64.

Alternatively we can just patch out the whole 32/64 thing. This is most
likely a remnant of previous versions that shipped binary .a files.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot