[Buildroot] [PATCH] package/sunxi-mali-mainline-driver: update help section to make it work on Linux >= 4.20

[Buildroot] [PATCH] package/sunxi-mali-mainline-driver: update help section to make it work on Linux >= 4.20

[Giulio Benetti]

On Linux version >= 4.20 we need to pass
drm_kms_helper.drm_leak_fbdev_smem=1 to make this driver to work.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/sunxi-mali-mainline-driver/Config.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/sunxi-mali-mainline-driver/Config.in b/package/sunxi-mali-mainline-driver/Config.in
index 5db66c5bf6..9bc80944fb 100644
--- a/package/sunxi-mali-mainline-driver/Config.in
+++ b/package/sunxi-mali-mainline-driver/Config.in
@@ -25,5 +25,8 @@ config BR2_PACKAGE_SUNXI_MALI_MAINLINE_DRIVER
 	  starting from Linux Kernel >= 4.20 following options must be
 	  enabled:
 	  - CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM
+	  and following kernel command-line must be passed:
+	  `drm_kms_helper.drm_leak_fbdev_smem=1`
+	  since drm_kms_helper.drm_leak_fbdev_smem is set to 0 by default
 
 	  https://github.com/mripard/sunxi-mali/blob/master/README.md
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/sunxi-mali-mainline-driver: update help section to make it work on Linux >= 4.20

[Giulio Benetti]

On 10/14/21 10:46 PM, Giulio Benetti wrote:
> On Linux version >= 4.20 we need to pass
> drm_kms_helper.drm_leak_fbdev_smem=1 to make this driver to work.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>   package/sunxi-mali-mainline-driver/Config.in | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/package/sunxi-mali-mainline-driver/Config.in b/package/sunxi-mali-mainline-driver/Config.in
> index 5db66c5bf6..9bc80944fb 100644
> --- a/package/sunxi-mali-mainline-driver/Config.in
> +++ b/package/sunxi-mali-mainline-driver/Config.in
> @@ -25,5 +25,8 @@ config BR2_PACKAGE_SUNXI_MALI_MAINLINE_DRIVER
>   	  starting from Linux Kernel >= 4.20 following options must be
>   	  enabled:
>   	  - CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM
> +	  and following kernel command-line must be passed:
> +	  `drm_kms_helper.drm_leak_fbdev_smem=1`
> +	  since drm_kms_helper.drm_leak_fbdev_smem is set to 0 by default
>   
>   	  https://github.com/mripard/sunxi-mali/blob/master/README.md

This also needs drm_kms_helper.drm_fbdev_overalloc=200 at least too as 
olinuxino patch:
https://patchwork.ozlabs.org/project/buildroot/patch/20211014213630.2436055-1-giulio.benetti@benettiengineering.com/
I'm going to send a v2 patch for this.

Sorry again for the noise
-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2] package/sunxi-mali-mainline-driver: update help section to make it work on Linux >= 4.20

[Giulio Benetti]

On Linux version >= 4.20 in order to have mali working we need to pass
drm_kms_helper.drm_leak_fbdev_smem=1 and at least
drm_kms_helper.drm_fbdev_overalloc=200 to have a double buffer fbdev.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* add double buffer too
---
 package/sunxi-mali-mainline-driver/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/sunxi-mali-mainline-driver/Config.in b/package/sunxi-mali-mainline-driver/Config.in
index 5db66c5bf6..bd6819cf82 100644
--- a/package/sunxi-mali-mainline-driver/Config.in
+++ b/package/sunxi-mali-mainline-driver/Config.in
@@ -25,5 +25,11 @@ config BR2_PACKAGE_SUNXI_MALI_MAINLINE_DRIVER
 	  starting from Linux Kernel >= 4.20 following options must be
 	  enabled:
 	  - CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM
+	  and following kernel command-line must be passed:
+	  `drm_kms_helper.drm_leak_fbdev_smem = 1`
+	  since drm_kms_helper.drm_leak_fbdev_smem is set to 0 by default
+	  `drm_kms_helper.drm_fbdev_overalloc >= 200`
+	  since the driver requires at least double buffering and fails to
+	  work with the default value(100).
 
 	  https://github.com/mripard/sunxi-mali/blob/master/README.md
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/sunxi-mali-mainline-driver: update help section to make it work on Linux >= 4.20

[Thomas Petazzoni]

On Fri, 15 Oct 2021 10:16:01 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> On Linux version >= 4.20 in order to have mali working we need to pass
> drm_kms_helper.drm_leak_fbdev_smem=1 and at least
> drm_kms_helper.drm_fbdev_overalloc=200 to have a double buffer fbdev.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * add double buffer too
> ---
>  package/sunxi-mali-mainline-driver/Config.in | 6 ++++++
>  1 file changed, 6 insertions(+)

Applied to master with some reformatting tweaks. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/sunxi-mali-mainline-driver: update help section to make it work on Linux >= 4.20

[Peter Korsgaard]

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > On Linux version >= 4.20 in order to have mali working we need to pass
 > drm_kms_helper.drm_leak_fbdev_smem=1 and at least
 > drm_kms_helper.drm_fbdev_overalloc=200 to have a double buffer fbdev.

 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Committed to 2021.02.x and 2021.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot