From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0504AC433EF for ; Mon, 20 Sep 2021 07:47:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A29D660F23 for ; Mon, 20 Sep 2021 07:47:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A29D660F23 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:46624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSE1c-0004bz-SM for qemu-devel@archiver.kernel.org; Mon, 20 Sep 2021 03:47:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSDxV-0006rT-Qu for qemu-devel@nongnu.org; Mon, 20 Sep 2021 03:43:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:51395) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSDxS-0006qE-9r for qemu-devel@nongnu.org; Mon, 20 Sep 2021 03:43:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632123800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uJrFIQreAuEyTIbd27/BJkBa0A4tQQVTICtjiXNdj94=; b=avXK1mm1QL9fHeMQqooyCOfOQIuPJZ5xEjMwFaukpjCLzGPyfnEuVm2YCGoW/OzjCss4zz Axc1CU3gl9fe4hSt7Og9LDLhxIGFbSCFLvF35jG0Pabr7soyRqSJ4OkOtNOazT3Y0AxMby igGOmt4dcB+hwjDg4ahHNLTpec9LgYY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-115-LnEYpc1rPUGw5UxtqaEKwg-1; Mon, 20 Sep 2021 03:43:19 -0400 X-MC-Unique: LnEYpc1rPUGw5UxtqaEKwg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4F7F8362FB; Mon, 20 Sep 2021 07:43:15 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-14.ams2.redhat.com [10.36.112.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D9DDE1F436; Mon, 20 Sep 2021 07:42:37 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 94A1F113865F; Mon, 20 Sep 2021 09:42:36 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Subject: Re: [PATCH v2 02/53] docs/devel: tweak headings in monitor command docs References: <20210914142042.1655100-1-berrange@redhat.com> <20210914142042.1655100-3-berrange@redhat.com> Date: Mon, 20 Sep 2021 09:42:36 +0200 In-Reply-To: <20210914142042.1655100-3-berrange@redhat.com> ("Daniel P. =?utf-8?Q?Berrang=C3=A9=22's?= message of "Tue, 14 Sep 2021 15:19:51 +0100") Message-ID: <875yuv4rrn.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.476, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Chris Wulff , David Hildenbrand , Bin Meng , Mark Cave-Ayland , qemu-devel@nongnu.org, Laurent Vivier , Max Filippov , Taylor Simpson , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Eric Blake , Marek Vasut , Yoshinori Sato , Halil Pasic , Christian Borntraeger , Palmer Dabbelt , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , Yuval Shaia , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Peter Xu , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Cornelia Huck , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-ppc@nongnu.org, Aurelien Jarno , Paolo Bonzini , Aleksandar Rikalo , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Daniel P. Berrang=C3=A9 writes: > The new headings reflect the intended structure of the document and will > better suit additions that follow. > > Signed-off-by: Daniel P. Berrang=C3=A9 > --- > docs/devel/writing-monitor-commands.rst | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/docs/devel/writing-monitor-commands.rst b/docs/devel/writing= -monitor-commands.rst > index 497c9ce0d5..cddb36fb74 100644 > --- a/docs/devel/writing-monitor-commands.rst > +++ b/docs/devel/writing-monitor-commands.rst > @@ -85,8 +85,8 @@ any data". Now you're ready to enter the QMP example co= mmands as explained in > the following sections. > =20 > =20 > -Writing a command that doesn't return data > ------------------------------------------- > +Writing a simple command: hello-world > +------------------------------------- > =20 > That's the most simple QMP command that can be written. Usually, this ki= nd of > command carries some meaningful action in QEMU but here it will just pri= nt > @@ -340,8 +340,8 @@ Please, check the "-monitor" command-line option to k= now how to open a user > monitor. > =20 > =20 > -Writing a command that returns data > ------------------------------------ > +Writing more complex commands > +----------------------------- > =20 > A QMP command is capable of returning any data the QAPI supports like in= tegers, > strings, booleans, enumerations and user defined types. Reviewed-by: Markus Armbruster From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mSDxb-0006wN-0m for mharc-qemu-riscv@gnu.org; Mon, 20 Sep 2021 03:43:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSDxX-0006sF-60 for qemu-riscv@nongnu.org; Mon, 20 Sep 2021 03:43:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:20842) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSDxS-0006qC-9i for qemu-riscv@nongnu.org; Mon, 20 Sep 2021 03:43:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632123800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uJrFIQreAuEyTIbd27/BJkBa0A4tQQVTICtjiXNdj94=; b=avXK1mm1QL9fHeMQqooyCOfOQIuPJZ5xEjMwFaukpjCLzGPyfnEuVm2YCGoW/OzjCss4zz Axc1CU3gl9fe4hSt7Og9LDLhxIGFbSCFLvF35jG0Pabr7soyRqSJ4OkOtNOazT3Y0AxMby igGOmt4dcB+hwjDg4ahHNLTpec9LgYY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-115-LnEYpc1rPUGw5UxtqaEKwg-1; Mon, 20 Sep 2021 03:43:19 -0400 X-MC-Unique: LnEYpc1rPUGw5UxtqaEKwg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4F7F8362FB; Mon, 20 Sep 2021 07:43:15 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-14.ams2.redhat.com [10.36.112.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D9DDE1F436; Mon, 20 Sep 2021 07:42:37 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 94A1F113865F; Mon, 20 Sep 2021 09:42:36 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: qemu-devel@nongnu.org, Greg Kurz , Bin Meng , Yoshinori Sato , Stafford Horne , Cornelia Huck , David Hildenbrand , "Edgar E. Iglesias" , Jiaxun Yang , Peter Xu , Christian Borntraeger , qemu-ppc@nongnu.org, Mark Cave-Ayland , Paolo Bonzini , qemu-arm@nongnu.org, Michael Rolnik , Peter Maydell , Palmer Dabbelt , Alistair Francis , Halil Pasic , Taylor Simpson , Gerd Hoffmann , qemu-riscv@nongnu.org, Max Filippov , Yuval Shaia , Bastian Koppelmann , Artyom Tarasenko , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Thomas Huth , Aleksandar Rikalo , David Gibson , Marcel Apfelbaum , Laurent Vivier , "Dr. David Alan Gilbert" , Eduardo Habkost , Marek Vasut , Aurelien Jarno , qemu-s390x@nongnu.org, Laurent Vivier , Eric Blake , Richard Henderson , Chris Wulff Subject: Re: [PATCH v2 02/53] docs/devel: tweak headings in monitor command docs References: <20210914142042.1655100-1-berrange@redhat.com> <20210914142042.1655100-3-berrange@redhat.com> Date: Mon, 20 Sep 2021 09:42:36 +0200 In-Reply-To: <20210914142042.1655100-3-berrange@redhat.com> ("Daniel P. =?utf-8?Q?Berrang=C3=A9=22's?= message of "Tue, 14 Sep 2021 15:19:51 +0100") Message-ID: <875yuv4rrn.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) DKIMWL_WL_HIGH=-1.476, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2021 07:43:28 -0000 Daniel P. Berrang=C3=A9 writes: > The new headings reflect the intended structure of the document and will > better suit additions that follow. > > Signed-off-by: Daniel P. Berrang=C3=A9 > --- > docs/devel/writing-monitor-commands.rst | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/docs/devel/writing-monitor-commands.rst b/docs/devel/writing= -monitor-commands.rst > index 497c9ce0d5..cddb36fb74 100644 > --- a/docs/devel/writing-monitor-commands.rst > +++ b/docs/devel/writing-monitor-commands.rst > @@ -85,8 +85,8 @@ any data". Now you're ready to enter the QMP example co= mmands as explained in > the following sections. > =20 > =20 > -Writing a command that doesn't return data > ------------------------------------------- > +Writing a simple command: hello-world > +------------------------------------- > =20 > That's the most simple QMP command that can be written. Usually, this ki= nd of > command carries some meaningful action in QEMU but here it will just pri= nt > @@ -340,8 +340,8 @@ Please, check the "-monitor" command-line option to k= now how to open a user > monitor. > =20 > =20 > -Writing a command that returns data > ------------------------------------ > +Writing more complex commands > +----------------------------- > =20 > A QMP command is capable of returning any data the QAPI supports like in= tegers, > strings, booleans, enumerations and user defined types. Reviewed-by: Markus Armbruster