From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21CB0C4338F for ; Mon, 23 Aug 2021 12:10:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02B0A61378 for ; Mon, 23 Aug 2021 12:10:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236634AbhHWMK5 (ORCPT ); Mon, 23 Aug 2021 08:10:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:43870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233895AbhHWMK4 (ORCPT ); Mon, 23 Aug 2021 08:10:56 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 63CB26135F; Mon, 23 Aug 2021 12:10:14 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mI8mK-006ej3-DI; Mon, 23 Aug 2021 13:10:12 +0100 Date: Mon, 23 Aug 2021 13:10:11 +0100 Message-ID: <875yvwqs4c.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: kvmarm@lists.cs.columbia.edu, will@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, christoffer.dall@arm.com, pbonzini@redhat.com, drjones@redhat.com, oupton@google.com, qperret@google.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com Subject: Re: [PATCH v4 11/15] KVM: arm64: Guest exit handlers for nVHE hyp In-Reply-To: References: <20210817081134.2918285-1-tabba@google.com> <20210817081134.2918285-12-tabba@google.com> <87fsv6snup.wl-maz@kernel.org> <87zgtdqz77.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tabba@google.com, kvmarm@lists.cs.columbia.edu, will@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, christoffer.dall@arm.com, pbonzini@redhat.com, drjones@redhat.com, oupton@google.com, qperret@google.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Fuad, On Mon, 23 Aug 2021 11:21:05 +0100, Fuad Tabba wrote: > > Hi Marc, > > On Thu, Aug 19, 2021 at 3:36 PM Marc Zyngier wrote: > > I realised that I wasn't very forthcoming here. I've decided to put > > the code where my mouth is and pushed out a branch [1] with your first > > 10 patches, followed by my own take on this particular problem. It > > compiles, and even managed to boot a Debian guest on a nVHE box. > > > > As you can see, most of the early exit handling is now moved to > > specific handlers, unifying the handling. For the protected mode, you > > can provide your own handler array (just hack > > kvm_get_exit_handler_array() to return something else), which will do > > the right thing as long as you call into the existing handlers first. > > When it comes to the ELR/SPSR handling, it is better left to the > > individual handlers (which we already do in some cases, see how we > > skip instructions, for example). > > Please let me know what you think. > > Thanks a lot for this and sorry for being late to reply. I've been > travelling. No worries, it should be me who apologies for getting to this that late. > I think that your proposal looks great. All handling is consolidated > now and handling for protected VMs can just be added on top. There are > some small issues with what parameters we need (e.g., passing struct > kvm to kvm_get_exit_handler_array), but I will sort them out and > submit them in the next round. OK. Please base these changes on top of the three patches in my branch, which I will update with actual commit messages. Thanks, M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2ED3C4338F for ; Mon, 23 Aug 2021 12:10:27 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 36BAC6137F for ; Mon, 23 Aug 2021 12:10:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 36BAC6137F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B30784B226; Mon, 23 Aug 2021 08:10:26 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ic-uMPLecZpo; Mon, 23 Aug 2021 08:10:21 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 846E44B1AC; Mon, 23 Aug 2021 08:10:21 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E66DF4B1AC for ; Mon, 23 Aug 2021 08:10:19 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KuEv83Dv8qBC for ; Mon, 23 Aug 2021 08:10:15 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 6A4794B1A3 for ; Mon, 23 Aug 2021 08:10:15 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 63CB26135F; Mon, 23 Aug 2021 12:10:14 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mI8mK-006ej3-DI; Mon, 23 Aug 2021 13:10:12 +0100 Date: Mon, 23 Aug 2021 13:10:11 +0100 Message-ID: <875yvwqs4c.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Subject: Re: [PATCH v4 11/15] KVM: arm64: Guest exit handlers for nVHE hyp In-Reply-To: References: <20210817081134.2918285-1-tabba@google.com> <20210817081134.2918285-12-tabba@google.com> <87fsv6snup.wl-maz@kernel.org> <87zgtdqz77.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tabba@google.com, kvmarm@lists.cs.columbia.edu, will@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, christoffer.dall@arm.com, pbonzini@redhat.com, drjones@redhat.com, oupton@google.com, qperret@google.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kernel-team@android.com, kvm@vger.kernel.org, pbonzini@redhat.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Fuad, On Mon, 23 Aug 2021 11:21:05 +0100, Fuad Tabba wrote: > > Hi Marc, > > On Thu, Aug 19, 2021 at 3:36 PM Marc Zyngier wrote: > > I realised that I wasn't very forthcoming here. I've decided to put > > the code where my mouth is and pushed out a branch [1] with your first > > 10 patches, followed by my own take on this particular problem. It > > compiles, and even managed to boot a Debian guest on a nVHE box. > > > > As you can see, most of the early exit handling is now moved to > > specific handlers, unifying the handling. For the protected mode, you > > can provide your own handler array (just hack > > kvm_get_exit_handler_array() to return something else), which will do > > the right thing as long as you call into the existing handlers first. > > When it comes to the ELR/SPSR handling, it is better left to the > > individual handlers (which we already do in some cases, see how we > > skip instructions, for example). > > Please let me know what you think. > > Thanks a lot for this and sorry for being late to reply. I've been > travelling. No worries, it should be me who apologies for getting to this that late. > I think that your proposal looks great. All handling is consolidated > now and handling for protected VMs can just be added on top. There are > some small issues with what parameters we need (e.g., passing struct > kvm to kvm_get_exit_handler_array), but I will sort them out and > submit them in the next round. OK. Please base these changes on top of the three patches in my branch, which I will update with actual commit messages. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95B00C4338F for ; Mon, 23 Aug 2021 12:12:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 595C46138F for ; Mon, 23 Aug 2021 12:12:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 595C46138F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5zEZNEw5PPnJPPSiB2SMVPdyiMuDLkCw46vSiwqnLS8=; b=sf7/2EkTUGe3bm 7UiTSV7VUyyv/SsmwcMeJmLixQgrtRB397YlkqntqJ084Eu0KLb2LVMpDYOG0i9gJBnjt3w6AAiX4 ncJBwpD6J6/vLyEKVZRN7mWmejNWcKNyK1jWIJ+gCTUHyDKHqdB5S249k8Ed/qoufK6Ic6Vq+P4y0 Ca4CFcXl0x3MBkq8cVloKJacn2ptmh/YNIm0f8rQgM6eTLKcPXx2BnF36pf3Ex3xABaeU/3joGOQu 839rvO9C2eV5xD7fvpZkiF0r5KvRj+9iN83Vpio2egSF26ivyq184SaJFdM4L+0PeRNq74fiscjM3 sQZjCOfY+Hq085WzAv9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mI8ml-00GhPp-NQ; Mon, 23 Aug 2021 12:10:40 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mI8mW-00GhK2-MW for linux-arm-kernel@lists.infradead.org; Mon, 23 Aug 2021 12:10:26 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 63CB26135F; Mon, 23 Aug 2021 12:10:14 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mI8mK-006ej3-DI; Mon, 23 Aug 2021 13:10:12 +0100 Date: Mon, 23 Aug 2021 13:10:11 +0100 Message-ID: <875yvwqs4c.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: kvmarm@lists.cs.columbia.edu, will@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, christoffer.dall@arm.com, pbonzini@redhat.com, drjones@redhat.com, oupton@google.com, qperret@google.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com Subject: Re: [PATCH v4 11/15] KVM: arm64: Guest exit handlers for nVHE hyp In-Reply-To: References: <20210817081134.2918285-1-tabba@google.com> <20210817081134.2918285-12-tabba@google.com> <87fsv6snup.wl-maz@kernel.org> <87zgtdqz77.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tabba@google.com, kvmarm@lists.cs.columbia.edu, will@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, christoffer.dall@arm.com, pbonzini@redhat.com, drjones@redhat.com, oupton@google.com, qperret@google.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210823_051024_813025_A3F1B7A9 X-CRM114-Status: GOOD ( 30.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Fuad, On Mon, 23 Aug 2021 11:21:05 +0100, Fuad Tabba wrote: > > Hi Marc, > > On Thu, Aug 19, 2021 at 3:36 PM Marc Zyngier wrote: > > I realised that I wasn't very forthcoming here. I've decided to put > > the code where my mouth is and pushed out a branch [1] with your first > > 10 patches, followed by my own take on this particular problem. It > > compiles, and even managed to boot a Debian guest on a nVHE box. > > > > As you can see, most of the early exit handling is now moved to > > specific handlers, unifying the handling. For the protected mode, you > > can provide your own handler array (just hack > > kvm_get_exit_handler_array() to return something else), which will do > > the right thing as long as you call into the existing handlers first. > > When it comes to the ELR/SPSR handling, it is better left to the > > individual handlers (which we already do in some cases, see how we > > skip instructions, for example). > > Please let me know what you think. > > Thanks a lot for this and sorry for being late to reply. I've been > travelling. No worries, it should be me who apologies for getting to this that late. > I think that your proposal looks great. All handling is consolidated > now and handling for protected VMs can just be added on top. There are > some small issues with what parameters we need (e.g., passing struct > kvm to kvm_get_exit_handler_array), but I will sort them out and > submit them in the next round. OK. Please base these changes on top of the three patches in my branch, which I will update with actual commit messages. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel