From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 7783B89F3C
 for <igt-dev@lists.freedesktop.org>; Thu,  5 Aug 2021 03:06:13 +0000 (UTC)
Date: Wed, 04 Aug 2021 20:06:11 -0700
Message-ID: <875ywktwt8.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <20210726200026.4815-14-zbigniew.kempczynski@intel.com>
References: <20210726200026.4815-1-zbigniew.kempczynski@intel.com>
 <20210726200026.4815-14-zbigniew.kempczynski@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: quoted-printable
Subject: Re: [igt-dev] [PATCH i-g-t v3 13/52] tests/gem_ctx_exec: Adopt to
 use allocator
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org, Petri Latvala <petri.latvala@intel.com>
List-ID: <igt-dev@lists.freedesktop.org>

On Mon, 26 Jul 2021 12:59:47 -0700, Zbigniew Kempczy=F1ski wrote:

With the couple of nits below addressed, this is:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> @@ -345,10 +354,14 @@ static void close_race(int i915)
>	const intel_ctx_t **ctx;
>	uint32_t *ctx_id;
>	igt_spin_t *spin;
> +	uint64_t ahnd;
>
>	/* Check we can execute a polling spinner */
>	base_ctx =3D intel_ctx_create(i915, NULL);
> -	igt_spin_free(i915, igt_spin_new(i915, .ctx =3D base_ctx,
> +	ahnd =3D get_reloc_ahnd(i915, base_ctx->id);
> +	igt_spin_free(i915, igt_spin_new(i915,
> +					 .ahnd =3D ahnd,
> +					 .ctx =3D base_ctx,
>					 .flags =3D IGT_SPIN_POLL_RUN));

Missing put_ahnd here I think.

> @@ -403,6 +419,7 @@ static void close_race(int i915)
>		}
>
>		igt_spin_free(i915, spin);
> +		put_ahnd(ahnd);

nit: prefer to move it next to intel_ctx_destroy.

> @@ -474,11 +491,22 @@ igt_main
>	igt_subtest("basic-nohangcheck")
>		nohangcheck_hostile(fd);
>
> -	igt_subtest("basic-close-race")
> -		close_race(fd);
> +	igt_subtest_group {
> +		igt_fixture {
> +			intel_allocator_multiprocess_start();
> +		}
> +
> +		igt_subtest("basic-close-race")
> +				close_race(fd);

indent