From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Arend van Spriel <aspriel@gmail.com>,
Matthias Brugger <mbrugger@suse.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Chi-hsien Lin <chi-hsien.lin@infineon.com>,
Wright Feng <wright.feng@infineon.com>,
Chung-hsien Hsu <chung-hsien.hsu@infineon.com>,
Hans deGoede <hdegoede@redhat.com>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] brcmfmac: fix a loop exit condition
Date: Tue, 15 Jun 2021 16:45:11 +0300 [thread overview]
Message-ID: <875yyfjl7c.fsf@codeaurora.org> (raw)
In-Reply-To: <20210615125259.GB1901@kadam> (Dan Carpenter's message of "Tue, 15 Jun 2021 15:52:59 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> On Tue, Jun 15, 2021 at 10:26:56AM +0000, Kalle Valo wrote:
>> Dan Carpenter <dan.carpenter@oracle.com> wrote:
>>
>> > This code is supposed to loop over the whole board_type[] string. The
>> > current code kind of works just because ascii values start 97 and the
>> > string is likely shorter than that so it will break when we hit the NUL
>> > terminator. But really the condition should be "i < len" instead of
>> > "i < board_type[i]".
>> >
>> > Fixes: 29e354ebeeec ("brcmfmac: Transform compatible string for FW loading")
>> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>> > Reviewed-by: Matthias Brugger <mbrugger@suse.com>
>>
>> There was talk about v2, but I don't see it in the patchwork.
>
> Ah, crap. I started to debug Smatch to find out why it wasn't warning
> about some of these bugs and I got a bit carried away writing Smatch
> code and forgot to come back to this.
>
> I will send it tomorrow.
No worries, take your time :) I just wanted to remind about this, or see
if patchwork or the mailing list have lost patches again (which has
happened in the past).
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-06-15 13:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 11:46 [PATCH] brcmfmac: fix a loop exit condition Dan Carpenter
2021-04-23 11:56 ` Matthias Brugger
2021-04-23 11:59 ` Johannes Berg
2021-04-23 12:11 ` Dan Carpenter
2021-04-23 12:20 ` Christophe JAILLET
2021-04-23 12:54 ` Johannes Berg
2021-05-08 11:02 ` Dan Carpenter
2021-06-15 10:26 ` Kalle Valo
[not found] ` <20210615102656.DBB04C43143@smtp.codeaurora.org>
2021-06-15 12:52 ` Dan Carpenter
2021-06-15 13:45 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yyfjl7c.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=chi-hsien.lin@infineon.com \
--cc=chung-hsien.hsu@infineon.com \
--cc=dan.carpenter@oracle.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=hdegoede@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=wright.feng@infineon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.