From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA7986E45D for ; Thu, 10 Jun 2021 05:20:33 +0000 (UTC) Date: Wed, 09 Jun 2021 22:15:05 -0700 Message-ID: <875yymnvvq.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20210609173903.249112-36-jason@jlekstrand.net> References: <20210609173632.248880-1-jason@jlekstrand.net> <20210609173903.249112-36-jason@jlekstrand.net> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [igt-dev] [PATCH i-g-t 85/93] igt/dummyload: Require an intel_ctx_t for POLL_RUN and !ALL_ENGINES List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Jason Ekstrand Cc: igt-dev@lists.freedesktop.org List-ID: On Wed, 09 Jun 2021 10:38:55 -0700, Jason Ekstrand wrote: > > diff --git a/lib/igt_dummyload.c b/lib/igt_dummyload.c > index b0a7b361..25e49de4 100644 > --- a/lib/igt_dummyload.c > +++ b/lib/igt_dummyload.c > @@ -421,22 +421,12 @@ igt_spin_factory(int fd, const struct igt_spin_factory *opts) > { > igt_spin_t *spin; > > - if (opts->engine != ALL_ENGINES) { > - struct intel_execution_engine2 e; > - int class; > - > - if (opts->ctx) { > - class = opts->ctx->cfg.engines[opts->engine].engine_class; > - } else if (!gem_context_lookup_engine(fd, opts->engine, > - opts->ctx_id, &e)) { With this I believe the ctx_id field can also be deleted from 'struct igt_spin_factory' (and also a couple of other statements still using opts->ctx_id). _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev