From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] package/pkg-cmake.mk: don't unconditionally set CMAKE_CXX_COMPILER
Date: Sun, 04 Apr 2021 11:27:34 +0200 [thread overview]
Message-ID: <875z122yd5.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20210402163343.1254491-2-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Fri, 2 Apr 2021 18:33:42 +0200")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Don't unconditionally set CMAKE_CXX_COMPILER as it will raise a build
> failure on qpid-proton because "if the toolchain specifies a value for
> CMAKE_CXX_COMPILER, then CMake assumes the compiler works and goes
> straight ahead trying to use it":
> https://cmake.org/cmake/help/latest/module/CheckLanguage.html
> https://issues.apache.org/jira/browse/PROTON-2365
> Fixes:
> - http://autobuild.buildroot.org/results/05f344151100219c159ca4d466a453df96bf07fa
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2020.02.x, 2020.11.x and 2021.02.x, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2021-04-04 9:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 16:33 [Buildroot] [PATCH 1/3] package/qpid-proton: fix build without threads Fabrice Fontaine
2021-04-02 16:33 ` [Buildroot] [PATCH 2/3] package/pkg-cmake.mk: don't unconditionally set CMAKE_CXX_COMPILER Fabrice Fontaine
2021-04-02 21:52 ` Yann E. MORIN
2021-04-04 9:27 ` Peter Korsgaard [this message]
2021-04-02 16:33 ` [Buildroot] [PATCH 3/3] package/qpid-proton: fix build without C++ Fabrice Fontaine
2021-04-02 21:54 ` Yann E. MORIN
2021-04-02 21:54 ` [Buildroot] [PATCH 1/3] package/qpid-proton: fix build without threads Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z122yd5.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.