From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E7FEC433C1 for ; Wed, 31 Mar 2021 08:00:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10886619DB for ; Wed, 31 Mar 2021 08:00:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234039AbhCaH7s (ORCPT ); Wed, 31 Mar 2021 03:59:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234098AbhCaH7n (ORCPT ); Wed, 31 Mar 2021 03:59:43 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE8FAC061574 for ; Wed, 31 Mar 2021 00:59:42 -0700 (PDT) From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1617177580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EwENOV5fEtmm72Pvhge8smr8aYXEWHQVNQRqr1NurZ8=; b=HgYwf+F5t8/gQgaF2YZ17DNXo2yFb0pVTZn0ZbtZzqd8Y8Sahi6vDVeZ0yDH70XJiw0lYy IK406t8beuNJxH/nzZQzcWA/+RKwjqyUs73YOdDIcQaxefWARdaqrvvi8vrYEBXmgHaHr+ /FYl89dM6MubMB7wiK1nxPRKCKwPD2bGb5i9UPJU7tgIY2LiqAVuAwuunDsFRrSDNh0I4v WlfdgErhyH1WDEQToFUy5Z/KFpxMkU1s6CQxFPHluQW67Vj+WuamrzwdOP99FhY4iMolJ5 ehk4vzv9DwvPis/DM3Em1aEAz+5bwH2MpcfVmgMKTdLWSbSGGgbu/DijF3vdww== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1617177580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EwENOV5fEtmm72Pvhge8smr8aYXEWHQVNQRqr1NurZ8=; b=OFsxY0ULFZzlVDBhGsXuic6UtSXoqjsWNTcAn2ba/w5Yp2FKfdTtXYRsqVzLZI5u8tMC41 ZAd55frkyv+omGAQ== To: Petr Mladek Cc: Sergey Senozhatsky , Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Eric Biederman , Christophe Leroy , Nicholas Piggin , Alistair Popple , Jordan Niethe , Peter Zijlstra , "Aneesh Kumar K.V" , Andrew Morton , Kees Cook , Tiezhu Yang , Alexey Kardashevskiy , Yue Hu , Rafael Aquini , "Guilherme G. Piccoli" , "Paul E. McKenney" , linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org Subject: Re: [PATCH printk v2 2/5] printk: remove safe buffers In-Reply-To: <20210330153512.1182-3-john.ogness@linutronix.de> References: <20210330153512.1182-1-john.ogness@linutronix.de> <20210330153512.1182-3-john.ogness@linutronix.de> Date: Wed, 31 Mar 2021 09:59:39 +0200 Message-ID: <875z17vjmc.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-03-30, John Ogness wrote: > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > index e971c0a9ec9e..f090d6a1b39e 100644 > --- a/kernel/printk/printk.c > +++ b/kernel/printk/printk.c > @@ -1772,16 +1759,21 @@ static struct task_struct *console_owner; > static bool console_waiter; >=20=20 > /** > - * console_lock_spinning_enable - mark beginning of code where another > + * console_lock_spinning_enable_irqsave - mark beginning of code where a= nother > * thread might safely busy wait > * > * This basically converts console_lock into a spinlock. This marks > * the section where the console_lock owner can not sleep, because > * there may be a waiter spinning (like a spinlock). Also it must be > * ready to hand over the lock at the end of the section. > + * > + * This disables interrupts because the hand over to a waiter must not be > + * interrupted until the hand over is completed (@console_waiter is clea= red). > */ > -static void console_lock_spinning_enable(void) > +static void console_lock_spinning_enable_irqsave(unsigned long *flags) I missed the prototype change for the !CONFIG_PRINTK case, resulting in: linux/kernel/printk/printk.c:2707:3: error: implicit declaration of functio= n =E2=80=98console_lock_spinning_enable_irqsave=E2=80=99; did you mean =E2= =80=98console_lock_spinning_enable=E2=80=99? [-Werror=3Dimplicit-function-d= eclaration] console_lock_spinning_enable_irqsave(&flags); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ console_lock_spinning_enable Will be fixed for v3. (I have now officially added !CONFIG_PRINTK to my CI tests.) John Ogness From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83E35C433C1 for ; Wed, 31 Mar 2021 08:00:25 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12A56619CF for ; Wed, 31 Mar 2021 08:00:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12A56619CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4F9Jdg3wNVz3c5V for ; Wed, 31 Mar 2021 19:00:23 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=HgYwf+F5; dkim=fail reason="signature verification failed" header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=OFsxY0UL; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linutronix.de (client-ip=2a0a:51c0:0:12e:550::1; helo=galois.linutronix.de; envelope-from=john.ogness@linutronix.de; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=HgYwf+F5; dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=OFsxY0UL; dkim-atps=neutral Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4F9Jcz5fxGz3049 for ; Wed, 31 Mar 2021 18:59:47 +1100 (AEDT) From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1617177580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EwENOV5fEtmm72Pvhge8smr8aYXEWHQVNQRqr1NurZ8=; b=HgYwf+F5t8/gQgaF2YZ17DNXo2yFb0pVTZn0ZbtZzqd8Y8Sahi6vDVeZ0yDH70XJiw0lYy IK406t8beuNJxH/nzZQzcWA/+RKwjqyUs73YOdDIcQaxefWARdaqrvvi8vrYEBXmgHaHr+ /FYl89dM6MubMB7wiK1nxPRKCKwPD2bGb5i9UPJU7tgIY2LiqAVuAwuunDsFRrSDNh0I4v WlfdgErhyH1WDEQToFUy5Z/KFpxMkU1s6CQxFPHluQW67Vj+WuamrzwdOP99FhY4iMolJ5 ehk4vzv9DwvPis/DM3Em1aEAz+5bwH2MpcfVmgMKTdLWSbSGGgbu/DijF3vdww== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1617177580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EwENOV5fEtmm72Pvhge8smr8aYXEWHQVNQRqr1NurZ8=; b=OFsxY0ULFZzlVDBhGsXuic6UtSXoqjsWNTcAn2ba/w5Yp2FKfdTtXYRsqVzLZI5u8tMC41 ZAd55frkyv+omGAQ== To: Petr Mladek Subject: Re: [PATCH printk v2 2/5] printk: remove safe buffers In-Reply-To: <20210330153512.1182-3-john.ogness@linutronix.de> References: <20210330153512.1182-1-john.ogness@linutronix.de> <20210330153512.1182-3-john.ogness@linutronix.de> Date: Wed, 31 Mar 2021 09:59:39 +0200 Message-ID: <875z17vjmc.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sergey Senozhatsky , Alexey Kardashevskiy , Paul Mackerras , Tiezhu Yang , Rafael Aquini , "Aneesh Kumar K.V" , Peter Zijlstra , Yue Hu , Jordan Niethe , Kees Cook , "Paul E. McKenney" , Alistair Popple , "Guilherme G. Piccoli" , Nicholas Piggin , Steven Rostedt , Thomas Gleixner , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky , Eric Biederman , Andrew Morton , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 2021-03-30, John Ogness wrote: > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > index e971c0a9ec9e..f090d6a1b39e 100644 > --- a/kernel/printk/printk.c > +++ b/kernel/printk/printk.c > @@ -1772,16 +1759,21 @@ static struct task_struct *console_owner; > static bool console_waiter; >=20=20 > /** > - * console_lock_spinning_enable - mark beginning of code where another > + * console_lock_spinning_enable_irqsave - mark beginning of code where a= nother > * thread might safely busy wait > * > * This basically converts console_lock into a spinlock. This marks > * the section where the console_lock owner can not sleep, because > * there may be a waiter spinning (like a spinlock). Also it must be > * ready to hand over the lock at the end of the section. > + * > + * This disables interrupts because the hand over to a waiter must not be > + * interrupted until the hand over is completed (@console_waiter is clea= red). > */ > -static void console_lock_spinning_enable(void) > +static void console_lock_spinning_enable_irqsave(unsigned long *flags) I missed the prototype change for the !CONFIG_PRINTK case, resulting in: linux/kernel/printk/printk.c:2707:3: error: implicit declaration of functio= n =E2=80=98console_lock_spinning_enable_irqsave=E2=80=99; did you mean =E2= =80=98console_lock_spinning_enable=E2=80=99? [-Werror=3Dimplicit-function-d= eclaration] console_lock_spinning_enable_irqsave(&flags); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ console_lock_spinning_enable Will be fixed for v3. (I have now officially added !CONFIG_PRINTK to my CI tests.) John Ogness From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRVlN-005so2-9n for kexec@lists.infradead.org; Wed, 31 Mar 2021 07:59:43 +0000 From: John Ogness Subject: Re: [PATCH printk v2 2/5] printk: remove safe buffers In-Reply-To: <20210330153512.1182-3-john.ogness@linutronix.de> References: <20210330153512.1182-1-john.ogness@linutronix.de> <20210330153512.1182-3-john.ogness@linutronix.de> Date: Wed, 31 Mar 2021 09:59:39 +0200 Message-ID: <875z17vjmc.fsf@jogness.linutronix.de> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Petr Mladek Cc: Sergey Senozhatsky , Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Eric Biederman , Christophe Leroy , Nicholas Piggin , Alistair Popple , Jordan Niethe , Peter Zijlstra , "Aneesh Kumar K.V" , Andrew Morton , Kees Cook , Tiezhu Yang , Alexey Kardashevskiy , Yue Hu , Rafael Aquini , "Guilherme G. Piccoli" , "Paul E. McKenney" , linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org T24gMjAyMS0wMy0zMCwgSm9obiBPZ25lc3MgPGpvaG4ub2duZXNzQGxpbnV0cm9uaXguZGU+IHdy b3RlOgo+IGRpZmYgLS1naXQgYS9rZXJuZWwvcHJpbnRrL3ByaW50ay5jIGIva2VybmVsL3ByaW50 ay9wcmludGsuYwo+IGluZGV4IGU5NzFjMGE5ZWM5ZS4uZjA5MGQ2YTFiMzllIDEwMDY0NAo+IC0t LSBhL2tlcm5lbC9wcmludGsvcHJpbnRrLmMKPiArKysgYi9rZXJuZWwvcHJpbnRrL3ByaW50ay5j Cj4gQEAgLTE3NzIsMTYgKzE3NTksMjEgQEAgc3RhdGljIHN0cnVjdCB0YXNrX3N0cnVjdCAqY29u c29sZV9vd25lcjsKPiAgc3RhdGljIGJvb2wgY29uc29sZV93YWl0ZXI7Cj4gIAo+ICAvKioKPiAt ICogY29uc29sZV9sb2NrX3NwaW5uaW5nX2VuYWJsZSAtIG1hcmsgYmVnaW5uaW5nIG9mIGNvZGUg d2hlcmUgYW5vdGhlcgo+ICsgKiBjb25zb2xlX2xvY2tfc3Bpbm5pbmdfZW5hYmxlX2lycXNhdmUg LSBtYXJrIGJlZ2lubmluZyBvZiBjb2RlIHdoZXJlIGFub3RoZXIKPiAgICoJdGhyZWFkIG1pZ2h0 IHNhZmVseSBidXN5IHdhaXQKPiAgICoKPiAgICogVGhpcyBiYXNpY2FsbHkgY29udmVydHMgY29u c29sZV9sb2NrIGludG8gYSBzcGlubG9jay4gVGhpcyBtYXJrcwo+ICAgKiB0aGUgc2VjdGlvbiB3 aGVyZSB0aGUgY29uc29sZV9sb2NrIG93bmVyIGNhbiBub3Qgc2xlZXAsIGJlY2F1c2UKPiAgICog dGhlcmUgbWF5IGJlIGEgd2FpdGVyIHNwaW5uaW5nIChsaWtlIGEgc3BpbmxvY2spLiBBbHNvIGl0 IG11c3QgYmUKPiAgICogcmVhZHkgdG8gaGFuZCBvdmVyIHRoZSBsb2NrIGF0IHRoZSBlbmQgb2Yg dGhlIHNlY3Rpb24uCj4gKyAqCj4gKyAqIFRoaXMgZGlzYWJsZXMgaW50ZXJydXB0cyBiZWNhdXNl IHRoZSBoYW5kIG92ZXIgdG8gYSB3YWl0ZXIgbXVzdCBub3QgYmUKPiArICogaW50ZXJydXB0ZWQg dW50aWwgdGhlIGhhbmQgb3ZlciBpcyBjb21wbGV0ZWQgKEBjb25zb2xlX3dhaXRlciBpcyBjbGVh cmVkKS4KPiAgICovCj4gLXN0YXRpYyB2b2lkIGNvbnNvbGVfbG9ja19zcGlubmluZ19lbmFibGUo dm9pZCkKPiArc3RhdGljIHZvaWQgY29uc29sZV9sb2NrX3NwaW5uaW5nX2VuYWJsZV9pcnFzYXZl KHVuc2lnbmVkIGxvbmcgKmZsYWdzKQoKSSBtaXNzZWQgdGhlIHByb3RvdHlwZSBjaGFuZ2UgZm9y IHRoZSAhQ09ORklHX1BSSU5USyBjYXNlLCByZXN1bHRpbmcgaW46CgpsaW51eC9rZXJuZWwvcHJp bnRrL3ByaW50ay5jOjI3MDc6MzogZXJyb3I6IGltcGxpY2l0IGRlY2xhcmF0aW9uIG9mIGZ1bmN0 aW9uIOKAmGNvbnNvbGVfbG9ja19zcGlubmluZ19lbmFibGVfaXJxc2F2ZeKAmTsgZGlkIHlvdSBt ZWFuIOKAmGNvbnNvbGVfbG9ja19zcGlubmluZ19lbmFibGXigJk/IFstV2Vycm9yPWltcGxpY2l0 LWZ1bmN0aW9uLWRlY2xhcmF0aW9uXQogICBjb25zb2xlX2xvY2tfc3Bpbm5pbmdfZW5hYmxlX2ly cXNhdmUoJmZsYWdzKTsKICAgXn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+CiAg IGNvbnNvbGVfbG9ja19zcGlubmluZ19lbmFibGUKCldpbGwgYmUgZml4ZWQgZm9yIHYzLgoKKEkg aGF2ZSBub3cgb2ZmaWNpYWxseSBhZGRlZCAhQ09ORklHX1BSSU5USyB0byBteSBDSSB0ZXN0cy4p CgpKb2huIE9nbmVzcwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18Ka2V4ZWMgbWFpbGluZyBsaXN0CmtleGVjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9rZXhlYwo=