From: Philippe Gerum <rpm@xenomai.org>
To: "florian.bezdeka@siemens.com" <florian.bezdeka@siemens.com>
Cc: "jan.kiszka@siemens.com" <jan.kiszka@siemens.com>,
"xenomai@xenomai.org" <xenomai@xenomai.org>
Subject: Re: [PATCH 2/5] cobalt/kernel: y2038: convert struct timespec to timespec64
Date: Thu, 04 Mar 2021 10:44:20 +0100 [thread overview]
Message-ID: <875z271cej.fsf@xenomai.org> (raw)
In-Reply-To: <7200b2df730dc65a5ce7e531109b6ba663e88ae7.camel@siemens.com>
florian.bezdeka@siemens.com <florian.bezdeka@siemens.com> writes:
> On Sat, 2021-02-20 at 16:18 +0100, Philippe Gerum via Xenomai wrote:
> [snip]
>> +#if __BITS_PER_LONG == 64
>
> That might be a beginner question, but I'm learning from the best ;-)
>
> Do we really care about each single assignment (two per timespec) and
> each object on the stack that it is worth duplicating all this helpers?
> We could use the __BITS_PER_LONG == 32 version for both worlds,
> couldn't we?
Yes, this would work as well. I agree that the very limited gain is not
worth the code duplication.
--
Philippe.
next prev parent reply other threads:[~2021-03-04 9:44 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 15:18 [PATCH 1/5] cobalt/kernel: y2038: convert struct timeval to __kernel_old_timeval Philippe Gerum
2021-02-20 15:18 ` [PATCH 2/5] cobalt/kernel: y2038: convert struct timespec to timespec64 Philippe Gerum
2021-02-21 2:17 ` chensong
2021-02-21 15:27 ` Philippe Gerum
2021-02-22 1:04 ` chensong
2021-02-22 8:21 ` florian.bezdeka
2021-02-22 9:08 ` Philippe Gerum
2021-03-08 12:19 ` Jan Kiszka
2021-03-08 14:01 ` Philippe Gerum
2021-03-08 14:03 ` Jan Kiszka
2021-03-03 10:05 ` florian.bezdeka
2021-03-04 9:35 ` Philippe Gerum
2021-03-04 9:49 ` florian.bezdeka
2021-03-04 9:55 ` Philippe Gerum
2021-03-04 9:59 ` florian.bezdeka
2021-03-04 10:08 ` Philippe Gerum
2021-03-04 11:36 ` [y2038][RFC PATCH 0/2] Pattern for implementing y2038 syscalls Florian Bezdeka
2021-03-04 11:36 ` [y2038][RFC PATCH 1/2] y2038: Fixing the sem_timedwait syscall for 32 bit systems Florian Bezdeka
2021-03-04 15:11 ` Philippe Gerum
2021-03-04 15:22 ` florian.bezdeka
2021-03-04 15:42 ` Philippe Gerum
2021-03-08 17:02 ` [RFC PATCH v2 0/4] Pattern for implementing y2038 syscalls Florian Bezdeka
2021-03-08 17:02 ` [RFC PATCH v2 1/4] y2038: Fixing the sem_timedwait syscall for 32 bit systems Florian Bezdeka
2021-03-08 17:12 ` Jan Kiszka
2021-03-08 18:11 ` florian.bezdeka
2021-03-08 18:22 ` Jan Kiszka
2021-03-09 9:46 ` Philippe Gerum
2021-03-09 11:08 ` florian.bezdeka
2021-03-08 17:02 ` [RFC PATCH v2 2/4] y2038: Adding sem_timedwait_time64 Florian Bezdeka
2021-03-08 18:28 ` Jan Kiszka
2021-03-09 7:53 ` florian.bezdeka
2021-03-10 7:51 ` florian.bezdeka
2021-03-10 9:46 ` chensong
2021-03-08 17:02 ` [RFC PATCH v2 3/4] y2038: Add tests for the sc_cobalt_sem_timedwait_time64 syscall Florian Bezdeka
2021-03-08 18:35 ` Jan Kiszka
2021-03-09 8:00 ` florian.bezdeka
2021-03-08 17:02 ` [RFC PATCH v2 4/4] y2038: lib/cobalt: Add support of sc_cobalt_sem_timedwait_time64 Florian Bezdeka
2021-03-10 13:09 ` [y2038][PATCH v3 0/4] Pattern for implementing y2038 syscalls Florian Bezdeka
2021-03-10 13:09 ` [y2038][PATCH v3 1/4] y2038: Fixing the sem_timedwait syscall for 32 bit systems Florian Bezdeka
2021-03-10 13:09 ` [y2038][PATCH v3 2/4] y2038: Adding sem_timedwait64 Florian Bezdeka
2021-03-10 13:09 ` [y2038][PATCH v3 3/4] y2038: Add tests for the sc_cobalt_sem_timedwait64 syscall Florian Bezdeka
2021-03-10 13:09 ` [y2038][PATCH v3 4/4] y2038: lib/cobalt: Add support of sc_cobalt_sem_timedwait64 Florian Bezdeka
2021-03-11 2:38 ` chensong
2021-03-04 11:36 ` [y2038][RFC PATCH 2/2] y2038: Adding sem_timedwait_time64 Florian Bezdeka
2021-03-05 5:49 ` chensong
2021-03-05 6:36 ` florian.bezdeka
2021-03-05 7:42 ` chensong
2021-03-05 7:53 ` florian.bezdeka
2021-03-08 12:59 ` [PATCH 2/5] cobalt/kernel: y2038: convert struct timespec to timespec64 Jan Kiszka
2021-03-10 17:52 ` florian.bezdeka
2021-03-10 18:14 ` Philippe Gerum
2021-03-03 14:36 ` florian.bezdeka
2021-03-04 9:44 ` Philippe Gerum [this message]
2021-03-04 9:57 ` florian.bezdeka
2021-02-20 15:18 ` [PATCH 3/5] lib: y2038: convert to internal timespec type Philippe Gerum
2021-02-20 15:18 ` [PATCH 4/5] cobalt/kernel: y2038: convert struct itimerspec to itimerspec64 Philippe Gerum
2021-02-20 15:18 ` [PATCH 5/5] cobalt/kernel: y2038: convert struct timex to __kernel_timex Philippe Gerum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z271cej.fsf@xenomai.org \
--to=rpm@xenomai.org \
--cc=florian.bezdeka@siemens.com \
--cc=jan.kiszka@siemens.com \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.