From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4204AC433E0 for ; Tue, 14 Jul 2020 09:17:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A52B21D7B for ; Tue, 14 Jul 2020 09:17:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QwDydsEn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A52B21D7B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jvH4B-0002xi-9u for qemu-devel@archiver.kernel.org; Tue, 14 Jul 2020 05:17:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jvH3a-0002RK-OP for qemu-devel@nongnu.org; Tue, 14 Jul 2020 05:16:58 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:34072 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jvH3Y-0007U5-DA for qemu-devel@nongnu.org; Tue, 14 Jul 2020 05:16:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594718215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oayqO/MMk57qVjUEFtglnMcOxakjJJRUN6A4iwy//8o=; b=QwDydsEnhmTY6lMJzmEP+828YZneoiLlBG+qMuHYZv2e31MDd8yp/rNPz38KxD3VEZra9H weBKYs0HGOAYDZhALm5P2w1+Ufvr3epY5tDqB5QLH8FvmtDNhdnaqzzx9KwL1txFhLZzpv XCztQyZDTrkwVmDHf7zndvJAhzbi22k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-116-L5HS5biONiqyci8PHAiyTw-1; Tue, 14 Jul 2020 05:16:53 -0400 X-MC-Unique: L5HS5biONiqyci8PHAiyTw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4E5FF1091; Tue, 14 Jul 2020 09:16:52 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-143.ams2.redhat.com [10.36.112.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3C93772E44; Tue, 14 Jul 2020 09:16:51 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id B84C11267F16; Tue, 14 Jul 2020 11:16:49 +0200 (CEST) From: Markus Armbruster To: Havard Skinnemoen Subject: Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj References: <20200709003608.3834629-1-hskinnemoen@google.com> <20200709003608.3834629-11-hskinnemoen@google.com> <109d52ed-65bf-0fcc-98f1-47b7a6671d0b@kaod.org> Date: Tue, 14 Jul 2020 11:16:49 +0200 In-Reply-To: (Havard Skinnemoen's message of "Mon, 13 Jul 2020 19:56:55 -0700") Message-ID: <875zaq78xq.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=205.139.110.120; envelope-from=armbru@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/14 01:42:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , QEMU Developers , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , CS20 KFTing , qemu-arm , =?utf-8?Q?C=C3=A9dric?= Le Goater , IS20 Avi Fishman Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Havard Skinnemoen writes: > On Mon, Jul 13, 2020 at 7:57 AM C=C3=A9dric Le Goater wrot= e: >> >> On 7/9/20 2:36 AM, Havard Skinnemoen wrote: >> > This allows these NPCM7xx-based boards to boot from a flash image, e.g= . >> > one built with OpenBMC. For example like this: >> > >> > IMAGE=3D${OPENBMC}/build/tmp/deploy/images/gsj/image-bmc >> > qemu-system-arm -machine quanta-gsj -nographic \ >> > -bios ~/qemu/bootrom/npcm7xx_bootrom.bin \ >> > -drive file=3D${IMAGE},if=3Dmtd,bus=3D0,unit=3D0,format=3Draw,sn= apshot=3Don >> > >> > Reviewed-by: Tyrone Ting >> > Signed-off-by: Havard Skinnemoen >> >> May be we don't need to create the flash object if dinfo is NULL. > > It's soldered on the board, so you can't really boot the board without > it. But if you think it's better to remove it altogether if we don't > have an image to load into it, I can do that. If a device is a fixed part of the physical board, it should be a fixed part of the virtual board, too. [...]