From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [RFC] drm: Do not call drm_probe_ddc() when connector force isn't specified Date: Fri, 07 Jun 2019 10:37:46 +0300 Message-ID: <875zph26d1.fsf@intel.com> References: <20190606073800.64781-1-harish.chegondi@intel.com> <87blzb0vwa.fsf@intel.com> <20190606213848.GA67746@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 95AE0899DB for ; Fri, 7 Jun 2019 07:34:44 +0000 (UTC) In-Reply-To: <20190606213848.GA67746@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Harish Chegondi Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAwNiBKdW4gMjAxOSwgSGFyaXNoIENoZWdvbmRpIDxoYXJpc2guY2hlZ29uZGlAaW50 ZWwuY29tPiB3cm90ZToKPiBPbiBUaHUsIEp1biAwNiwgMjAxOSBhdCAwMjo1Njo1M1BNICswMzAw LCBKYW5pIE5pa3VsYSB3cm90ZToKPj4gT24gVGh1LCAwNiBKdW4gMjAxOSwgRGFuaWVsIFZldHRl ciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90ZToKPj4gPiBPbiBUaHUsIEp1biA2LCAyMDE5IGF0IDk6 MzggQU0gSGFyaXNoIENoZWdvbmRpCj4+ID4gPGhhcmlzaC5jaGVnb25kaUBpbnRlbC5jb20+IHdy b3RlOgo+PiA+Pgo+PiA+PiBUaGlzIHdvdWxkIGFsbG93IHRoZSBFRElEIG92ZXJyaWRlIHRvIGJl IGhhbmRsZWQgY29ycmVjdGx5IGluCj4+ID4+IGRybV9kb19nZXRfZWRpZCgpIGZvciBjYXNlcyB3 aGVyZSBFRElEIGRhdGEgaXMgbWlzc2luZyBvciBjb3JydXB0Lgo+PiA+Pgo+PiA+PiBBbGwgZHJt X3Byb2JlX2RkYygpIGRvZXMgaXMgY2FsbCBkcm1fZG9fcHJvYmVfZGRjX2VkaWQoICwgLCAsIDEp Cj4+ID4+IHdoaWNoIHByb2JlcyB0aGUgZGlzcGxheSBieSByZWFkaW5nIDEgYnl0ZSBvZiBFRElE IGRhdGEgdmlhIEkyQy4KPj4gPj4gVGhpcyBwYXRjaCByZW1vdmVzIHRoZSBjYWxsIHRvIGRybV9w cm9iZV9kZGMoKSBmcm9tIGRybV9nZXRfZWRpZCgpCj4+ID4+IGJ1dCBkcm1fZ2V0X2VkaWQoKSBj YWxscyBkcm1fZG9fZ2V0X2VkaWQoKSB3aGljaCBmaXJzdCBoYW5kbGVzCj4+ID4+IHRoZSBFRElE IG92ZXJyaWRlIGNhc2UgYW5kIHRoZW4gY2FsbHMKPj4gPj4gZHJtX2RvX3Byb2JlX2RkY19lZGlk KCAsICwgLEVESURfTEVOR1RIKSB2aWEgZnVuY3Rpb24gcG9pbnRlcgo+PiA+PiBhcmd1bWVudCBn ZXRfZWRpZF9ibG9jay4gU28sIHRoZSBkaXNwbGF5IGRldmljZSBpcyBzdGlsbCBiZWluZwo+PiA+ PiBwcm9iZWQgYnkgcmVhZGluZyBFRElEX0xFTkdUSCBieXRlcyBvZiBFRElEIGRhdGEgdmlhIEky Qy4KPj4gPj4KPj4gPj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4+ ID4+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ PiA+PiBTaWduZWQtb2ZmLWJ5OiBIYXJpc2ggQ2hlZ29uZGkgPGhhcmlzaC5jaGVnb25kaUBpbnRl bC5jb20+Cj4+ID4+IFJlZmVyZW5jZXM6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hv d19idWcuY2dpP2lkPTEwNzU4Mwo+PiA+Cj4+ID4gU2luY2UgaXQncyBhIHJlZ3Jlc3Npb24gd2Ug bmVlZCB0byBhbm5vdGF0ZSB0aGlzIGNvcnJlY3RseSwgZm9yIHRoZQo+PiA+IG5leHQgdmVyc2lv biBwbGVhc2UgaW5jbHVkZToKPj4gPgo+PiA+IEZpeGVzOiA1M2ZkNDBhOTBmM2MgKCJkcm06IGhh bmRsZSBvdmVycmlkZSBhbmQgZmlybXdhcmUgRURJRCBhdAo+PiA+IGRybV9kb19nZXRfZWRpZCgp IGxldmVsIikKPj4gPiBDYzogPHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+ICMgdjQuMTUrCj4+ID4K Pj4gPiBTbyB0aGVyZSdzIGEgcGlsZSBtb3JlIGRybV9wcm9iZV9kZGMgY2FsbHMgYWxsIGFyb3Vu ZCBpbiBkcml2ZXJzLCBidXQKPj4gPiBJIHJldmlld2VkIHRoZW0gYWxsLCBhbmQgdGhleSdyZSBh bGwgaW4gLT5kZXRlY3QgY2FsbGJhY2tzLiBTbyBub3QKPj4gPiBhZmZlY3RpbmcgdGhlIHJlZ3Jl c3Npb24gd2UncmUgZGlzY3Vzc2luZyBoZXJlLiBMb29raW5nIGF0Cj4+ID4gZHJtX2RvX2dldF9l ZGlkIHRoaXMgc2hvdWxkIGFsc28gbm90IHJlc3VsdCBpbiBtb3JlIGZhaWx1cmVzLiBUaGUgb25s eQo+PiA+IHRoaW5nIHRoaXMgY2hhbmdlcyBpcyB0aGF0IGRybV9kb19nZXRfZWRpZCB3aWxsIHJl dHJ5IGEgYnVuY2ggbW9yZQo+PiA+IHRpbWVzIGlmIG5vdGhpbmcgaXMgY29ubmVjdGVkICg0IHRp bWVzLCBpbnN0ZWFkIG9mIGp1c3QgdGhlIG9uZSBwcm9iZQo+PiA+IHRoYXQgZHJtX3Byb2JlX2Rk YyBkb2VzKS4gSSBndWVzcyB3ZSBjYW4gcmVzdG9yZSB0aGF0IGlmIGFueW9uZSBjYXJlcywKPj4g PiBzaG91bGQgYXQgbGVhc3QgbWVudGlvbiBpdCBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuCj4+ID4K Pj4gPiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4K Pj4gCj4+IExpa2UgSSBleHBsYWluZWQgaW4gbXkgcmVwbHksIHRoaXMgZXNzZW50aWFsbHkgbWFr ZXMgb3ZlcnJpZGUvZmlybXdhcmUKPj4gRURJRCBhIGNvbm5lY3RvciBmb3JjZSBmb3IgdGhlIGNh c2Ugd2hlcmUgaG90cGx1ZyBkZXRlY3QgaXNuJ3QgdXNlZCBvcgo+PiByZWxpYWJsZS4gVGhhdCdz IGEgcmVncmVzc2lvbiBmb3IgYW5vdGhlciBzZXQgb2YgcGVvcGxlLi4uCj4+IAo+PiBCUiwKPj4g SmFuaS4KPgo+IEhpIEphbmksCj4KPiBDYW4geW91IHBsZWFzZSBnaXZlIG1vcmUgZGV0YWlscyBv biB3aGljaCByZWdyZXNzaW9uIHRoaXMgcGF0Y2ggbWF5Cj4gY2F1c2UuIEFueSBzcGVjaWZpYyB0 ZXN0IHNldHVwIGFuZCBJR1QgdGVzdCB3b3VsZCBiZSBoZWxwZnVsLgo+IEkgd2lsbCByZS13b3Jr IG15IHBhdGNoIHRvIG1ha2Ugc3VyZSBpdCBkb2Vzbid0IGNhdXNlIGFueSByZWdyZXNzaW9uLgo+ IFRoZSBDSSBCQVQgcmVwb3J0IGRpZG4ndCBpbmRpY2F0ZSBhbnkgcmVncmVzc2lvbnMgZm9yIHRo aXMgcGF0Y2guCgpkcm1fZ2V0X2VkaWQoKSBpcyB1c2VkIGFsbCBvdmVyIHRoZSBwbGFjZSB0byBk ZXRlY3QgaWYgdGhlcmUncyBhCmRpc3BsYXkuCgpJZiB5b3UgcmVtb3ZlIGRybV9wcm9iZV9kZGMo KSwgeW91IHB1c2ggZG93biB0aGUgZGV0ZWN0aW9uIHRvCmRybV9kb19nZXRfZWRpZCgpLgoKSWYg eW91IHVzZSBvdmVycmlkZSBvciBmaXJtd2FyZSBFRElEIChkZWJ1Z2ZzIG9yIGRybS5lZGlkX2Zp cm13YXJlCnBhcmFtZXRlciByZXNwZWN0aXZlbHkpIHRoZXJlIGlzIG5vIGRldGVjdGlvbiBpbiBk cm1fZG9fZ2V0X2VkaWQoKS4gSXQKd2lsbCBhbHdheXMgcmV0dXJuIG5vbi1OVUxMIGR1ZSB0byB0 aGUgb3ZlcnJpZGUvZmlybXdhcmUgRURJRC4KCkVmZmVjdGl2ZWx5IHRoaXMgY29uZmxhdGVzIG92 ZXJyaWRlL2Zpcm13YXJlIEVESUQgYW5kIGNvbm5lY3RvciBmb3JjaW5nLAphbmQgbG9zZXMgdGhl IGFiaWxpdHkgdG8gZGV0ZWN0IGRpc3BsYXlzIHVzaW5nIEREQyB3aXRoCm92ZXJyaWRlL2Zpcm13 YXJlIEVESUQuIFNvbWV0aGluZyB0aGF0IGhhcyB3b3JrZWQgZm9yIGVvbnMuCgpJbWFnaW5lIHlv dSBoYXZlIGEgZGlzcGxheSB3aXRoIEREQyBjb21tdW5pY2F0aW9ucyB3b3JraW5nIGJ1dCByZXR1 cm5pbmcKY29ycnVwdGVkIEVESUQuIFlvdSB3YW50IHRvIHByb3ZpZGUgdGhlIEVESUQgdmlhIGRy bS5lZGlkX2Zpcm13YXJlLCBidXQKeW91IGFsc28gd2FudCBkZXRlY3Rpb24gdmlhIEREQyB0byB3 b3JrLiBPdGhlcndpc2UsIHlvdSdkIHRlbGwgdGhlIHJlc3QKb2YgdGhlIHN0YWNrIHlvdSBoYXZl IGEgZGlzcGxheSBjb25uZWN0ZWQgZXZlbiB3aGVuIGl0J3MgdW5wbHVnZ2VkLgoKSW5jaWRlbnRh bGx5LCB0aGF0J3Mgb25lIGFzcGVjdCBvZiB0aGUgYnVnIHlvdSdyZSB0cnlpbmcgdG8gZml4LiBU aGVyZSwKRERDIGRvZXMgbm90IHdvcmsgYXQgYWxsLCBidXQgaG90cGx1ZyB3b3JrcyBmb3IgZGV0 ZWN0aW9uLiBJIHByb3Bvc2VkCnVzaW5nIGNvbm5lY3RvciBmb3JjaW5nIGFzIGEgcmVhc29uYWJs ZSB3b3JrYXJvdW5kLCBidXQgdW5mb3J0dW5hdGVseSBpdAphbHNvIGxlYWRzIHRvIGRpc3BsYXkg YmVpbmcgY29uc2lkZXJlZCBhbHdheXMgY29ubmVjdGVkLgoKSUdUIHdvbid0IGhlbHAgeW91IGhl cmUgYmVjYXVzZSB5b3UnZCBuZWVkIHNvbWV0aGluZyBlbXVsYXRpbmcgYnJva2VuCkREQyBhbmQg aG90cGx1Zy4KCgpCUiwKSmFuaS4KCgoKPgo+IFRoYW5rIFlvdQo+IEhhcmlzaC4KPgo+PiAKPj4g Cj4+ID4KPj4gPgo+PiA+PiAtLS0KPj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jIHwg MyAtLS0KPj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGRlbGV0aW9ucygtKQo+PiA+Pgo+PiA+PiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMgYi9kcml2ZXJzL2dwdS9kcm0v ZHJtX2VkaWQuYwo+PiA+PiBpbmRleCBkODdmNTc0ZmVlY2EuLjQxYzQyMDcwNjUzMiAxMDA2NDQK Pj4gPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMKPj4gPj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2RybV9lZGlkLmMKPj4gPj4gQEAgLTE3MjQsOSArMTcyNCw2IEBAIHN0cnVjdCBl ZGlkICpkcm1fZ2V0X2VkaWQoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPj4gPj4g ICAgICAgICBpZiAoY29ubmVjdG9yLT5mb3JjZSA9PSBEUk1fRk9SQ0VfT0ZGKQo+PiA+PiAgICAg ICAgICAgICAgICAgcmV0dXJuIE5VTEw7Cj4+ID4+Cj4+ID4+IC0gICAgICAgaWYgKGNvbm5lY3Rv ci0+Zm9yY2UgPT0gRFJNX0ZPUkNFX1VOU1BFQ0lGSUVEICYmICFkcm1fcHJvYmVfZGRjKGFkYXB0 ZXIpKQo+PiA+PiAtICAgICAgICAgICAgICAgcmV0dXJuIE5VTEw7Cj4+ID4KPj4gPiBUcm91Ymxl IGlzIHRoZXJlJ3MgYSBsb3QgbW9yZSBkcm1fcHJvYmVfZGRjIGNhbGxzIGFsbCBvdmVyLCBhbmQg YSBsb3Qgb2YgdGhlc2UKPj4gPj4gLQo+PiA+PiAgICAgICAgIGVkaWQgPSBkcm1fZG9fZ2V0X2Vk aWQoY29ubmVjdG9yLCBkcm1fZG9fcHJvYmVfZGRjX2VkaWQsIGFkYXB0ZXIpOwo+PiA+PiAgICAg ICAgIGlmIChlZGlkKQo+PiA+PiAgICAgICAgICAgICAgICAgZHJtX2dldF9kaXNwbGF5aWQoY29u bmVjdG9yLCBlZGlkKTsKPj4gPj4gLS0KPj4gPj4gMi4yMS4wCj4+ID4+Cj4+ID4+IF9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+ID4+IEludGVsLWdmeCBt YWlsaW5nIGxpc3QKPj4gPj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiA+PiBo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+ PiAKPj4gLS0gCj4+IEphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50 ZXIKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==