From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH 4/5] drm/i915: Move rawclck,
 power_domain and irq un/initialization from modeset functions
Date: Tue, 05 Mar 2019 13:42:36 +0200
Message-ID: <875zsxcztf.fsf@intel.com>
References: <20190302004935.28906-1-jose.souza@intel.com>
 <20190302004935.28906-4-jose.souza@intel.com>
 <20190304173423.GD20097@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 176F789262
 for <intel-gfx@lists.freedesktop.org>; Tue,  5 Mar 2019 11:40:35 +0000 (UTC)
In-Reply-To: <20190304173423.GD20097@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville =?utf-8?B?U3lyasOkbMOk?= <ville.syrjala@linux.intel.com>, =?utf-8?Q?Jos=C3=A9?= Roberto de Souza <jose.souza@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Lucas De Marchi <lucas.demarchi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCAwNCBNYXIgMjAxOSwgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4
LmludGVsLmNvbT4gd3JvdGU6Cj4gT24gRnJpLCBNYXIgMDEsIDIwMTkgYXQgMDQ6NDk6MzRQTSAt
MDgwMCwgSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSB3cm90ZToKPj4gVGhlIGluaXRpYWxpemF0aW9u
IG9mIHRob3NlIGNvbXBvbmVudGVzIGlzIHJlcXVpcmVkIGJ5IHRoZSBHRU0vR1Qgbm90Cj4+IG9u
bHkgZGlzcGxheSBzbyBsZXRzIG1vdmUgdGhlbiB0byBhIG1vcmUgdGhlIGFwcHJvcHJpYXRlIHBs
YWNlLgo+PiAKPj4gQ2M6IEx1Y2FzIERlIE1hcmNoaSA8bHVjYXMuZGVtYXJjaGlAaW50ZWwuY29t
Pgo+PiBDYzogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPj4gU2lnbmVkLW9m
Zi1ieTogSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRlbC5jb20+Cj4+IC0t
LQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYyAgICAgIHwgMzkgKysrKysrKysr
KysrKysrKy0tLS0tLS0tLS0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh
eS5jIHwgIDcgLS0tLS0KPj4gIDIgZmlsZXMgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgMjMg
ZGVsZXRpb25zKC0pCj4+IAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx
NV9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPj4gaW5kZXggY2MwNzI1
OWVjOTQ2Li4yYjVjZTc2NGU2OTQgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2k5MTVfZHJ2LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+PiBA
QCAtNjkxLDI0ICs2OTEsMTUgQEAgc3RhdGljIGludCBpOTE1X21vZGVzZXRfbG9hZChzdHJ1Y3Qg
ZHJtX2RldmljZSAqZGV2KQo+PiAgCWlmIChyZXQpCj4+ICAJCWdvdG8gY2xlYW51cF92Z2FfY2xp
ZW50Owo+PiAgCj4+IC0JLyogbXVzdCBoYXBwZW4gYmVmb3JlIGludGVsX3Bvd2VyX2RvbWFpbnNf
aW5pdF9odygpIG9uIFZMVi9DSFYgKi8KPj4gLQlpbnRlbF91cGRhdGVfcmF3Y2xrKGRldl9wcml2
KTsKPj4gLQo+PiAtCWludGVsX3Bvd2VyX2RvbWFpbnNfaW5pdF9odyhkZXZfcHJpdiwgZmFsc2Up
Owo+PiAtCj4+ICAJaW50ZWxfY3NyX3Vjb2RlX2luaXQoZGV2X3ByaXYpOwo+PiAgCj4+IC0JcmV0
ID0gaW50ZWxfaXJxX2luc3RhbGwoZGV2X3ByaXYpOwo+PiAtCWlmIChyZXQpCj4+IC0JCWdvdG8g
Y2xlYW51cF9jc3I7Cj4+IC0KPj4gIAlpbnRlbF9zZXR1cF9nbWJ1cyhkZXZfcHJpdik7Cj4+ICAK
Pj4gIAkvKiBJbXBvcnRhbnQ6IFRoZSBvdXRwdXQgc2V0dXAgZnVuY3Rpb25zIGNhbGxlZCBieSBt
b2Rlc2V0X2luaXQgbmVlZAo+PiAgCSAqIHdvcmtpbmcgaXJxcyBmb3IgZS5nLiBnbWJ1cyBhbmQg
ZHAgYXV4IHRyYW5zZmVycy4gKi8KPj4gIAlyZXQgPSBpbnRlbF9tb2Rlc2V0X2luaXQoZGV2KTsK
Pj4gIAlpZiAocmV0KQo+PiAtCQlnb3RvIGNsZWFudXBfaXJxOwo+PiArCQlnb3RvIGNsZWFudXBf
Z21idXM7Cj4+ICAKPj4gIAlyZXQgPSBpOTE1X2dlbV9pbml0KGRldl9wcml2KTsKPj4gIAlpZiAo
cmV0KQo+PiBAQCAtNzM2LDEyICs3MjcsOSBAQCBzdGF0aWMgaW50IGk5MTVfbW9kZXNldF9sb2Fk
KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+ICAJaTkxNV9nZW1fZmluaShkZXZfcHJpdik7Cj4+
ICBjbGVhbnVwX21vZGVzZXQ6Cj4+ICAJaW50ZWxfbW9kZXNldF9jbGVhbnVwKGRldik7Cj4+IC1j
bGVhbnVwX2lycToKPj4gLQlkcm1faXJxX3VuaW5zdGFsbChkZXYpOwo+PiArY2xlYW51cF9nbWJ1
czoKPj4gIAlpbnRlbF90ZWFyZG93bl9nbWJ1cyhkZXZfcHJpdik7Cj4+IC1jbGVhbnVwX2NzcjoK
Pj4gIAlpbnRlbF9jc3JfdWNvZGVfZmluaShkZXZfcHJpdik7Cj4+IC0JaW50ZWxfcG93ZXJfZG9t
YWluc19maW5pX2h3KGRldl9wcml2KTsKPj4gIAl2Z2Ffc3dpdGNoZXJvb191bnJlZ2lzdGVyX2Ns
aWVudChwZGV2KTsKPj4gIGNsZWFudXBfdmdhX2NsaWVudDoKPj4gIAl2Z2FfY2xpZW50X3JlZ2lz
dGVyKHBkZXYsIE5VTEwsIE5VTEwsIE5VTEwpOwo+PiBAQCAtMTc2NSw5ICsxNzUzLDE4IEBAIGlu
dCBpOTE1X2RyaXZlcl9sb2FkKHN0cnVjdCBwY2lfZGV2ICpwZGV2LCBjb25zdCBzdHJ1Y3QgcGNp
X2RldmljZV9pZCAqZW50KQo+PiAgCWlmIChyZXQgPCAwKQo+PiAgCQlnb3RvIG91dF9jbGVhbnVw
X21taW87Cj4+ICAKPj4gKwkvKiBtdXN0IGhhcHBlbiBiZWZvcmUgaW50ZWxfcG93ZXJfZG9tYWlu
c19pbml0X2h3KCkgb24gVkxWL0NIViAqLwo+PiArCWludGVsX3VwZGF0ZV9yYXdjbGsoZGV2X3By
aXYpOwo+PiArCj4+ICsJaW50ZWxfcG93ZXJfZG9tYWluc19pbml0X2h3KGRldl9wcml2LCBmYWxz
ZSk7Cj4+ICsKPj4gKwlyZXQgPSBpbnRlbF9pcnFfaW5zdGFsbChkZXZfcHJpdik7Cj4+ICsJaWYg
KHJldCkKPj4gKwkJZ290byBvdXRfY2xlYW51cF9wb3dlcjsKPgo+IFdoYXQgYXJlIHRoZSBzdGVw
cyB3ZSdyZSByZW9yZGVyaW5nIHdydC4gaXJxIGVuYWJsZSBhbmQKPiB3aHkgaXMgaXQgT0sgdG8g
cmVvcmRlciB0aGVtPwoKSSBrZWVwIHRoaW5raW5nIHdlIHNob3VsZCBoYXZlIHByZWNvbmRpdGlv
bnMgd2l0aGluIHRoZSBmdW5jdGlvbnMgdG8KZW5zdXJlIHdlIGRvbid0IGluYWR2ZXJ0ZW50bHkg
YnJlYWsgYW55dGhpbmcuIFdlIGhhdmUgc29tZSBjb21tZW50cywKbGlrZSBhYm92ZSwgYnV0IG5v
d2hlcmUgbmVhciBlbm91Z2gsIGFuZCB0aGV5IGRvbid0IGp1bXAgb3V0IGF0IHlvdSBpZgpzb21l
dGhpbmcgZ29lcyB3cm9uZy4KCkJSLApKYW5pLgoKCj4KPj4gKwo+PiAgCXJldCA9IGk5MTVfbW9k
ZXNldF9sb2FkKCZkZXZfcHJpdi0+ZHJtKTsKPj4gIAlpZiAocmV0IDwgMCkKPj4gLQkJZ290byBv
dXRfY2xlYW51cF9odzsKPj4gKwkJZ290byBvdXRfY2xlYW51cF9pcnE7Cj4+ICAKPj4gIAlpOTE1
X2RyaXZlcl9yZWdpc3RlcihkZXZfcHJpdik7Cj4+ICAKPj4gQEAgLTE3NzcsNyArMTc3NCwxMCBA
QCBpbnQgaTkxNV9kcml2ZXJfbG9hZChzdHJ1Y3QgcGNpX2RldiAqcGRldiwgY29uc3Qgc3RydWN0
IHBjaV9kZXZpY2VfaWQgKmVudCkKPj4gIAo+PiAgCXJldHVybiAwOwo+PiAgCj4+IC1vdXRfY2xl
YW51cF9odzoKPj4gK291dF9jbGVhbnVwX2lycToKPj4gKwlkcm1faXJxX3VuaW5zdGFsbCgmZGV2
X3ByaXYtPmRybSk7Cj4+ICtvdXRfY2xlYW51cF9wb3dlcjoKPj4gKwlpbnRlbF9wb3dlcl9kb21h
aW5zX2ZpbmlfaHcoZGV2X3ByaXYpOwo+PiAgCWk5MTVfZHJpdmVyX2NsZWFudXBfaHcoZGV2X3By
aXYpOwo+PiAgb3V0X2NsZWFudXBfbW1pbzoKPj4gIAlpOTE1X2RyaXZlcl9jbGVhbnVwX21taW8o
ZGV2X3ByaXYpOwo+PiBAQCAtMTgxMCw2ICsxODEwLDEzIEBAIHZvaWQgaTkxNV9kcml2ZXJfdW5s
b2FkKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+ICAKPj4gIAlpbnRlbF9ndnRfY2xlYW51cChk
ZXZfcHJpdik7Cj4+ICAKPj4gKwkvKgo+PiArCSAqIEludGVycnVwdHMgYW5kIHBvbGxpbmcgYXMg
dGhlIGZpcnN0IHRoaW5nIHRvIGF2b2lkIGNyZWF0aW5nIGhhdm9jLgo+PiArCSAqIFRvbyBtdWNo
IHN0dWZmIGhlcmUgKHR1cm5pbmcgb2YgY29ubmVjdG9ycywgLi4uKSB3b3VsZAo+PiArCSAqIGV4
cGVyaWVuY2UgZmFuY3kgcmFjZXMgb3RoZXJ3aXNlLgo+PiArCSAqLwo+PiArCWludGVsX2lycV91
bmluc3RhbGwoZGV2X3ByaXYpOwo+Cj4gVGhpcyB0b28gc2VlbXMgc2xpZ2h0bHkgcXVlc3Rpb25h
YmxlIGNvbnNpZGVyaW5nIHRoZSBmbHVzaF93b3JrcXVldWUoKQo+IGV0Yy4gaW4gaW50ZWxfbW9k
ZXNldF9jbGVhbnVwKCkuIENhbiB3ZSBiZSBzdXJlIGFsbCBtb2Rlc2V0IGFjdGl2aXR5IGhhcwo+
IGluIGZhY3QgZmluaXNoZWQgc3VmZmljaWVudGx5IHRvIG5vIHJlcXVpcmUgaW50ZXJydXB0cz8K
Pgo+PiArCj4+ICAJaTkxNV9tb2Rlc2V0X3VubG9hZChkZXYpOwo+PiAgCj4+ICAJLyogRnJlZSBl
cnJvciBzdGF0ZSBhZnRlciBpbnRlcnJ1cHRzIGFyZSBmdWxseSBkaXNhYmxlZC4gKi8KPj4gZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiBpbmRleCA3OTYzMzQ4ZjFjNjQuLjUxNThl
OGVjYjllZCAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh
eS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiBAQCAt
MTYzNjQsMTMgKzE2MzY0LDYgQEAgdm9pZCBpbnRlbF9tb2Rlc2V0X2NsZWFudXAoc3RydWN0IGRy
bV9kZXZpY2UgKmRldikKPj4gIAlmbHVzaF93b3JrKCZkZXZfcHJpdi0+YXRvbWljX2hlbHBlci5m
cmVlX3dvcmspOwo+PiAgCVdBUk5fT04oIWxsaXN0X2VtcHR5KCZkZXZfcHJpdi0+YXRvbWljX2hl
bHBlci5mcmVlX2xpc3QpKTsKPj4gIAo+PiAtCS8qCj4+IC0JICogSW50ZXJydXB0cyBhbmQgcG9s
bGluZyBhcyB0aGUgZmlyc3QgdGhpbmcgdG8gYXZvaWQgY3JlYXRpbmcgaGF2b2MuCj4+IC0JICog
VG9vIG11Y2ggc3R1ZmYgaGVyZSAodHVybmluZyBvZiBjb25uZWN0b3JzLCAuLi4pIHdvdWxkCj4+
IC0JICogZXhwZXJpZW5jZSBmYW5jeSByYWNlcyBvdGhlcndpc2UuCj4+IC0JICovCj4+IC0JaW50
ZWxfaXJxX3VuaW5zdGFsbChkZXZfcHJpdik7Cj4+IC0KPj4gIAkvKgo+PiAgCSAqIER1ZSB0byB0
aGUgaHBkIGlycSBzdG9ybSBoYW5kbGluZyB0aGUgaG90cGx1ZyB3b3JrIGNhbiByZS1hcm0gdGhl
Cj4+ICAJICogcG9sbCBoYW5kbGVycy4gSGVuY2UgZGlzYWJsZSBwb2xsaW5nIGFmdGVyIGhwZCBo
YW5kbGluZyBpcyBzaHV0IGRvd24uCj4+IC0tIAo+PiAyLjIxLjAKPj4gCj4+IF9fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+IEludGVsLWdmeCBtYWlsaW5n
IGxpc3QKPj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBodHRwczovL2xpc3Rz
LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkphbmkgTmlr
dWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl
bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4