All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Leonardo Soares Müller" <leozinho29_eu@hotmail.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Key repeat is no longer working on TTY and grub menu
Date: Wed, 13 Feb 2019 07:01:35 +0100	[thread overview]
Message-ID: <875ztokz0g.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20190212131136.GH9386@redhat.com> ("Daniel P. =?utf-8?Q?Berr?= =?utf-8?Q?ang=C3=A9=22's?= message of "Tue, 12 Feb 2019 13:11:36 +0000")

Daniel P. Berrangé <berrange@redhat.com> writes:

> Yes, this is another regression accidentally introduced by the keyboard
> state tracker.
>
> When GTK does key repeat it omits the Up event for repeated keys.
>
> IOW, you get
>
>     Press (a)
>     Press (a)
>     Press (a)
>     Release (a)

This is how keyboards commonly do it, if I remember correctly.

> Not
>
>     Press (a)
>     Release (a)
>     Press (a)
>     Release (a)
>     Press (a)
>     Release (a)
>
> The keyboard state tracker doesn't take this into account, so it is
> surpressing all except the first Press event.
>
> This might affect other frontends too if they use the same trick for
> key repeat

Plausible.

  reply	other threads:[~2019-02-13  6:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-12 13:02 [Qemu-devel] Key repeat is no longer working on TTY and grub menu Leonardo Soares Müller
2019-02-12 13:11 ` Daniel P. Berrangé
2019-02-13  6:01   ` Markus Armbruster [this message]
2019-02-19  8:19     ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875ztokz0g.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=leozinho29_eu@hotmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.