From: Markus Armbruster <armbru@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, eblake@redhat.com,
mreitz@redhat.com, kwolf@redhat.com, den@openvz.org,
nshirokovskiy@virtuozzo.com, pizhenwei@bytedance.com
Subject: Re: [Qemu-devel] [PATCH v3 1/2] qapi: move to QOM path for x-block-latency-histogram-set
Date: Tue, 08 Jan 2019 14:20:07 +0100 [thread overview]
Message-ID: <875zuznv5k.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20181221165341.23736-2-vsementsov@virtuozzo.com> (Vladimir Sementsov-Ogievskiy's message of "Fri, 21 Dec 2018 19:53:40 +0300")
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
> Move to way of device selecting, however fall back to device name if
> path is not found.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> qapi/block-core.json | 4 ++--
> blockdev.c | 22 +++++++++++++++-------
> 2 files changed, 17 insertions(+), 9 deletions(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 762000f31f..bb70c51a57 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -489,7 +489,7 @@
> # If only @device parameter is specified, remove all present latency histograms
> # for the device. Otherwise, add/reset some of (or all) latency histograms.
> #
> -# @device: device name to set latency histogram for.
> +# @id: The QOM path or name of the guest device.
> #
> # @boundaries: list of interval boundary values (see description in
> # BlockLatencyHistogramInfo definition). If specified, all
Is such overloaded semantics what we want in new interfaces?
Hmm, looks like there's ample precedence for it. Escaped my grep at
first because its commonly documented as "The name or QOM path of the
guest device". Suggest to stick to that for consistency.
> @@ -547,7 +547,7 @@
> # <- { "return": {} }
> ##
> { 'command': 'x-block-latency-histogram-set',
> - 'data': {'device': 'str',
> + 'data': {'id': 'str',
> '*boundaries': ['uint64'],
> '*boundaries-read': ['uint64'],
> '*boundaries-write': ['uint64'],
[...]
next prev parent reply other threads:[~2019-01-08 13:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 16:53 [Qemu-devel] [PATCH v3 0/2] improve block-latency-histogram-set Vladimir Sementsov-Ogievskiy
2018-12-21 16:53 ` [Qemu-devel] [PATCH v3 1/2] qapi: move to QOM path for x-block-latency-histogram-set Vladimir Sementsov-Ogievskiy
2019-01-08 13:20 ` Markus Armbruster [this message]
2019-02-11 17:39 ` Vladimir Sementsov-Ogievskiy
2019-02-11 17:52 ` Kevin Wolf
2019-02-11 18:33 ` Vladimir Sementsov-Ogievskiy
2019-02-11 17:54 ` Kevin Wolf
2019-02-11 18:30 ` Vladimir Sementsov-Ogievskiy
2019-02-12 9:07 ` Kevin Wolf
2019-02-12 9:51 ` Vladimir Sementsov-Ogievskiy
2018-12-21 16:53 ` [Qemu-devel] [PATCH v3 2/2] qapi: drop x- from x-block-latency-histogram-set Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zuznv5k.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=nshirokovskiy@virtuozzo.com \
--cc=pizhenwei@bytedance.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.