From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
"José Roberto de Souza" <jose.souza@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 06/16] drm/i915: Don't call modeset related functions when display is disabled
Date: Mon, 22 Oct 2018 12:00:39 +0300 [thread overview]
Message-ID: <875zxufj9k.fsf@intel.com> (raw)
In-Reply-To: <154019743226.18004.16272504458708763626@skylake-alporthouse-com>
On Mon, 22 Oct 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2018-10-22 09:25:45)
>> On Fri, 12 Oct 2018, José Roberto de Souza <jose.souza@intel.com> wrote:
>> > Display features should not be initialized or deinitialized when
>> > display is disabled.
>
> I completely disagree with this assertion. If the display is disabled,
> so must all the associated hw so that we can power down the entire
> chipset when idle. That means we have to complete the probe (so we
> continue to rely on fuses and in place of accurate fuses pci-id quirks
> for the infamous chipsets) and switch it off.
That actually doesn't contradict with what I said about
HAS_DISPLAY(). In many cases I think the early return on no display is
the right thing to do. However, no display isn't the same as display
disabled by module parameter (or whatnot)... which does require probe
before disable to achieve the power down.
But is the power down on display disable by module parameter a
requirement for us?
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-22 9:01 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 21:52 [PATCH 01/16] drm/i915: Properly set PCH as NOP when display is disabled José Roberto de Souza
2018-10-12 21:52 ` [PATCH 02/16] drm/i915: Move out non-display related calls from display/modeset init/cleanup José Roberto de Souza
2018-10-15 11:14 ` Chris Wilson
2018-10-15 23:51 ` Souza, Jose
2018-10-12 21:52 ` [PATCH 03/16] drm/i915: Move drm_vblank_init() to i915_load_modeset_init() José Roberto de Souza
2018-10-12 21:52 ` [PATCH 04/16] drm/i915: Move FBC init and cleanup calls to modeset functions José Roberto de Souza
2018-10-12 21:52 ` [PATCH 05/16] drm/i915: Move intel_init_ipc() call to i915_load_modeset_init() José Roberto de Souza
2018-10-12 21:52 ` [PATCH 06/16] drm/i915: Don't call modeset related functions when display is disabled José Roberto de Souza
2018-10-22 8:25 ` Jani Nikula
2018-10-22 8:37 ` Chris Wilson
2018-10-22 9:00 ` Jani Nikula [this message]
2018-10-25 17:38 ` Souza, Jose
2019-04-08 20:50 ` Chris Wilson
2019-08-24 9:51 ` Chris Wilson
2018-10-12 21:52 ` [PATCH 07/16] drm/i915: Remove redundant checks for num_pipes == 0 José Roberto de Souza
2018-10-22 8:31 ` Jani Nikula
2018-10-12 21:52 ` [PATCH 08/16] drm/i915: Keep overlay functions naming consistent José Roberto de Souza
2018-10-22 8:32 ` Jani Nikula
2018-10-12 21:52 ` [PATCH 09/16] drm/i915: Do not reset display when display is disabled José Roberto de Souza
2018-10-22 8:34 ` Jani Nikula
2018-10-12 21:52 ` [PATCH 10/16] drm/i915: Do not initialize display clocks " José Roberto de Souza
2018-10-22 8:37 ` Jani Nikula
2018-10-12 21:52 ` [PATCH 11/16] drm/i915: Do not initialize display core " José Roberto de Souza
2018-10-22 8:39 ` Jani Nikula
2018-10-12 21:52 ` [PATCH 12/16] drm/i915: Warn when display irq functions is executed " José Roberto de Souza
2018-10-22 8:40 ` Jani Nikula
2018-10-12 21:52 ` [PATCH 13/16] drm/i915: Do not print DC off mismatch state when DMC firmware in not loaded José Roberto de Souza
2018-10-15 10:58 ` Imre Deak
2018-10-16 1:31 ` Souza, Jose
2018-10-16 9:35 ` Imre Deak
2018-10-12 21:52 ` [PATCH 14/16] drm/i915: Do not turn power wells on or off when display is disabled José Roberto de Souza
2018-10-22 8:50 ` Jani Nikula
2018-10-12 21:52 ` [PATCH 15/16] drm/i915: Power down any power well left on by BIOS José Roberto de Souza
2018-10-15 11:06 ` Imre Deak
2018-10-16 0:05 ` Souza, Jose
2018-10-16 9:39 ` Imre Deak
2018-10-12 21:52 ` [PATCH 16/16] drm/i915: Guard debugfs against invalid access when display is disabled José Roberto de Souza
2018-10-22 8:52 ` Jani Nikula
2018-10-12 22:03 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/16] drm/i915: Properly set PCH as NOP " Patchwork
2018-10-12 22:07 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-10-12 22:27 ` ✓ Fi.CI.BAT: success " Patchwork
2018-10-13 2:46 ` ✓ Fi.CI.IGT: " Patchwork
2018-11-03 21:41 ` [PATCH 01/16] " Jani Nikula
2018-11-30 8:29 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zxufj9k.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.