From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] lua: fix dynamic library install
Date: Fri, 05 Oct 2018 22:04:46 +0200 [thread overview]
Message-ID: <875zyg17oh.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180928173519.9731-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Fri, 28 Sep 2018 19:35:18 +0200")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> In 0002-shared-libs-for-lua.patch, revision number is used to set
> library name:
> TO_SOLIB = liblua.so.$(R)
> However, library is built using PKG_VERSION which is passed only during
> build step:
> $(CC) -o $@.$(PKG_VERSION) -shared -Wl,-soname="$@.$(PKG_VERSION)" $?
> As a result, dynamic library is not installed in staging or target paths
> since bump to lua 5.3.5
> So, instead of replacing R by PKG_VERSION and passing this variable in
> all steps, simply update R to 5
> Fixes:
> - http://autobuild.buildroot.net/results/28b6672188bb0082ac1467d3b45904880e3634f3
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2018.08.x, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2018-10-05 20:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 17:35 [Buildroot] [PATCH 1/2] lua: fix dynamic library install Fabrice Fontaine
2018-09-28 17:35 ` [Buildroot] [PATCH 2/2] haproxy: fix linking with lua Fabrice Fontaine
2018-10-01 13:17 ` Peter Korsgaard
2018-09-29 7:39 ` [Buildroot] [PATCH 1/2] lua: fix dynamic library install François Perrad
2018-10-05 19:04 ` François Perrad
2018-10-01 13:17 ` Peter Korsgaard
2018-10-05 20:04 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zyg17oh.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.