From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:37652 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387911AbeHAK0S (ORCPT ); Wed, 1 Aug 2018 06:26:18 -0400 From: Kalle Valo To: Stanislaw Gruszka Cc: linux-wireless@vger.kernel.org, Lorenzo Bianconi , Felix Fietkau , Hans Ulli Kroll , Jakub Kicinski , Michal Schmidt , linux-mediatek@lists.infradead.org Subject: Re: [PATCH v3 12/14] mt76: Kconfig and Makefile for mt76x0 driver References: <1533040864-9026-1-git-send-email-sgruszka@redhat.com> <1533040864-9026-13-git-send-email-sgruszka@redhat.com> <8736vy1r0j.fsf@purkki.adurom.net> <20180801082844.GB4526@redhat.com> Date: Wed, 01 Aug 2018 11:41:33 +0300 In-Reply-To: <20180801082844.GB4526@redhat.com> (Stanislaw Gruszka's message of "Wed, 1 Aug 2018 10:28:45 +0200") Message-ID: <87600u8on6.fsf@kamboji.qca.qualcomm.com> (sfid-20180801_105647_191532_CDCBA5D4) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Stanislaw Gruszka writes: > On Wed, Aug 01, 2018 at 10:32:12AM +0300, Kalle Valo wrote: >> Stanislaw Gruszka writes: >> >> > Add Kconfig and Makefiles for mt76x0 driver. Now the driver >> > can be build. >> > >> > Signed-off-by: Stanislaw Gruszka >> > --- >> > drivers/net/wireless/mediatek/mt76/Kconfig | 7 +++++++ >> > drivers/net/wireless/mediatek/mt76/Makefile | 1 + >> > drivers/net/wireless/mediatek/mt76/mt76x0/Makefile | 7 +++++++ >> > 3 files changed, 15 insertions(+) >> > create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/Makefile >> > >> > diff --git a/drivers/net/wireless/mediatek/mt76/Kconfig b/drivers/net/wireless/mediatek/mt76/Kconfig >> > index 69906c733a1c..850611ad347a 100644 >> > --- a/drivers/net/wireless/mediatek/mt76/Kconfig >> > +++ b/drivers/net/wireless/mediatek/mt76/Kconfig >> > @@ -9,6 +9,13 @@ config MT76x2_COMMON >> > tristate >> > depends on MT76_CORE >> > >> > +config MT76x0U >> > + tristate "MediaTek MT76x0U (USB) support" >> > + depends on MAC80211 >> > + depends on USB >> > + help >> > + This adds support for MT7610U-based wireless USB dongles. >> >> Does it make sense to add a Kconfig option for every mt76 device? I'm >> worried that soon we have over a dozen of them. I can understand having >> separate options to enable PCI or USB devices, but I don't see the >> benefit for anything more finegrained than that. > > I think it does make sense for AP/home routers and other embedded > devices. How much of memory savings are we talking about? -- Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH v3 12/14] mt76: Kconfig and Makefile for mt76x0 driver Date: Wed, 01 Aug 2018 11:41:33 +0300 Message-ID: <87600u8on6.fsf@kamboji.qca.qualcomm.com> References: <1533040864-9026-1-git-send-email-sgruszka@redhat.com> <1533040864-9026-13-git-send-email-sgruszka@redhat.com> <8736vy1r0j.fsf@purkki.adurom.net> <20180801082844.GB4526@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20180801082844.GB4526-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> (Stanislaw Gruszka's message of "Wed, 1 Aug 2018 10:28:45 +0200") Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stanislaw Gruszka Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Lorenzo Bianconi , Felix Fietkau , Hans Ulli Kroll , Jakub Kicinski , Michal Schmidt , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-mediatek@lists.infradead.org Stanislaw Gruszka writes: > On Wed, Aug 01, 2018 at 10:32:12AM +0300, Kalle Valo wrote: >> Stanislaw Gruszka writes: >> >> > Add Kconfig and Makefiles for mt76x0 driver. Now the driver >> > can be build. >> > >> > Signed-off-by: Stanislaw Gruszka >> > --- >> > drivers/net/wireless/mediatek/mt76/Kconfig | 7 +++++++ >> > drivers/net/wireless/mediatek/mt76/Makefile | 1 + >> > drivers/net/wireless/mediatek/mt76/mt76x0/Makefile | 7 +++++++ >> > 3 files changed, 15 insertions(+) >> > create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/Makefile >> > >> > diff --git a/drivers/net/wireless/mediatek/mt76/Kconfig b/drivers/net/wireless/mediatek/mt76/Kconfig >> > index 69906c733a1c..850611ad347a 100644 >> > --- a/drivers/net/wireless/mediatek/mt76/Kconfig >> > +++ b/drivers/net/wireless/mediatek/mt76/Kconfig >> > @@ -9,6 +9,13 @@ config MT76x2_COMMON >> > tristate >> > depends on MT76_CORE >> > >> > +config MT76x0U >> > + tristate "MediaTek MT76x0U (USB) support" >> > + depends on MAC80211 >> > + depends on USB >> > + help >> > + This adds support for MT7610U-based wireless USB dongles. >> >> Does it make sense to add a Kconfig option for every mt76 device? I'm >> worried that soon we have over a dozen of them. I can understand having >> separate options to enable PCI or USB devices, but I don't see the >> benefit for anything more finegrained than that. > > I think it does make sense for AP/home routers and other embedded > devices. How much of memory savings are we talking about? -- Kalle Valo