Re: [Qemu-devel] [PATCH v2 14/21] travis: dump config.log if ./configure script fails

From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-devel@nongnu.org, Fam Zheng <famz@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2 14/21] travis: dump config.log if ./configure script fails
Date: Thu, 22 Jun 2017 11:23:47 +0100	[thread overview]
Message-ID: <8760fotj64.fsf@linaro.org> (raw)
In-Reply-To: <20170622033231.19344-15-f4bug@amsat.org>

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 96ddc16cfd..bac5bea744 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -93,7 +93,7 @@ before_script:
>    - if [ -x "$(command -v ccache 2>/dev/null)" ]; then export CC="ccache ${CC}"; ccache -s -M 0 -z; fi
>    - echo "Using ${PARALLEL_JOBS} parallel jobs"
>    - export HOST_CC="${CC}"
> -  - ./configure ${CONFIG}
> +  - ./configure ${CONFIG} || cat config.log

Won't the explicit || mean the job will keep trying even if config is
broken? Should it be || cat config.log && false?

>  script:
>    - make -j${PARALLEL_JOBS} && ccache -s
>    - ${TEST_CMD}

--
Alex Bennée