All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, lvivier@redhat.com, dgilbert@redhat.com,
	peterx@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/5] migration: Remove use of old MigrationParams
Date: Fri, 19 May 2017 12:54:36 +0200	[thread overview]
Message-ID: <8760gxce1f.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20170518111837.29212-4-quintela@redhat.com> (Juan Quintela's message of "Thu, 18 May 2017 13:18:35 +0200")

Juan Quintela <quintela@redhat.com> writes:

> We have change in the previous patch to use migration capabilities for
> it.  Notice that we continue using the old command line flags from
> migrate command from the time being.  Remove the set_params method as
> now it is empty.
>
> For savevm, one can't do a:
>
> savevm -b/-i foo

Yes (savem has no such options).

> but now one can do:
>
> migrate_set_capability block on
> savevm foo
>
> And we can't use block migration. We could disable block capability
> unconditionally, but it would not be much better.

This leaves me confused: what does the example do?  Reading ahead...
looks like it fails with "Block migration and snapshots are
incompatible".  What are you trying to say here?

> Signed-off-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>

Patch looks good to me.

  reply	other threads:[~2017-05-19 10:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18 11:18 [Qemu-devel] [PATCH 0/5] Remove old MigrationParams Juan Quintela
2017-05-18 11:18 ` [Qemu-devel] [PATCH 1/5] hmp: Use visitor api for hmp_migrate_set_parameter() Juan Quintela
2017-05-18 11:18 ` [Qemu-devel] [PATCH 2/5] migration: Create block capability Juan Quintela
2017-05-18 14:49   ` Eric Blake
2017-05-19  9:20   ` Markus Armbruster
2017-05-18 11:18 ` [Qemu-devel] [PATCH 3/5] migration: Remove use of old MigrationParams Juan Quintela
2017-05-19 10:54   ` Markus Armbruster [this message]
2017-05-24 12:48     ` Markus Armbruster
2017-05-18 11:18 ` [Qemu-devel] [PATCH 4/5] migration: Remove " Juan Quintela
2017-05-18 11:18 ` [Qemu-devel] [PATCH 5/5] block migration: Allow compile time disable Juan Quintela
2017-05-18 12:19   ` Dr. David Alan Gilbert
2017-05-18 13:08     ` Juan Quintela
2017-05-18 14:50   ` Eric Blake
2017-05-18 12:15 ` [Qemu-devel] [PATCH 0/5] Remove old MigrationParams Dr. David Alan Gilbert
2017-05-18 13:10   ` Juan Quintela
  -- strict thread matches above, loose matches on Subject: below --
2017-05-17 15:38 [Qemu-devel] [PATCH v5 " Juan Quintela
2017-05-17 15:38 ` [Qemu-devel] [PATCH 3/5] migration: Remove use of " Juan Quintela
2017-05-17 15:54   ` Eric Blake
2017-05-17 16:18     ` Juan Quintela
2017-05-24 12:28   ` Markus Armbruster
2017-05-24 12:44     ` Markus Armbruster
2017-05-16 11:11 [Qemu-devel] [PATCH v4 0/5] Remove " Juan Quintela
2017-05-16 11:11 ` [Qemu-devel] [PATCH 3/5] migration: Remove use of " Juan Quintela
2017-05-16 14:22   ` Markus Armbruster
2017-05-16 14:36     ` Juan Quintela
2017-05-16 15:35       ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8760gxce1f.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.