From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915/dp: Validate cached link rate and lane count before retraining
Date: Wed, 29 Mar 2017 15:11:46 +0300 [thread overview]
Message-ID: <8760is5lkt.fsf@intel.com> (raw)
In-Reply-To: <20170329114604.GW30290@intel.com>
On Wed, 29 Mar 2017, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Mar 29, 2017 at 10:29:24AM +0300, Jani Nikula wrote:
>> On Tue, 28 Mar 2017, Manasi Navare <manasi.d.navare@intel.com> wrote:
>> > Jani,
>> >
>> > Should I just hold on to this until your patch series
>> > gets merged so I can rebase this on top of it?
>>
>> I think I'd prefer that, especially so because I'm not sure that this
>> patch does the right thing. Yes, this checks that the values are within
>> bounds, but that they are within bounds doesn't make them any more valid
>> for the current link if they are indeed stale!
>
> Can they be stale and still be within the bounds somehow?
Maybe not. Maybe I just don't follow. Perhaps the commit message
deserves a better description of the cases where we hit the case.
>> >> +static bool intel_dp_link_params_is_valid(struct intel_dp *intel_dp)
Side note, it bugs me that the function name has a grammatical error.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-03-29 12:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 21:44 [PATCH v2] drm/i915/dp: Validate cached link rate and lane count before retraining Manasi Navare
2017-03-27 22:16 ` ✓ Fi.CI.BAT: success for drm/i915/dp: Validate cached link rate and lane count before retraining (rev2) Patchwork
2017-03-28 15:55 ` [PATCH v2] drm/i915/dp: Validate cached link rate and lane count before retraining Manasi Navare
2017-03-29 7:29 ` Jani Nikula
2017-03-29 11:46 ` Ville Syrjälä
2017-03-29 12:11 ` Jani Nikula [this message]
2017-03-29 17:41 ` Manasi Navare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760is5lkt.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.