From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= Subject: Re: 4.11-rc1 regression: e1000e "BUG at drivers/pci/msi.c" on unplugged suspend+resume Date: Mon, 06 Mar 2017 13:03:16 +0100 Message-ID: <8760jmipdn.fsf@miraculix.mork.no> References: <87bmten48r.fsf@miraculix.mork.no> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org, khalidm , David Singleton , Aaron Brown , Jeff Kirsher To: intel-wired-lan@lists.osuosl.org Return-path: Received: from canardo.mork.no ([148.122.252.1]:43301 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753027AbdCFMDi (ORCPT ); Mon, 6 Mar 2017 07:03:38 -0500 In-Reply-To: <87bmten48r.fsf@miraculix.mork.no> (=?utf-8?Q?=22Bj=C3=B8rn?= Mork"'s message of "Mon, 06 Mar 2017 10:28:36 +0100") Sender: netdev-owner@vger.kernel.org List-ID: Bj=C3=B8rn Mork writes: > This is new with v4.11-rc1, so I strongly suspect commit 7e54d9d063fa > ("e1000e: driver trying to free already-free irq"), which looks more > than suspicious in this context. Haven't had time to test a revert > yet. Just wanted to give an advance warning in case this isn't known. Now tested. I can confirm that reverting commit 7e54d9d063fa ("e1000e: driver trying to free already-free irq") fixes the issue. Further testing also shows that "netif running" is irrelevant. The BUG happens consistently on revery system resume, regardless of the e1000e link state. Which sort of indicates that this change to the driver's freeze callback wasn't tested with system suspend. Which seems.... odd? Well, whatever. Please revert commit 7e54d9d063fa. Bj=C3=B8rn From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?unknown-8bit?q?Bj=C3=B8rn?= Mork Date: Mon, 06 Mar 2017 13:03:16 +0100 Subject: [Intel-wired-lan] 4.11-rc1 regression: e1000e "BUG at drivers/pci/msi.c" on unplugged suspend+resume In-Reply-To: <87bmten48r.fsf@miraculix.mork.no> (=?utf-8?Q?=22Bj=C3=B8rn?= Mork"'s message of "Mon, 06 Mar 2017 10:28:36 +0100") References: <87bmten48r.fsf@miraculix.mork.no> Message-ID: <8760jmipdn.fsf@miraculix.mork.no> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: Bj?rn Mork writes: > This is new with v4.11-rc1, so I strongly suspect commit 7e54d9d063fa > ("e1000e: driver trying to free already-free irq"), which looks more > than suspicious in this context. Haven't had time to test a revert > yet. Just wanted to give an advance warning in case this isn't known. Now tested. I can confirm that reverting commit 7e54d9d063fa ("e1000e: driver trying to free already-free irq") fixes the issue. Further testing also shows that "netif running" is irrelevant. The BUG happens consistently on revery system resume, regardless of the e1000e link state. Which sort of indicates that this change to the driver's freeze callback wasn't tested with system suspend. Which seems.... odd? Well, whatever. Please revert commit 7e54d9d063fa. Bj?rn