From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752200AbdBMKpv (ORCPT ); Mon, 13 Feb 2017 05:45:51 -0500 Received: from mga01.intel.com ([192.55.52.88]:25006 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751739AbdBMKpt (ORCPT ); Mon, 13 Feb 2017 05:45:49 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,156,1484035200"; d="asc'?scan'208";a="58050975" From: Felipe Balbi To: Colin King , Greg Kroah-Hartman , Peter Chen , Alan Stern , Mathias Nyman , Lu Baolu , Chunfeng Yun , linux-usb@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: misc: usbtest: remove redundant check on retval < 0 In-Reply-To: <20170212183518.22528-1-colin.king@canonical.com> References: <20170212183518.22528-1-colin.king@canonical.com> Date: Mon, 13 Feb 2017 12:45:19 +0200 Message-ID: <8760keqshs.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Colin King writes: > From: Colin Ian King > > The check for retval being less than zero is always true since > retval equal to -EPIPE at that point. Replace the existing > conditional with just return retval. > > Detected with CoverityScan, CID#114349 ("Logically dead code") > > Signed-off-by: Colin Ian King > --- > drivers/usb/misc/usbtest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c > index 3525626..17c0810 100644 > --- a/drivers/usb/misc/usbtest.c > +++ b/drivers/usb/misc/usbtest.c > @@ -992,7 +992,7 @@ static int ch9_postconfig(struct usbtest_dev *dev) > dev_err(&iface->dev, > "hs dev qualifier --> %d\n", > retval); > - return (retval < 0) ? retval : -EDOM; > + return retval; you're changing return value here, are you sure there's nothing else depending on this error? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlihjj8ACgkQzL64meEa mQYvtg/9HhgZ4m7JdUhu+TRvdcFdq2v7K7kZONnLXsC9IOGYWq+/OpNUnYXN3JI3 0300LtgNp21G9SjOMcGx3654UVPtS7gBLvRVdCnSFyAVM8TlM4GL1OvFwZUPeuYE FLQN5q2/QVi01PCfMXDdd2vwDsmraOrcTihi+Om29xx26gYsrH9R7CTjj5mQj/4k xvbsnWtCMJhReUpPxfqHn7uPAZNDTTutctIHC+x1Et471bZtWF0azphAwtigIvak 9xoG7cGU7Vlt8NWfSHSjJ0scf9bTaFN/khdC2D2cLfZe7rrpYFEvEz9tH3hjdHaT PUljULcYxTa44RChCK1MgmhOuRbhnoewnKm+HwONDYianKcO9FwlXjtZMapuTawk hbJTGW+pa3O4VgmmmKcvunPhp+6eM97pUoDS+8T+7RndERVa7RlnM5DdrnaKDsJL pSJtMJrHZWRKT9mt0++IFdNY88xz4Bh1VHirx3odB08OS9k3+QIweYTYXQFnPDKc brGMnkZj/k58bmTXg6Y6Jez2Yxb+qtPizjHiXOtlVjr1fyBrB487rBJsrwQt9ECy puUnpaB1lkOKLnFXmbMAoYBC2lG2L8/BDCjc75HIxCAuqEnJ/0sFQw1c/3zLvJVN h+fg6N8C+BbufNvW94CYc3OzIpGPyZh7VQJk7ZBdSCqDyB1vc0Y= =Ut3O -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Date: Mon, 13 Feb 2017 10:45:19 +0000 Subject: Re: [PATCH] usb: misc: usbtest: remove redundant check on retval < 0 Message-Id: <8760keqshs.fsf@linux.intel.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: References: <20170212183518.22528-1-colin.king@canonical.com> In-Reply-To: <20170212183518.22528-1-colin.king@canonical.com> To: Colin King , Greg Kroah-Hartman , Peter Chen , Alan Stern , Mathias Nyman , Lu Baolu , Chunfeng Yun , linux-usb@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Colin King writes: > From: Colin Ian King > > The check for retval being less than zero is always true since > retval equal to -EPIPE at that point. Replace the existing > conditional with just return retval. > > Detected with CoverityScan, CID#114349 ("Logically dead code") > > Signed-off-by: Colin Ian King > --- > drivers/usb/misc/usbtest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c > index 3525626..17c0810 100644 > --- a/drivers/usb/misc/usbtest.c > +++ b/drivers/usb/misc/usbtest.c > @@ -992,7 +992,7 @@ static int ch9_postconfig(struct usbtest_dev *dev) > dev_err(&iface->dev, > "hs dev qualifier --> %d\n", > retval); > - return (retval < 0) ? retval : -EDOM; > + return retval; you're changing return value here, are you sure there's nothing else depending on this error? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlihjj8ACgkQzL64meEa mQYvtg/9HhgZ4m7JdUhu+TRvdcFdq2v7K7kZONnLXsC9IOGYWq+/OpNUnYXN3JI3 0300LtgNp21G9SjOMcGx3654UVPtS7gBLvRVdCnSFyAVM8TlM4GL1OvFwZUPeuYE FLQN5q2/QVi01PCfMXDdd2vwDsmraOrcTihi+Om29xx26gYsrH9R7CTjj5mQj/4k xvbsnWtCMJhReUpPxfqHn7uPAZNDTTutctIHC+x1Et471bZtWF0azphAwtigIvak 9xoG7cGU7Vlt8NWfSHSjJ0scf9bTaFN/khdC2D2cLfZe7rrpYFEvEz9tH3hjdHaT PUljULcYxTa44RChCK1MgmhOuRbhnoewnKm+HwONDYianKcO9FwlXjtZMapuTawk hbJTGW+pa3O4VgmmmKcvunPhp+6eM97pUoDS+8T+7RndERVa7RlnM5DdrnaKDsJL pSJtMJrHZWRKT9mt0++IFdNY88xz4Bh1VHirx3odB08OS9k3+QIweYTYXQFnPDKc brGMnkZj/k58bmTXg6Y6Jez2Yxb+qtPizjHiXOtlVjr1fyBrB487rBJsrwQt9ECy puUnpaB1lkOKLnFXmbMAoYBC2lG2L8/BDCjc75HIxCAuqEnJ/0sFQw1c/3zLvJVN h+fg6N8C+BbufNvW94CYc3OzIpGPyZh7VQJk7ZBdSCqDyB1vc0Y= =Ut3O -----END PGP SIGNATURE----- --=-=-=--