From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Jeff King <peff@peff.net>, Stefan Beller <sbeller@google.com>
Cc: git@vger.kernel.org, jvoss@altsci.com,
"Aneesh Kumar K.V" <aneesh.kumar@gmail.com>
Subject: Re: [PATCH] contrib: remove gitview
Date: Mon, 02 Jan 2017 12:16:17 +0530 [thread overview]
Message-ID: <8760lyc62u.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20161229015918.jyiqd42z4htjibul@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> On Wed, Dec 28, 2016 at 09:28:37AM -0800, Stefan Beller wrote:
>
>> gitview did not have meaningful contributions since 2007, which gives the
>> impression it is either a mature or dead project.
>>
>> In both cases we should not carry it in git.git as the README for contrib
>> states we only want to carry experimental things to give early exposure.
>>
>> Recently a security vulnerability was reported by Javantea, so the decision
>> to either fix the issue or remove the code in question becomes a bit
>> more urgent.
>>
>> Reported-by: Javantea <jvoss@altsci.com>
>> Signed-off-by: Stefan Beller <sbeller@google.com>
>> ---
>> contrib/gitview/gitview | 1305 -------------------------------------------
>> contrib/gitview/gitview.txt | 57 --
>> 2 files changed, 1362 deletions(-)
>> delete mode 100755 contrib/gitview/gitview
>> delete mode 100644 contrib/gitview/gitview.txt
>
> Thanks for assembling the patch. This seems reasonable to me, though I'd
> like to get an Ack from Aneesh if we can.
Acked-by: Aneesh Kumar K.V <aneesh.kumar@gmail.com>
-aneesh
next prev parent reply other threads:[~2017-01-02 6:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 8:29 Gitview Shell Injection Vulnerability Javantea
2016-12-27 18:45 ` Stefan Beller
2016-12-28 6:42 ` Jeff King
2016-12-28 17:28 ` [PATCH] contrib: remove gitview Stefan Beller
2016-12-29 1:59 ` Jeff King
2017-01-01 0:55 ` Junio C Hamano
2017-01-02 6:46 ` Aneesh Kumar K.V [this message]
2016-12-28 19:28 ` Javantea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760lyc62u.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=aneesh.kumar@gmail.com \
--cc=git@vger.kernel.org \
--cc=jvoss@altsci.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.